From 378a0bed06ba8f5ce0cfbf30c4bc502de137f186 Mon Sep 17 00:00:00 2001
From: PJ Fanning <fanningpj@apache.org>
Date: Tue, 27 May 2025 20:15:50 +0000
Subject: [PATCH] [bug-69669] refactor

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1925874 13f79535-47bb-0310-9956-ffa450edef68
---
 .../org/apache/poi/hslf/usermodel/HSLFSimpleShape.java     | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/poi-scratchpad/src/main/java/org/apache/poi/hslf/usermodel/HSLFSimpleShape.java b/poi-scratchpad/src/main/java/org/apache/poi/hslf/usermodel/HSLFSimpleShape.java
index 259a8c8a05..aa85a65a92 100644
--- a/poi-scratchpad/src/main/java/org/apache/poi/hslf/usermodel/HSLFSimpleShape.java
+++ b/poi-scratchpad/src/main/java/org/apache/poi/hslf/usermodel/HSLFSimpleShape.java
@@ -587,6 +587,8 @@ public abstract class HSLFSimpleShape extends HSLFShape implements SimpleShape<H
 
     @Override
     public void setPlaceholder(Placeholder placeholder) {
+        // reset the placeholder details so that the next call to getPlaceholderDetails() will reinitialize it
+        _placeholderDetails = null;
         updateSPRecord(this, placeholder);
 
         if (placeholder == null) {
@@ -640,11 +642,6 @@ public abstract class HSLFSimpleShape extends HSLFShape implements SimpleShape<H
                 }
                 break;
         }
-        // reverted this call because of https://bz.apache.org/bugzilla/show_bug.cgi?id=69669
-        //getPlaceholderDetails().setPlaceholder(placeholder);
-
-        // reset the placeholder details so that the next call to getPlaceholderDetails() will reinitialize it
-        _placeholderDetails = null;
     }
 
     @Override