pashko/apache-poi
1
0
Fork 0
mirror of https://github.com/apache/poi.git synced 2026-02-27 12:30:08 +08:00
Code Issues Packages Projects Releases Wiki Activity

Do not call getColumn() twice

Browse Source 
It always iterates over the array of columns, so we
should reuse the result here.
This commit is contained in:
Dominik Stadler 2026-02-02 18:09:40 +01:00
parent ae3ed57baa
commit 62ae400993
2 changed files with 10 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
poi-ooxml/src/main/java/org/apache/poi/xssf/usermodel/helpers/ColumnHelper.java
View File

@ -38,7 +38,7 @@ import org.openxmlformats.schemas.spreadsheetml.x2006.main.CTWorksheet;
*/
public class ColumnHelper {
private CTWorksheet worksheet;
private final CTWorksheet worksheet;
public ColumnHelper(CTWorksheet worksheet) {
super();
@ -303,10 +303,15 @@ public class ColumnHelper {
col.setStyle(styleId);
}
// Returns -1 if no column is found for the given index
/**
* Get the default style index for the given column index
*
* @return The style-index or -1 if no column is found for the given index
*/
public int getColDefaultStyle(long index) {
if (getColumn(index, false) != null) {
return (int) getColumn(index, false).getStyle();
final CTCol column = getColumn(index, false);
if (column != null) {
return (int) column.getStyle();
}
return -1;
}

3
poi-ooxml/src/test/java/org/apache/poi/xssf/usermodel/helpers/TestColumnHelper.java
View File

@ -252,7 +252,7 @@ public final class TestColumnHelper {
}
/**
* Creates and adds a hidden column and then a best fit column with the given min/max pairs.
* Creates and adds a hidden column and then the best fit column with the given min/max pairs.
* Suitable for testing handling of overlap.
*/
private static CTCols createHiddenAndBestFitColsWithHelper(int hiddenMin, int hiddenMax, int bestFitMin, int bestFitMax) {
@ -404,7 +404,6 @@ public final class TestColumnHelper {
return count;
}
@SuppressWarnings("deprecation")
@Test
void testColumnsCollapsed() throws IOException {
try (XSSFWorkbook wb = new XSSFWorkbook()) {