pashko/apache-poi
1
0
Fork 0
mirror of https://github.com/apache/poi.git synced 2026-02-27 20:40:08 +08:00
Code Issues Packages Projects Releases Wiki Activity

[github-349] tidy up some test assertions. Thanks to XenoAmess. This closes #349

Browse Source 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1902757 13f79535-47bb-0310-9956-ffa450edef68
This commit is contained in:
PJ Fanning 2022-07-15 22:52:45 +00:00
parent 01f14a7548
commit 64d9a97d44
4 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
poi-ooxml/src/test/java/org/apache/poi/xssf/usermodel/charts/TestXSSFLineChartData.java
View File

@ -18,7 +18,7 @@ package org.apache.poi.xssf.usermodel.charts;
import static org.junit.jupiter.api.Assertions.assertEquals; import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.junit.jupiter.api.Assertions.assertNotNull; import static org.junit.jupiter.api.Assertions.assertNotNull;
import static org.junit.jupiter.api.Assertions.assertTrue; import static org.junit.jupiter.api.Assertions.assertSame;
import java.io.IOException; import java.io.IOException;
@ -50,7 +50,7 @@ class TestXSSFLineChartData {
}; };
@Test @Test
void testOneSeriePlot() throws IOException { void testOneSeriesPlot() throws IOException {
XSSFWorkbook wb = new XSSFWorkbook(); XSSFWorkbook wb = new XSSFWorkbook();
XSSFSheet sheet = (XSSFSheet) new SheetBuilder(wb, plotData).build(); XSSFSheet sheet = (XSSFSheet) new SheetBuilder(wb, plotData).build();
XSSFDrawing drawing = sheet.createDrawingPatriarch(); XSSFDrawing drawing = sheet.createDrawingPatriarch();
@ -68,7 +68,7 @@ class TestXSSFLineChartData {
assertNotNull(series); assertNotNull(series);
assertEquals(1, lineChartData.getSeriesCount()); assertEquals(1, lineChartData.getSeriesCount());
assertTrue(lineChartData.getSeries(0) == series); assertSame(series, lineChartData.getSeries(0));
chart.plot(lineChartData); chart.plot(lineChartData);
wb.close(); wb.close();

6
poi-ooxml/src/test/java/org/apache/poi/xssf/usermodel/charts/TestXSSFScatterChartData.java
View File

@ -19,7 +19,7 @@ package org.apache.poi.xssf.usermodel.charts;
import static org.junit.jupiter.api.Assertions.assertEquals; import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.junit.jupiter.api.Assertions.assertNotNull; import static org.junit.jupiter.api.Assertions.assertNotNull;
import static org.junit.jupiter.api.Assertions.assertTrue; import static org.junit.jupiter.api.Assertions.assertSame;
import java.io.IOException; import java.io.IOException;
@ -52,7 +52,7 @@ public final class TestXSSFScatterChartData {
}; };
@Test @Test
void testOneSeriePlot() throws IOException { void testOneSeriesPlot() throws IOException {
XSSFWorkbook wb = new XSSFWorkbook(); XSSFWorkbook wb = new XSSFWorkbook();
XSSFSheet sheet = (XSSFSheet) new SheetBuilder(wb, plotData).build(); XSSFSheet sheet = (XSSFSheet) new SheetBuilder(wb, plotData).build();
XSSFDrawing drawing = sheet.createDrawingPatriarch(); XSSFDrawing drawing = sheet.createDrawingPatriarch();
@ -71,7 +71,7 @@ public final class TestXSSFScatterChartData {
assertEquals(ScatterStyle.LINE_MARKER, scatterChartData.getStyle()); assertEquals(ScatterStyle.LINE_MARKER, scatterChartData.getStyle());
assertNotNull(series); assertNotNull(series);
assertEquals(1, scatterChartData.getSeriesCount()); assertEquals(1, scatterChartData.getSeriesCount());
assertTrue(scatterChartData.getSeries(0) == series); assertSame(series, scatterChartData.getSeries(0));
chart.plot(scatterChartData); chart.plot(scatterChartData);
wb.close(); wb.close();

2
poi-ooxml/src/test/java/org/apache/poi/xwpf/usermodel/TestXWPFComments.java
View File

@ -55,7 +55,7 @@ class TestXWPFComments {
assertNotNull(docIn.getDocComments()); assertNotNull(docIn.getDocComments());
assertEquals(1, docIn.getComments().length); assertEquals(1, docIn.getComments().length);
comment = docIn.getCommentByID("0"); comment = docIn.getCommentByID("0");
assertTrue(null != comment); assertNotNull(comment);
assertEquals("Author", comment.getAuthor()); assertEquals("Author", comment.getAuthor());
} }
} }

2
poi/src/test/java/org/apache/poi/ss/usermodel/BaseTestRangeCopier.java
View File

@ -153,7 +153,7 @@ public abstract class BaseTestRangeCopier {
assertEquals(cellContent, getCellContent(destSheet, "D6")); assertEquals(cellContent, getCellContent(destSheet, "D6"));
assertFalse(destSheet.getMergedRegions().isEmpty()); assertFalse(destSheet.getMergedRegions().isEmpty());
destSheet.getMergedRegions().forEach((mergedRegion) -> { destSheet.getMergedRegions().forEach((mergedRegion) -> {
assertTrue(mergedRegion.equals(mergedRangeAddress)); assertEquals(mergedRangeAddress, mergedRegion);
}); });
} }