diff --git a/src/java/org/apache/poi/hssf/usermodel/HSSFWorkbook.java b/src/java/org/apache/poi/hssf/usermodel/HSSFWorkbook.java index 24999fe203..7cedfecacd 100644 --- a/src/java/org/apache/poi/hssf/usermodel/HSSFWorkbook.java +++ b/src/java/org/apache/poi/hssf/usermodel/HSSFWorkbook.java @@ -1594,8 +1594,6 @@ public final class HSSFWorkbook extends POIDocument implements org.apache.poi.ss // TODO: Some kind of structure. HSSFPictureData picture = new HSSFPictureData(blip); pictures.add(picture); - } else { - pictures.add(null); } diff --git a/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFPictureData.java b/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFPictureData.java index e351e26690..99f4ad8068 100644 --- a/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFPictureData.java +++ b/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFPictureData.java @@ -71,4 +71,16 @@ public final class TestHSSFPictureData extends TestCase{ } } } + + public void testNotNullPictures() throws IOException { + + HSSFWorkbook wb = HSSFTestDataSamples.openSampleWorkbook("SheetWithDrawing.xls"); + + @SuppressWarnings("unchecked") // TODO - add getFormat() to interface PictureData and genericise wb.getAllPictures() + List lst = (List)(List)wb.getAllPictures(); + for(HSSFPictureData pict : lst){ + assertNotNull(pict); + } + } + }