From 8bf71069cdda80a349759edffbabf42d23433017 Mon Sep 17 00:00:00 2001
From: PJ Fanning <fanningpj@apache.org>
Date: Thu, 10 Apr 2025 08:08:22 +0000
Subject: [PATCH] [bug-69646] add tests

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1924986 13f79535-47bb-0310-9956-ffa450edef68
---
 .../poi/xssf/streaming/SheetDataWriter.java       |  2 +-
 .../poi/xssf/streaming/TestSheetDataWriter.java   | 15 +++++++++++++++
 2 files changed, 16 insertions(+), 1 deletion(-)

diff --git a/poi-ooxml/src/main/java/org/apache/poi/xssf/streaming/SheetDataWriter.java b/poi-ooxml/src/main/java/org/apache/poi/xssf/streaming/SheetDataWriter.java
index f0e8d3c05b..70b2b68d04 100644
--- a/poi-ooxml/src/main/java/org/apache/poi/xssf/streaming/SheetDataWriter.java
+++ b/poi-ooxml/src/main/java/org/apache/poi/xssf/streaming/SheetDataWriter.java
@@ -460,7 +460,7 @@ public class SheetDataWriter implements Closeable {
         try {
             _out.close();
         } finally {
-            ret = _fd != null && _fd.delete();
+            ret = _fd == null || _fd.delete();
         }
         return ret;
     }
diff --git a/poi-ooxml/src/test/java/org/apache/poi/xssf/streaming/TestSheetDataWriter.java b/poi-ooxml/src/test/java/org/apache/poi/xssf/streaming/TestSheetDataWriter.java
index a452073f35..239477c352 100644
--- a/poi-ooxml/src/test/java/org/apache/poi/xssf/streaming/TestSheetDataWriter.java
+++ b/poi-ooxml/src/test/java/org/apache/poi/xssf/streaming/TestSheetDataWriter.java
@@ -26,6 +26,7 @@ import static org.junit.jupiter.api.Assertions.assertTrue;
 import java.io.File;
 import java.io.FileInputStream;
 import java.io.IOException;
+import java.io.StringWriter;
 import java.nio.charset.StandardCharsets;
 
 import org.apache.poi.util.IOUtils;
@@ -69,6 +70,7 @@ public final class TestSheetDataWriter {
             IOUtils.closeQuietly(writer);
         }
     }
+
     @Test
     void testWriteNewLines() throws IOException {
         SheetDataWriter writer = new SheetDataWriter();
@@ -84,4 +86,17 @@ public final class TestSheetDataWriter {
             IOUtils.closeQuietly(writer);
         }
     }
+
+    @Test
+    void testDispose() throws IOException {
+        SheetDataWriter writer = new SheetDataWriter();
+        assertTrue(writer.dispose());
+    }
+
+    @Test
+    void testWriterDispose() throws IOException {
+        StringWriter sw = new StringWriter();
+        SheetDataWriter writer = new SheetDataWriter(sw);
+        assertTrue(writer.dispose());
+    }
 }