pashko/apache-poi
1
0
Fork 0
mirror of https://github.com/apache/poi.git synced 2026-02-27 20:40:08 +08:00
Code Issues Packages Projects Releases Wiki Activity

Don't fail on JDK 21.0.1 if one signature check fails

Browse Source 
See https://bugs.openjdk.org/browse/JDK-8320597 for the
related bug-report for the JDK itself

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1914986 13f79535-47bb-0310-9956-ffa450edef68
This commit is contained in:
Dominik Stadler 2023-12-30 11:11:21 +00:00
parent fb3f3ef26f
commit a9ca01e3fd
1 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
poi-ooxml/src/test/java/org/apache/poi/poifs/crypt/dsig/TestSignatureInfo.java
View File

@ -253,9 +253,15 @@ class TestSignatureInfo {
si.setSignatureConfig(sic); si.setSignatureConfig(sic);
boolean isValid = si.verifySignature(); boolean isValid = si.verifySignature();
// We reported https://bugs.openjdk.org/browse/JDK-8320597 because of this, it will be fixed in JDK 22
// and maybe in newer JDK 21 patch-levels
assumeTrue(isValid && !"21.0.1".equals(System.getProperty("java.version")),
"This fails on JDK 21.0.1, see https://bugs.openjdk.org/browse/JDK-8320597");
assertTrue(isValid, assertTrue(isValid,
// add some details to find out why "verifySignature()" returns false sometimes // add some details to find out why "verifySignature()" returns false sometimes
"Verifying signature failed, hasNext: " + si.getSignatureParts().iterator().hasNext() + ": " + "Failed for " + System.getProperty("java.version") +
": Verifying signature failed, hasNext: " + si.getSignatureParts().iterator().hasNext() + ": " +
(si.getSignatureParts().iterator().hasNext() ? si.getSignatureParts().iterator() : "")); (si.getSignatureParts().iterator().hasNext() ? si.getSignatureParts().iterator() : ""));
} }
} }