pashko/apache-poi
1
0
Fork 0
mirror of https://github.com/apache/poi.git synced 2026-02-27 20:40:08 +08:00
Code Issues Packages Projects Releases Wiki Activity

windows test issue

Browse Source
This commit is contained in:
PJ Fanning 2025-08-03 13:54:30 +01:00
parent 224201e1a2
commit ae232b73d7
1 changed files with 8 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
poi/src/test/java/org/apache/poi/util/TestIOUtils.java
View File

@ -594,7 +594,7 @@ final class TestIOUtils {
final File parent = TempFile.createTempDirectory("path-traversal-test");
try {
// this path is ok because it doesn't walk out of the parent directory
final String path0 = "a/b/c/../d/e/../../f/g/./h";
final String path0 = windowsPathIfNecessary("a/b/c/../d/e/../../f/g/./h");
File outFile = IOUtils.newFile(parent, path0);
assertTrue(outFile.getAbsolutePath().endsWith(path0),
"unexpected path: " + outFile.getAbsolutePath());
@ -609,7 +609,7 @@ final class TestIOUtils {
try {
// this path is ok because it doesn't walk out of the parent directory
// the initial slash is ignored and the generated path is relative to the parent directory
final String path0 = "/a/b/c.txt";
final String path0 = windowsPathIfNecessary("/a/b/c.txt");
File outFile = IOUtils.newFile(parent, path0);
assertTrue(outFile.getAbsolutePath().endsWith(path0),
"unexpected path: " + outFile.getAbsolutePath());
@ -622,13 +622,18 @@ final class TestIOUtils {
void testDisallowedPathTraversal() throws IOException {
final File parent = TempFile.createTempDirectory("path-traversal-test");
try {
final String path0 = "../a/b/c.txt";
final String path0 = windowsPathIfNecessary("../a/b/c.txt");
Assertions.assertThrows(IOException.class, () -> IOUtils.newFile(parent, path0));
} finally {
assertTrue(parent.delete());
}
}
private static String windowsPathIfNecessary(String path) {
// this is a workaround for the Windows file system which doesn't allow slashes in file names
return File.pathSeparatorChar == '/' ? path : path.replace('/', File.pathSeparatorChar);
}
/**
* This returns 0 for the first call to skip and then reads
* as requested. This tests that the fallback to read() works.