pashko/apache-poi
1
0
Fork 0
mirror of https://github.com/apache/poi.git synced 2026-02-27 20:40:08 +08:00
Code Issues Packages Projects Releases Wiki Activity

Remove unused list of pivot-caches and update deprecations

Browse Source 
Seems the list is currently never accessed any more.
This commit is contained in:
Dominik Stadler 2025-12-02 22:17:35 +01:00 committed by PJ Fanning
parent b5b61eab6e
commit c019bccce1
1 changed files with 19 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

28
poi-ooxml/src/main/java/org/apache/poi/xssf/usermodel/XSSFWorkbook.java
View File

@ -209,7 +209,6 @@ public class XSSFWorkbook extends POIXMLDocument implements Workbook, Date1904Su
* List of all pivot tables in workbook
*/
private final List<XSSFPivotTable> pivotTables = new ArrayList<>();
private List<CTPivotCache> pivotCaches;
private final XSSFFactory xssfFactory;
@ -387,9 +386,6 @@ public class XSSFWorkbook extends POIXMLDocument implements Workbook, Date1904Su
if (getCorePart().getContentType().equals(XSSFRelation.XLSB_BINARY_WORKBOOK.getContentType())) {
throw new XLSBUnsupportedException();
}
// Create arrays for parts attached to the workbook itself
pivotCaches = new ArrayList<>();
}
@Override
@ -1115,6 +1111,9 @@ public class XSSFWorkbook extends POIXMLDocument implements Workbook, Date1904Su
*
* @param nameIndex the index of the named range
* @return the XSSFName at the given index
*
* @deprecated 3.16. New projects should avoid accessing named ranges by index.
* Use {@link #getName(String)} instead.
*/
@Deprecated
XSSFName getNameAt(int nameIndex) {
@ -2095,7 +2094,22 @@ public class XSSFWorkbook extends POIXMLDocument implements Workbook, Date1904Su
return externalLinks;
}
@Deprecated // use getExternalLinksTables() instead
/**
* Returns the list of {@link ExternalLinksTable} object for this workbook
*
* <p>The external links table specifies details of named ranges etc
* that are referenced from other workbooks, along with the last seen
* values of what they point to.</p>
*
* <p>Note that Excel uses index 0 for the current workbook, so the first
* External Links in a formula would be '[1]Foo' which corresponds to
* entry 0 in this list.</p>
* @return the {@code ExternalLinksTable} list, which may be empty
*
* @deprecated use getExternalLinksTables() instead
*/
@Deprecated
@Removal(version = "7.0.0")
@Internal
public List<ExternalLinksTable> getExternalLinksTable() {
@ -2433,10 +2447,6 @@ public class XSSFWorkbook extends POIXMLDocument implements Workbook, Date1904Su
final int tableId = pivotTables.size() + 1;
cache.setCacheId(tableId);
cache.setId(rId);
if(pivotCaches == null) {
pivotCaches = new ArrayList<>();
}
pivotCaches.add(cache);
return cache;
}