From d8b393464698ee3b4f04f7e8f522984575b91d17 Mon Sep 17 00:00:00 2001 From: PJ Fanning Date: Sun, 15 Jun 2025 14:22:41 +0000 Subject: [PATCH] [bug-69715] update tests git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1926446 13f79535-47bb-0310-9956-ffa450edef68 --- .../util/DefaultTempFileCreationStrategyTest.java | 15 +++++++++++++-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/poi/src/test/java/org/apache/poi/util/DefaultTempFileCreationStrategyTest.java b/poi/src/test/java/org/apache/poi/util/DefaultTempFileCreationStrategyTest.java index a588f2fb77..acbf7e5ece 100644 --- a/poi/src/test/java/org/apache/poi/util/DefaultTempFileCreationStrategyTest.java +++ b/poi/src/test/java/org/apache/poi/util/DefaultTempFileCreationStrategyTest.java @@ -27,6 +27,7 @@ import static org.junit.jupiter.api.Assertions.assertTrue; import java.io.File; import java.io.IOException; import java.nio.file.Files; +import java.nio.file.Path; import org.apache.commons.io.FileUtils; import org.junit.jupiter.api.AfterEach; @@ -69,7 +70,7 @@ class DefaultTempFileCreationStrategyTest { try { assertTrue(Files.isDirectory(dir.toPath()), "File is not a directory: " + dir); DefaultTempFileCreationStrategy testStrategy = new DefaultTempFileCreationStrategy(dir); - checkGetFile(testStrategy); + checkGetFileAndPath(testStrategy, dir.toPath()); } finally { // Clean up the directory after the test FileUtils.deleteDirectory(dir); @@ -84,7 +85,7 @@ class DefaultTempFileCreationStrategyTest { assertTrue(dir.delete(), "directory not deleted: " + dir); try { DefaultTempFileCreationStrategy testStrategy = new DefaultTempFileCreationStrategy(dir); - checkGetFile(testStrategy); + checkGetFileAndPath(testStrategy, dir.toPath()); } finally { // Clean up the directory after the test FileUtils.deleteDirectory(dir); @@ -104,8 +105,18 @@ class DefaultTempFileCreationStrategyTest { } private static void checkGetFile(DefaultTempFileCreationStrategy strategy) throws IOException { + checkGetFileAndPath(strategy, null); + } + + private static void checkGetFileAndPath(DefaultTempFileCreationStrategy strategy, + Path path) throws IOException { File file = strategy.createTempFile("POITest", ".tmp"); try { + if (path != null) { + assertTrue(file.toPath().startsWith(path), + "File path does not start with expected path: " + path); + } + assertTrue(file.getParentFile().exists(), "Failed for " + file.getParentFile());