1161 Commits

Author SHA1 Message Date
PJ Fanning
f1e6b9d11c
remove deprecated method getSeries (#864)
* remove deprecated method getSeries

* Update TestXDDFChartRemoveSeries.java
2025-07-25 13:08:29 +01:00
Jacobo Aragunde Pérez
ebad7593ff
Return unmodifiable lists from XWPFRun charts and pictures. (#862)
The operations XWPFRun.getEmbedded[Pictures|Charts]().add() are not
supported. Users must call XWPFRun.add[Picture|Chart]() instead.

This change will make the fact more explicit, with an error when they
attempt to use the wrong operation.
2025-07-25 08:48:05 +01:00
PJ Fanning
5642c122f3
eager XWPF doc eval (#860)
we've seen evidence in deeply nested docs that it can cause recursion issues when this is lazily evaluated
2025-07-24 21:12:33 +01:00
Jacobo Aragunde Pérez
a96c0d9d78
Implement XWPFRun.getEmbeddedCharts(). (#859)
Returns a list of XWPFChart objects embedded in the run.

Works in a similar way to getEmbeddedPictures(), maintaining a list of
XWPFChart objects. They are retrieved from the XWPFDocument object
through their relation id.
2025-07-24 20:21:37 +01:00
Jacobo Aragunde Pérez
0b9bc5d0b4
Add getters for CTSdt(Content)Cell objects. (#854)
* Add getters for CTSdt(Content)Cell objects.

Currently the XWPFSdt(Content)Cell object just produces a text
equivalent of the content. There is no way to access the inner XML node
for further inspection; instead, one needs to go to the parent object
and iterate over its XML children.

This would allow users to use the XWPFRow.getICells() to obtain
XWPFTableCell or XWPFSDTCell objects, and then access the latter's inner
XML node to get access to its full data.

We also defer the parsing of the text in XWPFContentCell until the
getter is called. A user who will work with the inner XML is unlikely to
need the text parsing done.

* Add javadoc and @since annotation.
2025-07-23 21:33:47 +01:00
PJ Fanning
e5b2fbb89b
add depth check (#858)
* add depth check

* Update XWPFTableCell.java

* Update XWPFTableCell.java

* Update XWPFTableCell.java

* Update XWPFTableCell.java
2025-07-23 20:27:40 +01:00
PJ Fanning
7c86c60f7c Revert "avoid unsafe cast to int"
This reverts commit 44da0ea183b87fd8514048ecd510ea57fd3f2b08.
2025-07-23 17:19:45 +01:00
PJ Fanning
44da0ea183 avoid unsafe cast to int 2025-07-23 17:03:24 +01:00
PJ Fanning
f73a9e0875 reformat 2025-07-23 16:55:41 +01:00
Jacobo Aragunde Pérez
cceccc4bae
Support all possible alignment values for docx tables. (#848)
Besides the start/center/end values specified in the OOXML standard,
Word also uses "left" and "right" as values. We need to support this
to prevent POI code from crashing with such documents.

Fixes: https://bz.apache.org/bugzilla/show_bug.cgi?id=69744
2025-07-17 12:11:46 +01:00
PJ Fanning
f3bf31ac5d avoid creating CTUnderline 2025-07-15 14:08:42 +01:00
Jacobo Aragunde Pérez
73b2874824
Add getters and setters for XWPFTable indentation. (#843)
* Add getters and setters for XWPFTable indentation.

The element tblPr->tblInd represents "table indent from leading margin".
It specifies the indentation which shall be added before the leading
edge of the current table in the document (the left edge in a
left-to-right table, and the right edge in a right-to-left table). This
indentation should shift the table into the text margin by the specified
amount.

This value is specified in the units applied via its type attribute. Any
width value of type pct or auto for this element shall be ignored.

If this element is omitted, then the table shall inherit the table
indentation from the associated table style. If table indentation is
never specified in the style hierarchy, no indentation shall be added to
the parent table. If the resulting justification on any table row is not
left, then this property shall be ignored.

To implement this property, we included a getter and a setter for the
property value, and another couple of getter/setter for the existence
(and validity) or absence of the property itself, for clients to know
they must fall back to the table style.

* Address reviewer comments.
2025-07-15 10:05:17 +01:00
PJ Fanning
d4fc5cd6c0 avoid creating CTTblPr if not needed 2025-07-14 17:05:45 +01:00
PJ Fanning
4166350488
try to remove batik-script build hack (#839)
* try to remove batik-script build hack

* Update build.gradle

* Update build.gradle
2025-07-11 13:05:52 +01:00
Jacobo Aragunde Pérez
6d8f1901dc
Allow null values in XWPFParagraph.get/setAlignment(). (#829)
* Allow null values in XWPFParagraph.get/setAlignment().

A null value in this field would indicate that the paragraph should
follow the alignment provided by the style hierarchy.

Fixes: https://bz.apache.org/bugzilla/show_bug.cgi?id=69720

* Revert getAlignment() and implement isAlignmentSet() instead.

* Replace test case file.

* Implement XWPFParagraph.getTCPPr(create).

It lets the caller choose if a new PPr should be created in case it
doesn't exist.

* use getCTPPr(boolean)

* compile issue

---------

Co-authored-by: PJ Fanning <pjfanning@users.noreply.github.com>
2025-07-09 20:00:14 +01:00
PJ Fanning
b5f67fca04
bug-69727 decrease count when we remove merged regions (#837)
* bug-69727 decrease count when we remove merged regions

* extend test

* fix tests
2025-07-08 23:21:35 +01:00
Vengador
bbd404f343
Bugfix setBulletStyle in XSLFTextParagraph (#770)
* Bugfix setBulletStyle in XSLFTextParagraph

Having a 0 here throws IllegalArgumentException, the method setBulletAutoNumber requires 1 as minimun as argument

* tests added for setBulletStyle fix
2025-07-08 16:42:19 +01:00
PJ Fanning
2f66c63387 git repo 2025-07-07 23:07:39 +01:00
PJ Fanning
67320b6453 xmlunit 2.10.3
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1926704 13f79535-47bb-0310-9956-ffa450edef68
2025-06-24 15:14:27 +00:00
PJ Fanning
9e7873267a bouncycastle 1.81
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1926118 13f79535-47bb-0310-9956-ffa450edef68
2025-06-04 14:22:26 +00:00
PJ Fanning
17cb74b3ff [bug-66687] Combination of XSSF and SXSSF may result in invalid files. Thanks to Martin Schloemer. This closes #814
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1925881 13f79535-47bb-0310-9956-ffa450edef68
2025-05-27 21:52:20 +00:00
PJ Fanning
6f1a81ac8c upgrade deps
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1925765 13f79535-47bb-0310-9956-ffa450edef68
2025-05-23 14:40:37 +00:00
PJ Fanning
2880483f13 upgrade guava and xmlunit
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1925698 13f79535-47bb-0310-9956-ffa450edef68
2025-05-19 16:00:09 +00:00
PJ Fanning
b461e98edb code refactor
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1925650 13f79535-47bb-0310-9956-ffa450edef68
2025-05-17 17:00:58 +00:00
PJ Fanning
f298390ec3 code refactor
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1925649 13f79535-47bb-0310-9956-ffa450edef68
2025-05-17 16:46:23 +00:00
PJ Fanning
b76bbc866e code refactor
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1925646 13f79535-47bb-0310-9956-ffa450edef68
2025-05-17 15:57:29 +00:00
PJ Fanning
62b351cbeb bring together CTRunTrackChange code
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1925611 13f79535-47bb-0310-9956-ffa450edef68
2025-05-17 09:57:02 +00:00
PJ Fanning
e17ddb0374 bring together CTRunTrackChange code
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1925610 13f79535-47bb-0310-9956-ffa450edef68
2025-05-17 09:52:20 +00:00
PJ Fanning
40beab6b6c revert change
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1925576 13f79535-47bb-0310-9956-ffa450edef68
2025-05-16 08:57:02 +00:00
PJ Fanning
51316e01d8 saxon 12.7
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1925575 13f79535-47bb-0310-9956-ffa450edef68
2025-05-16 08:55:40 +00:00
PJ Fanning
1b0f62a235 add tests for cell style cloning
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1925551 13f79535-47bb-0310-9956-ffa450edef68
2025-05-14 16:49:33 +00:00
PJ Fanning
2f55495ba9 try best effort clone of styles if types don't match
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1925524 13f79535-47bb-0310-9956-ffa450edef68
2025-05-12 22:27:42 +00:00
PJ Fanning
dce1a83169 extend test
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1925505 13f79535-47bb-0310-9956-ffa450edef68
2025-05-11 16:02:06 +00:00
PJ Fanning
ebd9a8bc9a extend test
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1925503 13f79535-47bb-0310-9956-ffa450edef68
2025-05-11 14:11:28 +00:00
PJ Fanning
3f9153c761 try to avoid class cast issues
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1925502 13f79535-47bb-0310-9956-ffa450edef68
2025-05-11 13:45:31 +00:00
PJ Fanning
85212023d6 try to avoid class cast issues
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1925500 13f79535-47bb-0310-9956-ffa450edef68
2025-05-11 13:26:06 +00:00
PJ Fanning
39935860ed support colors as byte[]
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1925499 13f79535-47bb-0310-9956-ffa450edef68
2025-05-11 11:08:13 +00:00
PJ Fanning
bbccb5217f refactor
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1925498 13f79535-47bb-0310-9956-ffa450edef68
2025-05-11 10:57:06 +00:00
PJ Fanning
1f6c32bd55 refactor font test
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1925497 13f79535-47bb-0310-9956-ffa450edef68
2025-05-11 10:55:31 +00:00
PJ Fanning
1b0632f3f1 support colors as byte[]
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1925496 13f79535-47bb-0310-9956-ffa450edef68
2025-05-11 10:20:27 +00:00
PJ Fanning
783ebda7f3 reformat
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1925495 13f79535-47bb-0310-9956-ffa450edef68
2025-05-11 09:56:45 +00:00
PJ Fanning
a56b68476f batik 1.19
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1925441 13f79535-47bb-0310-9956-ffa450edef68
2025-05-06 20:16:55 +00:00
PJ Fanning
e867e371be typos (an)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1925440 13f79535-47bb-0310-9956-ffa450edef68
2025-05-06 20:12:35 +00:00
PJ Fanning
eb89c043dc batik 1.19
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1925439 13f79535-47bb-0310-9956-ffa450edef68
2025-05-06 20:01:53 +00:00
Dominik Stadler
7aa4ae3bc1 Bug 69667: Test more variants of valid and invalid usernames
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1925429 13f79535-47bb-0310-9956-ffa450edef68
2025-05-06 06:04:44 +00:00
PJ Fanning
694538aed0 commons-collections 4.5.0
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1925238 13f79535-47bb-0310-9956-ffa450edef68
2025-04-23 19:44:41 +00:00
Dominik Stadler
0036655df4 ForbiddenApis: Adjust for deprecations in JDK 21+
Fix failures reported when raising the language level to 23
new URL() is deprecated
new Locale() is deprecated
still allow ThreadDeath and Thread.getId() for now to keep support for JDK 8

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1925199 13f79535-47bb-0310-9956-ffa450edef68
2025-04-21 12:07:21 +00:00
Dominik Stadler
db61f5b4be Avoid race-condition with sample-file being changed/empty
Also improve output EmptyfileException

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1925190 13f79535-47bb-0310-9956-ffa450edef68
2025-04-21 08:51:13 +00:00
PJ Fanning
993cc5a5b8 use isEmpty
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1925003 13f79535-47bb-0310-9956-ffa450edef68
2025-04-10 19:02:59 +00:00
PJ Fanning
92d4a8d86d use isEmpty
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1925002 13f79535-47bb-0310-9956-ffa450edef68
2025-04-10 18:48:01 +00:00