Dominik Stadler
0cbe6c7d1d
Revert set of inadvertedly committed files/changes
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737029 13f79535-47bb-0310-9956-ffa450edef68
2016-03-29 18:11:44 +00:00
Dominik Stadler
349b14f837
Bug 58915: Add note about memory consumption and update changelog
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737025 13f79535-47bb-0310-9956-ffa450edef68
2016-03-29 17:30:55 +00:00
Dominik Stadler
c23c89a3da
Bug 59132: Adjust implementation of COUNTBLANK to be conforming to Excel, empty strings are counted as blank as well
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737009 13f79535-47bb-0310-9956-ffa450edef68
2016-03-29 14:53:44 +00:00
Andreas Beeker
033580e1b3
sonar fixes
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1736932 13f79535-47bb-0310-9956-ffa450edef68
2016-03-28 22:46:53 +00:00
Dominik Stadler
155323ee56
Fix some compiler warnings, javadoc, ...
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1736924 13f79535-47bb-0310-9956-ffa450edef68
2016-03-28 20:22:08 +00:00
Javen O'Neal
da9bd80d5e
bug 59212: Do not check for overlapping regions when adding merged regions to a sheet
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1736155 13f79535-47bb-0310-9956-ffa450edef68
2016-03-22 09:02:08 +00:00
Dominik Stadler
15d70b0828
Check for null in IOUtils.closeQuietly() to not log this unnecessarily
...
Add coverage for some more methods in ExtractorFactory
Fix some IntelliJ warnings
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1736146 13f79535-47bb-0310-9956-ffa450edef68
2016-03-22 07:51:39 +00:00
Andreas Beeker
8b1b768114
findbugs fixes - SE_COMPARATOR_SHOULD_BE_SERIALIZABLE
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1736114 13f79535-47bb-0310-9956-ffa450edef68
2016-03-21 23:42:56 +00:00
Andreas Beeker
3dfbdc46e5
findbugs fixes - RR_NOT_CHECKED
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1736112 13f79535-47bb-0310-9956-ffa450edef68
2016-03-21 23:29:06 +00:00
Andreas Beeker
fe653de0e6
fix eclipse warnings
...
close resources
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735912 13f79535-47bb-0310-9956-ffa450edef68
2016-03-21 00:14:21 +00:00
Andreas Beeker
86fdea9d4b
sonar fix
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735696 13f79535-47bb-0310-9956-ffa450edef68
2016-03-18 22:21:12 +00:00
Andreas Beeker
9fe1cea901
sonar fix
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735514 13f79535-47bb-0310-9956-ffa450edef68
2016-03-17 22:39:20 +00:00
Andreas Beeker
93122ff358
findbugs fix
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735513 13f79535-47bb-0310-9956-ffa450edef68
2016-03-17 22:36:11 +00:00
Andreas Beeker
defe39208c
sonar fix
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735507 13f79535-47bb-0310-9956-ffa450edef68
2016-03-17 21:52:53 +00:00
Andreas Beeker
fc83bdaf9e
forgot another contains call ...
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735349 13f79535-47bb-0310-9956-ffa450edef68
2016-03-16 23:40:00 +00:00
Andreas Beeker
ee4b65394f
findbugs fix
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735348 13f79535-47bb-0310-9956-ffa450edef68
2016-03-16 23:36:17 +00:00
Andreas Beeker
217ae0ea8f
sonar fixes
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735345 13f79535-47bb-0310-9956-ffa450edef68
2016-03-16 23:30:19 +00:00
Andreas Beeker
5499c36019
findbugs fixes
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735319 13f79535-47bb-0310-9956-ffa450edef68
2016-03-16 22:10:27 +00:00
Andreas Beeker
6841ce8d55
First try of uncluttering CellNumberFormatter.
...
Make inner classes static and remove setting of private outer properties while in constructor.
Make properties final to make sure they are only set once.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735300 13f79535-47bb-0310-9956-ffa450edef68
2016-03-16 21:18:58 +00:00
Nick Burch
2115a45b05
Start to give more helpful Exceptions from OPCPackage when non-OOXML files are passed to it
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735060 13f79535-47bb-0310-9956-ffa450edef68
2016-03-15 11:50:57 +00:00
Dominik Stadler
51a1ebf750
Fix some IntelliJ warnings and adjust Javadoc of readFully() slightly to describe the behavior better.
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734924 13f79535-47bb-0310-9956-ffa450edef68
2016-03-14 11:58:15 +00:00
Andreas Beeker
fef2ce53cd
HSLF: Add support for system colors
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734865 13f79535-47bb-0310-9956-ffa450edef68
2016-03-14 00:42:59 +00:00
Dominik Stadler
8fccd72f9d
Bug 56930: Add Workbook.getNames() to allow to query for names that appear multiple times
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734863 13f79535-47bb-0310-9956-ffa450edef68
2016-03-13 21:30:38 +00:00
Dominik Stadler
2776cf6a59
Bug 55668: Try to avoid NullPointerException when chaning cell type and formula leads to null-string by seting the cell to BLANK instead
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734861 13f79535-47bb-0310-9956-ffa450edef68
2016-03-13 21:30:18 +00:00
Nick Burch
61a7e000fe
Escape spaces in the URL
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734858 13f79535-47bb-0310-9956-ffa450edef68
2016-03-13 21:19:46 +00:00
Andreas Beeker
3b7bbadb5d
#59135 - Password gets truncated when using passwords longer than 15 characters for the function protectSheet()
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734843 13f79535-47bb-0310-9956-ffa450edef68
2016-03-13 19:31:32 +00:00
Dominik Stadler
2f0d7183db
Bug 57200: Do not try to delete the poifiles-tempdir as it can interfere when multiple applications are using SXSSF on the same machine.
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734719 13f79535-47bb-0310-9956-ffa450edef68
2016-03-12 16:56:33 +00:00
Andreas Beeker
5f71c5241c
#59170 - Remove deprecated classes (POI 3.15) - *Workbook.setRepeatingRowsAndColumns()
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734701 13f79535-47bb-0310-9956-ffa450edef68
2016-03-12 13:33:53 +00:00
Dominik Stadler
14e3827e8c
Apply patch to fix bug 57495: getTableArray method can not get 0 pos table
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734694 13f79535-47bb-0310-9956-ffa450edef68
2016-03-12 11:45:34 +00:00
Dominik Stadler
71f5735238
Refactor some common code from the various Document-Factories into a helper class
...
Fix a potential file-handle-leak for password protected workbooks or slideshows
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734691 13f79535-47bb-0310-9956-ffa450edef68
2016-03-12 11:37:32 +00:00
Dominik Stadler
6d92ee86ff
Findbugs fixes
...
OldExcelExtractor could leak file handles in case of exceptions
Free file handles in POIFSDump, add unit-test for POIFSDump
Add a Findbugs exclude and adjust findbugs-ant slightly
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734689 13f79535-47bb-0310-9956-ffa450edef68
2016-03-12 11:37:12 +00:00
Dominik Stadler
eab3e748b3
Mark duplicated RecordFormatException as deprecated to be able to remove it at some point in the future
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734688 13f79535-47bb-0310-9956-ffa450edef68
2016-03-12 11:36:56 +00:00
Andreas Beeker
a061c85a3a
#59170 - Remove deprecated classes (POI 3.15) - org.apache.poi.hssf/ss.util.Region
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734651 13f79535-47bb-0310-9956-ffa450edef68
2016-03-12 00:17:16 +00:00
Andreas Beeker
24e7f1e8fb
sonar fixes
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734641 13f79535-47bb-0310-9956-ffa450edef68
2016-03-11 23:14:09 +00:00
Andreas Beeker
1cfd253a25
sonar fixes
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734337 13f79535-47bb-0310-9956-ffa450edef68
2016-03-10 00:20:34 +00:00
Andreas Beeker
e4c0ee1fa0
Remove a superfluous/bloated log function, which String.format can do better and is only used once ...
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734310 13f79535-47bb-0310-9956-ffa450edef68
2016-03-09 20:57:26 +00:00
Nick Burch
a20e6a38d3
More helpful exception message if POIFS is given a raw XML file (eg an Office 2003 XML file), plus tests
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734215 13f79535-47bb-0310-9956-ffa450edef68
2016-03-09 10:57:52 +00:00
Andreas Beeker
0423fae3b7
#59056 - Render individual slideshow shapes
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1732974 13f79535-47bb-0310-9956-ffa450edef68
2016-02-29 23:59:49 +00:00
Andreas Beeker
64e855f4ca
Fix NPE of regression tests
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1732972 13f79535-47bb-0310-9956-ffa450edef68
2016-02-29 23:36:58 +00:00
Nick Burch
6e21b85d8e
#59074 More helpful exception if Excel 1-95 files are given to ExtractorFactory
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1732587 13f79535-47bb-0310-9956-ffa450edef68
2016-02-26 23:56:31 +00:00
Nick Burch
05d455310c
Refactor out the POIFS directory entry name for Excel 1-95 entries, and have ExtractorFactory detect (but not support) these old files
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1732583 13f79535-47bb-0310-9956-ffa450edef68
2016-02-26 23:43:59 +00:00
Nick Burch
7fdd90fecb
Refactor to pull out the list of Excel 97+ directory entry names to a common place, avoiding duplication. Also starts on unit testing #59074
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1732579 13f79535-47bb-0310-9956-ffa450edef68
2016-02-26 23:32:17 +00:00
Andreas Beeker
c6fa344c54
Regression fixes for H/XSLF and HWMF
...
see http://apache-poi.1045710.n5.nabble.com/3-14-beta-2-3-14-final-tt5721829.html
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1732236 13f79535-47bb-0310-9956-ffa450edef68
2016-02-24 22:43:51 +00:00
Dominik Stadler
784bdfe20f
Bug 47245: Comment out check and exception in case row-records are missing for some cells as it seems POI is handling this gracefully and LibreOffice/Excel are as well
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1732235 13f79535-47bb-0310-9956-ffa450edef68
2016-02-24 22:39:11 +00:00
Dominik Stadler
e89cb5544d
Include stacktrace of inner exception when block-positions are invalid in POIFSFileSystem
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1731560 13f79535-47bb-0310-9956-ffa450edef68
2016-02-21 20:41:56 +00:00
Javen O'Neal
9ee05a1452
bug 56345: reject single-cell merged regions
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1730991 13f79535-47bb-0310-9956-ffa450edef68
2016-02-18 01:33:14 +00:00
Javen O'Neal
b6a21ab3aa
bug 58339: patch from Patrick Zimmermann to allow OFFSET() to accept missing optional width or height parameters
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1730606 13f79535-47bb-0310-9956-ffa450edef68
2016-02-15 20:27:59 +00:00
Nick Burch
8c203f1366
Add details of the ignored errors where the HSSF spec provides a good description, and a bit more refactoring. #56892
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1730543 13f79535-47bb-0310-9956-ffa450edef68
2016-02-15 14:58:16 +00:00
Nick Burch
3b5586ea79
Start generalising the IgnoredErrorType code for later HSSF use too #56892
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1730540 13f79535-47bb-0310-9956-ffa450edef68
2016-02-15 14:40:24 +00:00
Dominik Stadler
e156c3d691
Seems we need a cast here to compile with some newer JDKs, at least IntelliJ complains for me
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1730464 13f79535-47bb-0310-9956-ffa450edef68
2016-02-15 08:33:12 +00:00