Dominik Stadler
0e69c64a62
Add some more variants of HTML with preceding newline which we see frequently
...
in the large regression test corpus
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1856689 13f79535-47bb-0310-9956-ffa450edef68
2019-03-31 19:29:42 +00:00
Dominik Stadler
097fd7a5e2
Close more file-handles in tests, convert junit3 tests
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1856688 13f79535-47bb-0310-9956-ffa450edef68
2019-03-31 19:29:34 +00:00
PJ Fanning
9576ab77f9
replace version number 4.0.2
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1856665 13f79535-47bb-0310-9956-ffa450edef68
2019-03-31 08:54:44 +00:00
Greg Woolsey
48ac6b4d02
fix a condition not seen until a recent expansion of the stress test. Gracefully ignore missing/invalid external sheet references in one more path (there were several already with comments like "this seems to be what Excel does in this case")
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1856655 13f79535-47bb-0310-9956-ffa450edef68
2019-03-31 03:49:16 +00:00
PJ Fanning
5d580f48e6
fix build issue
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1856649 13f79535-47bb-0310-9956-ffa450edef68
2019-03-30 21:57:50 +00:00
Greg Woolsey
67aad69757
#63292 1904 date windowing flag not used for some format cases
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1856648 13f79535-47bb-0310-9956-ffa450edef68
2019-03-30 20:13:24 +00:00
Greg Woolsey
0d22749477
#63291 CellFormat global cache isn't thread-safe
...
move date format synchronization down to where the problem instance is held.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1856647 13f79535-47bb-0310-9956-ffa450edef68
2019-03-30 19:33:02 +00:00
Greg Woolsey
30851e44a6
#63302 Formula evaluation of names with offset or row function is incorrect
...
thanks to John Lincoln White for the patch, including new unit tests.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1856644 13f79535-47bb-0310-9956-ffa450edef68
2019-03-30 18:14:14 +00:00
PJ Fanning
2a9390d683
[bug-63291] support concurrent date formatting with same DataFormatter
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1856449 13f79535-47bb-0310-9956-ffa450edef68
2019-03-27 23:04:40 +00:00
PJ Fanning
895b251367
some javadoc issues
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1855954 13f79535-47bb-0310-9956-ffa450edef68
2019-03-20 23:33:50 +00:00
Dominik Stadler
40f8d119c7
Remove more remnants of NPOIFSFileSystem, mostly in comments and variable names
...
This avoids confusion if people look at this code in the future without knowledge
about the historical transition from java.io to java.nio
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1855873 13f79535-47bb-0310-9956-ffa450edef68
2019-03-19 21:55:26 +00:00
PJ Fanning
f2d9c1a927
[bug-63268] fix issue where CellUtil.setFont is adding unnecessary styles
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1855806 13f79535-47bb-0310-9956-ffa450edef68
2019-03-19 05:59:00 +00:00
Greg Woolsey
82f9c29258
#60724 - Partial implementation for SUBTOTAL() 'ignore hidden rows' variations
...
The function still doesn't deal with auto-filtering, but it now handles variations that should skip hidden rows.
Taught the evaluation framework to know about hidden rows similar to what was already there for skipping subtotals within subtotal ranges.
Added unit test cases.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1855789 13f79535-47bb-0310-9956-ffa450edef68
2019-03-18 19:09:11 +00:00
Andreas Beeker
19005a4e63
Fix forbidden apis error
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1855672 13f79535-47bb-0310-9956-ffa450edef68
2019-03-16 20:44:12 +00:00
Yegor Kozlov
6ef332b48e
Bug 61472: Convert date/time strings to numbers when evaluating formulas
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1855662 13f79535-47bb-0310-9956-ffa450edef68
2019-03-16 15:41:46 +00:00
Greg Woolsey
ee83ce5fcd
Handle possible invalid date value ( #61652 )
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1855627 13f79535-47bb-0310-9956-ffa450edef68
2019-03-16 06:55:16 +00:00
Greg Woolsey
8225326b56
#63264 Conditional Format rule evaluation calculates relative references incorrectly
...
Fixing the offset calculation and passing the top-left-most region rather than the region matching the current cell fixed these cases. I've augmented unit tests to check for them to avoid future regressions.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1855619 13f79535-47bb-0310-9956-ffa450edef68
2019-03-16 00:27:13 +00:00
PJ Fanning
126606c838
fix some cases where iterator usage does not check hasNext
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1855480 13f79535-47bb-0310-9956-ffa450edef68
2019-03-14 04:01:10 +00:00
Dominik Stadler
a9b2a8b2bd
Bug 63200: Avoid NullPointerException in XSLFShape.selectPaint() and check some more in integration tests
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1854639 13f79535-47bb-0310-9956-ffa450edef68
2019-03-02 12:28:19 +00:00
Dominik Stadler
53a30d796e
Bug 62151: Fix warnings about illegal reflective access in Java 9+ by
...
using a similar approach as Apache Hadoop via a CleanerUtil class which encapsulates
the two different approaches for Java <= 8 and Java >= 9
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1854630 13f79535-47bb-0310-9956-ffa450edef68
2019-03-02 09:19:45 +00:00
Dominik Stadler
98b620889b
Remove some remnants of NFileSystem
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1854191 13f79535-47bb-0310-9956-ffa450edef68
2019-02-23 07:52:06 +00:00
Dominik Stadler
8c6e95f597
Add some more testing for bug 63151: NullPointerException in HSSFOptimiser.optimiseFonts(), also execute it as part of large regression tests in the future
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1854190 13f79535-47bb-0310-9956-ffa450edef68
2019-02-23 07:51:57 +00:00
Yegor Kozlov
cafa57cbdd
Bug 60980: Fix parsing formulas with intersections in functions args
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1854037 13f79535-47bb-0310-9956-ffa450edef68
2019-02-21 11:00:40 +00:00
PJ Fanning
bf4396b375
[bug-63151] handle NPE in UnicodeString
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1853859 13f79535-47bb-0310-9956-ffa450edef68
2019-02-19 06:27:04 +00:00
PJ Fanning
37ff2b7fb2
[bug-63187] fix typos
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1853787 13f79535-47bb-0310-9956-ffa450edef68
2019-02-18 09:56:11 +00:00
Yegor Kozlov
c438465b08
Bug 62980: Make D* functions ignore case in headings
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1853268 13f79535-47bb-0310-9956-ffa450edef68
2019-02-09 13:00:09 +00:00
Dominik Stadler
e8ed5e3a8c
Adjust handling of some exceptions in regression tests
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1852278 13f79535-47bb-0310-9956-ffa450edef68
2019-01-27 09:57:49 +00:00
Dominik Stadler
c376d662f9
Bug 60405: Add initial support for cetab functions so some macros can be
...
parsed
Add some function-definitions for Excel 4 Macros and missing functions
found in regression tests
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1852277 13f79535-47bb-0310-9956-ffa450edef68
2019-01-27 09:57:39 +00:00
Vladislav Galas
a08b69df80
pulled *Cell.setCellValue(String), setCellValue(RichTextString) to the common base
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1852255 13f79535-47bb-0310-9956-ffa450edef68
2019-01-26 23:20:07 +00:00
Vladislav Galas
53eee01b5d
pulled *Cell.setCellValue(Date) and setCellValue(Calendar) to the common base
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1852254 13f79535-47bb-0310-9956-ffa450edef68
2019-01-26 23:19:59 +00:00
Vladislav Galas
5da229797f
pulled *Cell.setCellValue(double) to the common base
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1852253 13f79535-47bb-0310-9956-ffa450edef68
2019-01-26 23:19:53 +00:00
Vladislav Galas
70b4b88a3a
pulled *Cell.getCellTypeEnum() to common base
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1852252 13f79535-47bb-0310-9956-ffa450edef68
2019-01-26 23:19:47 +00:00
Vladislav Galas
bc30eceb02
pulled *Cell.getAddress to common base
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1852251 13f79535-47bb-0310-9956-ffa450edef68
2019-01-26 23:19:41 +00:00
Vladislav Galas
39d963aa33
made call Cell.setCellType(CellType.FORMULA) illegall. Deprecated Cell.setCellType(). Purged all redundant calls from project.
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1852246 13f79535-47bb-0310-9956-ffa450edef68
2019-01-26 19:41:25 +00:00
Vladislav Galas
19bf8b23d5
purged calls to cell.setCellType(CellType.BLANK) from the project, replaced with setBlank()
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1852245 13f79535-47bb-0310-9956-ffa450edef68
2019-01-26 19:41:10 +00:00
Vladislav Galas
d60cb3a18c
added Cell.setBlank() - as an alias, for now
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1852244 13f79535-47bb-0310-9956-ffa450edef68
2019-01-26 19:40:56 +00:00
Vladislav Galas
1253a29571
setCellFormula: blank cell gets value 0, non-blank value is preserved
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1852212 13f79535-47bb-0310-9956-ffa450edef68
2019-01-26 10:09:13 +00:00
Dominik Stadler
b5fe208770
Fix some IDE warnings and JVM deprecations
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1851795 13f79535-47bb-0310-9956-ffa450edef68
2019-01-22 10:00:01 +00:00
Yegor Kozlov
698d8eb006
follow-up to Bug 62904. More tests and improved evaluation of IF in array mode
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1851263 13f79535-47bb-0310-9956-ffa450edef68
2019-01-14 14:48:21 +00:00
Dominik Stadler
8c18d93a66
Don't fail on row-nums larger than Integer.MAX_VALUE, we had one sample
...
file which triggered this
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1851211 13f79535-47bb-0310-9956-ffa450edef68
2019-01-13 17:14:31 +00:00
Dominik Stadler
db14c353fc
Fix some Findbugs and IDE issues, refactor some duplicated code,
...
improve some exception texts, add comment for missing Ptg for SxName
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1851210 13f79535-47bb-0310-9956-ffa450edef68
2019-01-13 17:14:24 +00:00
Dominik Stadler
068c820ef4
Bug 62810: AreaReference ctor looses sheet name if rows or columns swapped
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1851209 13f79535-47bb-0310-9956-ffa450edef68
2019-01-13 17:14:05 +00:00
Dominik Stadler
32c43c068c
IDE and JavaDoc fixes, move/remove some unfixed tests
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1851089 13f79535-47bb-0310-9956-ffa450edef68
2019-01-11 19:31:05 +00:00
Vladislav Galas
f64aef7417
unified setCellType(null/_NONE) logic, setCellFormula(null) logic. updated javadoc and tests
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1850676 13f79535-47bb-0310-9956-ffa450edef68
2019-01-07 19:10:19 +00:00
Yegor Kozlov
81033fbad0
Bug 62904: Support array arguments in IF and logical IS*** functions
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1850646 13f79535-47bb-0310-9956-ffa450edef68
2019-01-07 14:34:19 +00:00
PJ Fanning
0849bbc614
throw IllegalArgumnetException if null directory specified
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1850394 13f79535-47bb-0310-9956-ffa450edef68
2019-01-04 16:07:53 +00:00
Vladislav Galas
3b8055baa0
Bug 62993: XSSFEvaluationSheet now retrieves valid last row index from underlying XSSFSheet. Thanks to Axel Howind.
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1850212 13f79535-47bb-0310-9956-ffa450edef68
2019-01-03 00:08:52 +00:00
Vladislav Galas
e501d4015d
Bug 62828: CellReference(Cell) now initializes sheet name.
...
Changed CellReference to CellAddress in XSSFHyperlink because it is what it should return.
Updated all relevant tests, added a test for CellReference(Cell).
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1850210 13f79535-47bb-0310-9956-ffa450edef68
2019-01-02 22:08:38 +00:00
Andreas Beeker
d71a65c388
#63047 - Make POILogger subclassable
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1850040 13f79535-47bb-0310-9956-ffa450edef68
2018-12-31 12:07:37 +00:00
Dominik Stadler
85d6f81076
Bug 60460: Handle null workbook or sheet names and emit #REF as Excel does
...
instead of throwing NullPointerException
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1850008 13f79535-47bb-0310-9956-ffa450edef68
2018-12-30 22:44:40 +00:00