909 Commits

Author SHA1 Message Date
Dominik Stadler
1b7613329e Bug 66425: Add memory-safeguard in one more place
We try to generally avoid overly large allocations in places
where arrays are allocated. 

We add one more such check for pictures in HSLF.

We might need to increase the used value of 10MB if users report 
larger files being used frequently. 

Overriding this check via IOUtils is possible.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1911525 13f79535-47bb-0310-9956-ffa450edef68
2023-08-07 20:35:59 +00:00
Dominik Stadler
163ff25594 Bug 66425: Avoid a ClassCastException found via oss-fuzz
We try to avoid throwing NullPointerException, but it was possible
to trigger one here with a specially crafted input-file

Should fix https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=61266

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1911523 13f79535-47bb-0310-9956-ffa450edef68
2023-08-07 20:01:19 +00:00
Dominik Stadler
8e40aabb18 Bug 66425: Avoid a ClassCastException found via oss-fuzz
We try to avoid throwing ClassCastException, but it was possible
to trigger one here with a specially crafted input-file

Should fix https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=61259

Also fix handling of NullPointerException

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1911517 13f79535-47bb-0310-9956-ffa450edef68
2023-08-07 16:18:46 +00:00
Dominik Stadler
5efa428ca0 Bug 66425: Avoid a ClassCastException found via oss-fuzz
We try to avoid throwing ClassCastException, but it was possible
to trigger one here with a specially crafted input-file

Should fix https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=61242

Also enhance output of some test-failures and allow an empty exception message

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1911515 13f79535-47bb-0310-9956-ffa450edef68
2023-08-07 15:15:38 +00:00
Dominik Stadler
2c5264277a Bug 66425: Avoid an AssertionError found via oss-fuzz
We try to avoid throwing AssertionError to be triggered by input data, but it was possible
to trigger one here with a specially crafted input-file

Should fix https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=61251

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1911514 13f79535-47bb-0310-9956-ffa450edef68
2023-08-07 14:32:11 +00:00
Dominik Stadler
f6b1435db1 Bug 66425: Avoid a ClassCastException found via oss-fuzz
We try to avoid throwing ClassCastException, but it was possible
to trigger one here with a specially crafted input-file

Should fix https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=61243

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1911507 13f79535-47bb-0310-9956-ffa450edef68
2023-08-07 12:09:31 +00:00
Dominik Stadler
a8b31c37a6 Bug 66425: Avoid a ClassCastException found via oss-fuzz
Add exception details and fix expected exceptions to make tests run again

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1911503 13f79535-47bb-0310-9956-ffa450edef68
2023-08-07 11:11:08 +00:00
Dominik Stadler
31fd087a48 Bug 66425: Avoid a ClassCastException found via oss-fuzz
We try to avoid throwing ClassCastException, but it was possible
to trigger one here with a specially crafted input-file

Should fix https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=61249

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1911501 13f79535-47bb-0310-9956-ffa450edef68
2023-08-07 09:42:17 +00:00
Dominik Stadler
6f054ddce1 Fix expected exception text and print out which FileHandler failed in integration-tests
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1911495 13f79535-47bb-0310-9956-ffa450edef68
2023-08-06 17:13:46 +00:00
Dominik Stadler
1e8e95c3a6 Bug 66425: Avoid a ClassCastException found via oss-fuzz
We try to avoid throwing ClassCastException, but it was possible
to trigger one here with a specially crafted input-file

Also rework test a bit to use try-with-resources and proper formatting

Should fix https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=61221

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1911494 13f79535-47bb-0310-9956-ffa450edef68
2023-08-06 14:57:47 +00:00
Dominik Stadler
57d746827f Bug 66425: Avoid a ClassCastException found via oss-fuzz
We try to avoid throwing ClassCastException but it was possible
to trigger one here with a specially crafted input-file

Should fix https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=61162

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1911459 13f79535-47bb-0310-9956-ffa450edef68
2023-08-05 12:13:13 +00:00
PJ Fanning
dd1b0b1128 [bug-66827] add test case (that passes) - so issue is nor reproduced
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1911399 13f79535-47bb-0310-9956-ffa450edef68
2023-08-01 20:49:26 +00:00
PJ Fanning
1f446e0aef undo last change due to broken test
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1911233 13f79535-47bb-0310-9956-ffa450edef68
2023-07-24 12:00:17 +00:00
PJ Fanning
cd2dcd3940 [github-487] Round up seconds in CellElapsedFormatter. Thanks to Anthony Schott. This closes #487
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1911228 13f79535-47bb-0310-9956-ffa450edef68
2023-07-24 10:12:46 +00:00
PJ Fanning
fa8650fbe3 [bug-66682] fix xslb reading support for formula cells of boolean type. This closes #485
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1910951 13f79535-47bb-0310-9956-ffa450edef68
2023-07-12 22:26:41 +00:00
PJ Fanning
e1bb2a73c8 [bug-66675] fix issue with writing xlsx (core properties being added twice)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1910949 13f79535-47bb-0310-9956-ffa450edef68
2023-07-12 12:25:01 +00:00
PJ Fanning
04442923f3 [bug-62181] try to handle file where shared string loading is happening twice
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1910759 13f79535-47bb-0310-9956-ffa450edef68
2023-07-03 20:54:56 +00:00
PJ Fanning
b5153f1395 [bug-66612] get macrosheet xml (test)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1909994 13f79535-47bb-0310-9956-ffa450edef68
2023-05-22 16:00:10 +00:00
PJ Fanning
02efb8f802 revert: [bug-66503] Add flag for Excel 4 macros in composite documents.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1908462 13f79535-47bb-0310-9956-ffa450edef68
2023-03-18 00:59:29 +00:00
PJ Fanning
c12ed0dd1b [bug-66503] Add flag for Excel 4 macros in composite documents. Thanks to M. P. Halpin
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1908461 13f79535-47bb-0310-9956-ffa450edef68
2023-03-18 00:30:58 +00:00
Dominik Stadler
acdf2ec981 Bug 62272: Include alpha/transparency value when setting a color-value for a font
Use method with returns 4 bytes to use an ARGB value instead of only RGB

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1907105 13f79535-47bb-0310-9956-ffa450edef68
2023-01-30 12:19:24 +00:00
PJ Fanning
60872927bd [bug-66433] Boolean functions should blank cells. Thanks to Patrick Böker
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1906836 13f79535-47bb-0310-9956-ffa450edef68
2023-01-20 12:03:52 +00:00
PJ Fanning
968dabd462 [bug-65543] HSSF: fix issue with incomplete SSTs. Thanks to Simon Carter.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1906434 13f79535-47bb-0310-9956-ffa450edef68
2023-01-06 23:50:54 +00:00
PJ Fanning
215da1a1ed add test file
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1906237 13f79535-47bb-0310-9956-ffa450edef68
2022-12-28 07:57:59 +00:00
PJ Fanning
693c59574c [bug-66319] do not create HSSF patriarch to find comments (only use one that pre-exists)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1905943 13f79535-47bb-0310-9956-ffa450edef68
2022-12-12 21:09:09 +00:00
PJ Fanning
5a6df66b07 untidy hack for shared string counts that are higher than Integer.MAX_VALUE
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1905940 13f79535-47bb-0310-9956-ffa450edef68
2022-12-12 18:43:44 +00:00
PJ Fanning
624f834310 [github-404] issue with text runs and styling relating to table cells. Thanks to gffloodg. This closes #404
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1905933 13f79535-47bb-0310-9956-ffa450edef68
2022-12-12 15:18:35 +00:00
PJ Fanning
efc032babc [bug-66365] rework XSSFCell getRichStringCellValue and getStringCellValue to better support array formula results. Thanks to Espen Amble Kolstad.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1905571 13f79535-47bb-0310-9956-ffa450edef68
2022-11-28 13:05:45 +00:00
PJ Fanning
c4a0266cb3 [bug-66335] add test case for issue and add some of the code from purported fix
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1905061 13f79535-47bb-0310-9956-ffa450edef68
2022-11-04 08:33:38 +00:00
PJ Fanning
ba1e8de446 [bug-66312] partial fix for insertNewParagraph(XmlCursor cursor)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1904563 13f79535-47bb-0310-9956-ffa450edef68
2022-10-13 10:38:31 +00:00
PJ Fanning
47e49a3a16 pptx test
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1904334 13f79535-47bb-0310-9956-ffa450edef68
2022-09-29 10:53:01 +00:00
PJ Fanning
acd5d04daa [bug-66278] Bug with multiple gradient stops at the exact same location causing a rendering failure (AWT -> not enough colors in gradient). Thanks to Gareth Floodgate. This closes #385
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1904301 13f79535-47bb-0310-9956-ffa450edef68
2022-09-27 12:09:11 +00:00
PJ Fanning
af6bc9660f [bug-66263] add test case to try to get extra classes into poi-ooxml-lite
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1904079 13f79535-47bb-0310-9956-ffa450edef68
2022-09-14 16:37:29 +00:00
PJ Fanning
d00be6e7db [TIKA-3388] issue with non-ascii chars in file name of embedded OLE object
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1903780 13f79535-47bb-0310-9956-ffa450edef68
2022-08-30 19:46:32 +00:00
PJ Fanning
4df0415621 test for TIKA-2163
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1903777 13f79535-47bb-0310-9956-ffa450edef68
2022-08-30 11:44:27 +00:00
PJ Fanning
59f51987eb test for TIKA-2605
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1903776 13f79535-47bb-0310-9956-ffa450edef68
2022-08-30 11:26:20 +00:00
PJ Fanning
30a0a4362a test for TIKA-3163
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1903775 13f79535-47bb-0310-9956-ffa450edef68
2022-08-30 11:10:46 +00:00
PJ Fanning
913d1eecf5 [bug-63576] support capitalized text in WordExtractor (HWPF)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1903738 13f79535-47bb-0310-9956-ffa450edef68
2022-08-28 14:16:01 +00:00
PJ Fanning
80f89a3674 [bug-63575] support capitalized text in XWPFWordExtractor
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1903729 13f79535-47bb-0310-9956-ffa450edef68
2022-08-28 12:19:08 +00:00
PJ Fanning
95c799cfce [bug-65473] extra test
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1903574 13f79535-47bb-0310-9956-ffa450edef68
2022-08-19 13:14:00 +00:00
PJ Fanning
f1692cc041 [bug-65473] when copy slide, new slide uses old textrun object reference. Thanks to FlyingPigQAQ. This closes #371
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1903558 13f79535-47bb-0310-9956-ffa450edef68
2022-08-19 08:40:32 +00:00
PJ Fanning
3184a18b40 [bug-66216] fix issue where pivotTable.getPivotCacheDefinition() returns null
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1903442 13f79535-47bb-0310-9956-ffa450edef68
2022-08-15 19:20:13 +00:00
PJ Fanning
ed67d48d96 [bug-66215] add test case (that shows we have issues and need fixes)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1903440 13f79535-47bb-0310-9956-ffa450edef68
2022-08-15 18:40:25 +00:00
PJ Fanning
7301e841c7 [bug-66211] add test case
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1903393 13f79535-47bb-0310-9956-ffa450edef68
2022-08-13 15:09:18 +00:00
PJ Fanning
266619f363 revert: github ci perms
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1903174 13f79535-47bb-0310-9956-ffa450edef68
2022-08-01 17:27:45 +00:00
PJ Fanning
82fa836d1f code to handle smart art rotations
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1903096 13f79535-47bb-0310-9956-ffa450edef68
2022-07-29 08:10:51 +00:00
PJ Fanning
cc7fcdfab3 [bug-66176] Integrate SmartArt diagrams from powerpoint presentations. Thanks to Yaseen.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1902934 13f79535-47bb-0310-9956-ffa450edef68
2022-07-22 09:55:10 +00:00
Andreas Beeker
c41176f207 #66115 - Some Password protected XLS files are not read
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1901996 13f79535-47bb-0310-9956-ffa450edef68
2022-06-16 22:56:47 +00:00
PJ Fanning
3f414c760c [bug-66087] make DStar functions case insensitive
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1901229 13f79535-47bb-0310-9956-ffa450edef68
2022-05-25 10:31:07 +00:00
PJ Fanning
d178bb9dc1 [bug-66080] XWPFNumbering.addAbstractNum uses abstract numberings count as id
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1901110 13f79535-47bb-0310-9956-ffa450edef68
2022-05-22 08:28:44 +00:00