2959 Commits

Author SHA1 Message Date
Dominik Stadler
df06e47470 Verify that bug 61294 is fixed now, add some more coverage for IOUtils in general
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1806162 13f79535-47bb-0310-9956-ffa450edef68
2017-08-25 11:51:18 +00:00
Dominik Stadler
8f8f41a7c2 Fix 60384 and 60709: When shifting with merged regions we should correctly check if the region is moved along or needs to be removed because it is not fully kept via the shifting. This was broken by the fix for bug 59740, now additional unit tests ensure that it works better.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1805518 13f79535-47bb-0310-9956-ffa450edef68
2017-08-19 16:31:45 +00:00
Greg Woolsey
c73a4570f8 Bug 61431 - Conditional formatting evaluation ignores undefined cells
now evaluating based on cell references instead, and watching out for undefined cells in rules that require a cell.

Added unit test based on previously failing file.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1805245 13f79535-47bb-0310-9956-ffa450edef68
2017-08-16 23:52:27 +00:00
Andreas Beeker
a98350e40b #61381 - PushbackInputStreams passed to ZipHelper may not hold 8 bytes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1804854 13f79535-47bb-0310-9956-ffa450edef68
2017-08-11 20:47:48 +00:00
Dominik Stadler
abd7c696ae Reformat code slightly
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1803612 13f79535-47bb-0310-9956-ffa450edef68
2017-08-01 06:26:27 +00:00
Andreas Beeker
48b01fc621 Fix further Windows JVM 6 font rendering errors - OOM and EXCEPTION_ACCESS_VIOLATION
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1803528 13f79535-47bb-0310-9956-ffa450edef68
2017-07-31 12:25:23 +00:00
Andreas Beeker
e7179159fd remove invalid javadocs
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1803493 13f79535-47bb-0310-9956-ffa450edef68
2017-07-31 08:42:48 +00:00
Nick Burch
9616e10cbd Javadoc fixes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1803488 13f79535-47bb-0310-9956-ffa450edef68
2017-07-31 06:36:10 +00:00
Andreas Beeker
0d8350b03a #61363 - Unify escher shape id allocation
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1803483 13f79535-47bb-0310-9956-ffa450edef68
2017-07-30 23:11:36 +00:00
Greg Woolsey
3cea90e7c4 Fix data validation value list evaluation
One of my users found that my initial implementation was lacking a core distinction - most evaluations expect a single result, and "unwrap" 2/3D ValueEval results to a single value based on the input row/column.

However, data validation list formulas explicitly are expected to return a 2D ValueEval.  This worked when the formula was simple and evaluated to a single Ptg, but only returned one value when the formula was more complex, or referenced a named range defined as a complex formula.

This change teaches WorkbookEvaluator about the distinction, by way of a new attribute for FormulaType.

There is room for discussion over how it is implemented, but this works for me.

Includes the failing workbook we had as a new unit test.

While I was in FormulaType I went ahead and removed the deprecated, unused, and redundant code marked for removal in 3.17.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1803121 13f79535-47bb-0310-9956-ffa450edef68
2017-07-26 22:19:58 +00:00
Tim Allison
b1a0c7d53d 61337 -- try to convert assertions to exceptions. I left in the assertions for the binary search components.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1803092 13f79535-47bb-0310-9956-ffa450edef68
2017-07-26 18:43:27 +00:00
Tim Allison
a9c4072071 61346 add more sanity checks before allocating byte arrays in emf/wmf
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1803041 13f79535-47bb-0310-9956-ffa450edef68
2017-07-26 12:46:24 +00:00
Tim Allison
1aa1e25f71 61295 -- prevent potential oom in HPSF triggered by fuzzed file
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1802879 13f79535-47bb-0310-9956-ffa450edef68
2017-07-25 01:38:35 +00:00
Andreas Beeker
b8242721fb Bug 61331 - Font group handling / common font interface
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1802741 13f79535-47bb-0310-9956-ffa450edef68
2017-07-23 22:45:47 +00:00
Dominik Stadler
7b8e1c9150 My version of Java 6 chokes on Generics here
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1802633 13f79535-47bb-0310-9956-ffa450edef68
2017-07-21 18:19:29 +00:00
PJ Fanning
52d3ea57f4 javadoc: replace invalid self enclosing elements
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1802110 13f79535-47bb-0310-9956-ffa450edef68
2017-07-17 08:24:24 +00:00
PJ Fanning
69cc48aa85 some javadoc fixes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1802035 13f79535-47bb-0310-9956-ffa450edef68
2017-07-15 22:31:09 +00:00
Tim Allison
d320b2ea4a bug 61300 -- prevent really long (infinite?) loop on corrupt file
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1801989 13f79535-47bb-0310-9956-ffa450edef68
2017-07-14 20:47:40 +00:00
Tim Allison
5a9d05487d bug 61286/bug 61287 -- allow WriteProtectRecord to have 2 bytes, and allow for HeaderFooter to be empty.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1801966 13f79535-47bb-0310-9956-ffa450edef68
2017-07-14 13:54:06 +00:00
Tim Allison
1a8b5234ec bug 61294 -- cleaned up based on PJ Fanning's code review. Went with a copy/paste from commons-io.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1801952 13f79535-47bb-0310-9956-ffa450edef68
2017-07-14 12:48:28 +00:00
Tim Allison
34cb860998 bug 61294 -- prevent infinite loop in IOUtils' skipFully.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1801844 13f79535-47bb-0310-9956-ffa450edef68
2017-07-13 16:20:28 +00:00
Javen O'Neal
5c2267081d replace commented-out throw-away code that writes workbook to C:\temp\xxxxx.xlsx for manual review with XSSFTestDataSamples.writeOut(wb, "bug xxxxx for manual review")
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1801801 13f79535-47bb-0310-9956-ffa450edef68
2017-07-13 04:19:20 +00:00
Javen O'Neal
4364dd5d02 replace return variable assignments with return statements
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1801799 13f79535-47bb-0310-9956-ffa450edef68
2017-07-13 03:42:12 +00:00
Javen O'Neal
d6c7e3e6a7 github #43: fix roundUp and roundDown.
Thanks to @FishMeat on github for the patch.
This closes #43 on github.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1801798 13f79535-47bb-0310-9956-ffa450edef68
2017-07-13 03:35:06 +00:00
PJ Fanning
2a42bbafc6 remove more deprecated methods
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1801697 13f79535-47bb-0310-9956-ffa450edef68
2017-07-12 08:38:20 +00:00
PJ Fanning
879a6d20c3 [Bug-61268] avoid NegativeArraySizeException parsing doc file
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1801395 13f79535-47bb-0310-9956-ffa450edef68
2017-07-09 22:32:27 +00:00
PJ Fanning
6a4ffa5d6d fix spelling
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1801393 13f79535-47bb-0310-9956-ffa450edef68
2017-07-09 21:34:53 +00:00
Nick Burch
933f9c1201 #61266 Test for old unsupported MS Write WRI files, and give a more helpful exception if found, plus unit tests
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1801376 13f79535-47bb-0310-9956-ffa450edef68
2017-07-09 16:26:33 +00:00
Andreas Beeker
236678598e Rollback of r1801368 because of a generics bug with self-referenced types in Java6
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1801373 13f79535-47bb-0310-9956-ffa450edef68
2017-07-09 15:27:29 +00:00
Andreas Beeker
8c6e00d626 SL Common: narrow generics definition because of tighter java9 checks
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1801368 13f79535-47bb-0310-9956-ffa450edef68
2017-07-09 11:09:45 +00:00
Andreas Beeker
c82aa1a4bb #61169 - Text with Japanese characters overflows textbox
- add resize methods with Graphics argument

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1801329 13f79535-47bb-0310-9956-ffa450edef68
2017-07-08 22:20:55 +00:00
PJ Fanning
31f2a54bde [github-25] support excel number trailing comma format - Thabks to Luca Martini for proving the patch
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1800975 13f79535-47bb-0310-9956-ffa450edef68
2017-07-06 07:56:57 +00:00
PJ Fanning
c702afd1b1 [Bug 58975] do not cast numberOfOperands to byte in AbstractFunctionPtg
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1800949 13f79535-47bb-0310-9956-ffa450edef68
2017-07-05 22:56:32 +00:00
PJ Fanning
329c87cc68 fix javadoc issue
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1800717 13f79535-47bb-0310-9956-ffa450edef68
2017-07-03 22:18:25 +00:00
PJ Fanning
26389768b9 [Bug 60422] fix data formatter issue with specific format in German locale
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1800713 13f79535-47bb-0310-9956-ffa450edef68
2017-07-03 20:56:02 +00:00
Andreas Beeker
6e6136ba89 #61243 - Refactor and unify toString/toXml in DDF
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1800452 13f79535-47bb-0310-9956-ffa450edef68
2017-06-30 20:21:33 +00:00
PJ Fanning
a420b90906 Remove more deprecated code (MissingCellPolicy)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1800400 13f79535-47bb-0310-9956-ffa450edef68
2017-06-30 13:00:57 +00:00
PJ Fanning
0dff17384f Remove more deprecated code (BorderFormatting constants)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1800385 13f79535-47bb-0310-9956-ffa450edef68
2017-06-30 12:18:13 +00:00
PJ Fanning
95d9bec68b Remove more deprecated code (especially from Spreadsheet Cell classes)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1800375 13f79535-47bb-0310-9956-ffa450edef68
2017-06-30 11:48:23 +00:00
PJ Fanning
bcdbd92d43 remove deprecated org.apache.poi.hssf.record.RecordFormatException
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1800256 13f79535-47bb-0310-9956-ffa450edef68
2017-06-29 09:06:30 +00:00
PJ Fanning
48643ad880 remove some unused imports
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1800255 13f79535-47bb-0310-9956-ffa450edef68
2017-06-29 08:55:35 +00:00
PJ Fanning
6b4d045b20 remove deprecated org.apache.poi.hssf.record.RecordFormatException
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1800249 13f79535-47bb-0310-9956-ffa450edef68
2017-06-29 08:37:02 +00:00
PJ Fanning
0b758698a5 Remove old XSSFPaswordHelper
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1800247 13f79535-47bb-0310-9956-ffa450edef68
2017-06-29 08:10:32 +00:00
Nick Burch
30072f2c86 Fix javadoc warnings
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1800214 13f79535-47bb-0310-9956-ffa450edef68
2017-06-28 23:30:15 +00:00
Nick Burch
91f611256f Used deprecated external method removed, so remove internal method
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1800211 13f79535-47bb-0310-9956-ffa450edef68
2017-06-28 23:25:41 +00:00
PJ Fanning
5d4a4a7f28 Ensure SpreadsheetVersion is set for AreaReferences
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1800208 13f79535-47bb-0310-9956-ffa450edef68
2017-06-28 22:11:26 +00:00
PJ Fanning
b68b916d08 Remove some deprecated *SSF APIs
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1800147 13f79535-47bb-0310-9956-ffa450edef68
2017-06-28 10:34:37 +00:00
PJ Fanning
3f4267c3bc expand StaxHelper
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1799772 13f79535-47bb-0310-9956-ffa450edef68
2017-06-24 13:53:47 +00:00
PJ Fanning
6df937ec6b Add StaxHelper to ensure that StAX parsers have sensible defaults, including settings to avoid XML Entity Expansion issues
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1799734 13f79535-47bb-0310-9956-ffa450edef68
2017-06-24 07:30:07 +00:00
Greg Woolsey
8f0cea061e Move my new unit conversions to the Units class, move and deprecate duplicate and scattered unit constants, update constant references to standardize on the ones in the Units class.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1799683 13f79535-47bb-0310-9956-ffa450edef68
2017-06-23 15:43:48 +00:00