18 Commits

Author SHA1 Message Date
Dominik Stadler
50874d9d0d Bug 63509: Allow to format a CellReference without sheet-name for ignoredErrors.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1861817 13f79535-47bb-0310-9956-ffa450edef68
2019-06-22 06:12:05 +00:00
Dominik Stadler
b5fe208770 Fix some IDE warnings and JVM deprecations
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1851795 13f79535-47bb-0310-9956-ffa450edef68
2019-01-22 10:00:01 +00:00
Dominik Stadler
8c18d93a66 Don't fail on row-nums larger than Integer.MAX_VALUE, we had one sample
file which triggered this

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1851211 13f79535-47bb-0310-9956-ffa450edef68
2019-01-13 17:14:31 +00:00
Dominik Stadler
db14c353fc Fix some Findbugs and IDE issues, refactor some duplicated code,
improve some exception texts, add comment for missing Ptg for SxName

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1851210 13f79535-47bb-0310-9956-ffa450edef68
2019-01-13 17:14:24 +00:00
Dominik Stadler
a1a1797299 Add one more test for bug 62828 and fix some IDE warnings
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1851088 13f79535-47bb-0310-9956-ffa450edef68
2019-01-11 19:30:44 +00:00
Vladislav Galas
e501d4015d Bug 62828: CellReference(Cell) now initializes sheet name.
Changed CellReference to CellAddress in XSSFHyperlink because it is what it should return.
Updated all relevant tests, added a test for CellReference(Cell).

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1850210 13f79535-47bb-0310-9956-ffa450edef68
2019-01-02 22:08:38 +00:00
Dominik Stadler
12c9b23917 Fix some compiler warnings
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808523 13f79535-47bb-0310-9956-ffa450edef68
2017-09-16 08:29:28 +00:00
Dominik Stadler
f1f07e00bb Remove unused imports
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808513 13f79535-47bb-0310-9956-ffa450edef68
2017-09-16 08:23:48 +00:00
Javen O'Neal
254d6ebd43 github-55: document that CellReference#isRowWithinRange(String rowNum, SpreadsheetVersion ss) expects rowNum to be parseable as an integer
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1795681 13f79535-47bb-0310-9956-ffa450edef68
2017-05-20 21:04:14 +00:00
Javen O'Neal
b37f023157 improve unit test coverage on CellReference.
Add note that _sheetName can be null or empty string, depending on the entry-point.
Throw an exception when parsing a string if sheet name is not quoted and contains a space.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748144 13f79535-47bb-0310-9956-ffa450edef68
2016-06-13 08:58:55 +00:00
Javen O'Neal
cb800acd83 bug 59684: correctly parse CellReference(HOMEst163); Also deprecate misspelled methods isRowWithinRange/isColumnWithinRange
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747687 13f79535-47bb-0310-9956-ffa450edef68
2016-06-10 11:52:44 +00:00
Javen O'Neal
8c3db2edd5 convert junit3 to junit4
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1715752 13f79535-47bb-0310-9956-ffa450edef68
2015-11-23 10:26:06 +00:00
Nick Burch
3be3f5c2da Fix indents
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1696429 13f79535-47bb-0310-9956-ffa450edef68
2015-08-18 14:34:52 +00:00
Nick Burch
bed2ee69c3 Patch from Javen ONeal from bug #58252 - More CellReference unit testing coverage
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1696427 13f79535-47bb-0310-9956-ffa450edef68
2015-08-18 14:32:53 +00:00
Dominik Stadler
f465ee1313 * Add missing close() on streams in ImageUtils.getImageDimension()
* Add some unit tests for CellReference

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1650070 13f79535-47bb-0310-9956-ffa450edef68
2015-01-07 14:36:39 +00:00
Nick Burch
3cd79ea026 Fix bug #50718 - More helpful error message when you try to create a CellReference with #REF!
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1078039 13f79535-47bb-0310-9956-ffa450edef68
2011-03-04 16:17:21 +00:00
Josh Micich
5fbf7c2350 Bugzilla 47312 - Fixed formula parser to properly reject cell references with a '0' row component
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@781616 13f79535-47bb-0310-9956-ffa450edef68
2009-06-03 23:23:13 +00:00
Paolo Mottadelli
ba8c1c39a7 XSSFSheet addMergedRegion + Region class moved to org.apache.poi.ss.util.Region + Region.getRegionRef method + tests
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ooxml@645303 13f79535-47bb-0310-9956-ffa450edef68
2008-04-06 20:34:00 +00:00