50 Commits

Author SHA1 Message Date
Tim Allison
53b55eb4c3 Bug 61349 -- add more sanity checks when allocating byte[]
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1809169 13f79535-47bb-0310-9956-ffa450edef68
2017-09-21 14:52:59 +00:00
Dominik Stadler
399381da8d Remove unnecessary local variables
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808518 13f79535-47bb-0310-9956-ffa450edef68
2017-09-16 08:28:38 +00:00
Dominik Stadler
0cfa1ede4c Remove unnecessary type arguments (Java 8)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808516 13f79535-47bb-0310-9956-ffa450edef68
2017-09-16 08:27:23 +00:00
Dominik Stadler
202b2b0be5 Remove unnecessary semicolons
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808511 13f79535-47bb-0310-9956-ffa450edef68
2017-09-16 08:23:15 +00:00
PJ Fanning
deb0aca6ac remove some deprecated code slated for removal in 3.18
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808403 13f79535-47bb-0310-9956-ffa450edef68
2017-09-14 23:44:47 +00:00
Andreas Beeker
98b10cf684 #52117 - Invalid "last printed" summary field value - added helper method to identify undefined dates
HPSF: fixed uid listing in Section.toString()
HPSF: moved timestamp based "utility" methods to Filetime class
HPSF: preserve original datastream for unchanged property sets

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1795123 13f79535-47bb-0310-9956-ffa450edef68
2017-05-14 22:25:33 +00:00
Andreas Beeker
24f2dcf6cb #52372 - OutOfMemoryError parsing a word file
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1793602 13f79535-47bb-0310-9956-ffa450edef68
2017-05-02 23:32:13 +00:00
Dominik Stadler
5ca0b239bf Let IntelliJ cleanup some code-warnings across the whole code-base: unnecessary toString or semicolon
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1791720 13f79535-47bb-0310-9956-ffa450edef68
2017-04-17 20:13:52 +00:00
Andreas Beeker
da20cf5d63 Sonarqube fixes - Cast one of the operands of this multiplication operation to a ...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1776894 13f79535-47bb-0310-9956-ffa450edef68
2017-01-01 22:59:35 +00:00
Andreas Beeker
00d574164e #60331 - Remove deprecated classes - deprecate Mutable* property classes
sonarcube fix - make protected attributes private

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1771640 13f79535-47bb-0310-9956-ffa450edef68
2016-11-27 20:19:18 +00:00
Andreas Beeker
3930739eab fixing javadocs errors (in JDK8)
removing Rainers author tags as those cause a lot of errors and should be omitted anyways (see https://poi.apache.org/guidelines.html)

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748046 13f79535-47bb-0310-9956-ffa450edef68
2016-06-12 20:19:59 +00:00
Andreas Beeker
012cfb107c sonar fixes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1706648 13f79535-47bb-0310-9956-ffa450edef68
2015-10-04 00:35:30 +00:00
Andreas Beeker
fad6546d8a sonar fixes
Very interesting was the exception swallowing in PackagePropertiesPart. When it was properly thrown, it already led to various errors in the junits test - I've fixed the handling for at least the ones which are in our test set

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1706169 13f79535-47bb-0310-9956-ffa450edef68
2015-09-30 23:06:39 +00:00
Andreas Beeker
aacf48d5aa sonar fixes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1705814 13f79535-47bb-0310-9956-ffa450edef68
2015-09-29 08:31:15 +00:00
Dominik Stadler
82eff19e00 Fix some Eclipse warnings and adjust use of Generics, Comments, close()
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1691308 13f79535-47bb-0310-9956-ffa450edef68
2015-07-16 03:41:57 +00:00
Dominik Stadler
ca12a21163 Fix Eclipse warnings, unnecessary casts, use generics, static access...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1648156 13f79535-47bb-0310-9956-ffa450edef68
2014-12-28 09:06:12 +00:00
Andreas Beeker
2e6de07eb1 FindBugs fix
- fixed "Should be a static inner class"
- see http://findbugs.sourceforge.net/bugDescriptions.html#SIC_INNER_SHOULD_BE_STATIC


git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1568178 13f79535-47bb-0310-9956-ffa450edef68
2014-02-14 01:00:45 +00:00
Nick Burch
878e9880a5 Remove some generics warnings from the HPSF custom properties and sections parts
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@898804 13f79535-47bb-0310-9956-ffa450edef68
2010-01-13 15:42:53 +00:00
Josh Micich
78e643fe21 Bugzilla 47962 - Fixed some potential NPEs. Avoided unnecessary creation of box instances. Applied patch with mods
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@823348 13f79535-47bb-0310-9956-ffa450edef68
2009-10-08 22:29:41 +00:00
Yegor Kozlov
4d835fbda7 Avoid exception when reading ClipboardData packet in OLE property sets, see bugzilla 45583
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@806172 13f79535-47bb-0310-9956-ffa450edef68
2009-08-20 13:49:33 +00:00
Josh Micich
a2cd9a942e Fixed compiler warnings - unnecessary else
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@805492 13f79535-47bb-0310-9956-ffa450edef68
2009-08-18 16:50:24 +00:00
Josh Micich
4d3fd6fff5 removed '@version $Id:$' tags (all were in javadoc comments)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@780832 13f79535-47bb-0310-9956-ffa450edef68
2009-06-01 21:07:20 +00:00
Rainer Klute
2ae2bf346f - Fixed bug 44375 - HPSF now copes with a broken dictionary in Document Summary Information stream. RuntimeExceptions that occured when trying to read bogus data are now caught. Dictionary entries up to but not including the bogus one are preserved, the rest is ignored.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@619848 13f79535-47bb-0310-9956-ffa450edef68
2008-02-08 11:55:43 +00:00
Rainer Klute
ce9f8ceb88 Consistency check added when reading property set stream. An IllegalPropertyDataException is thrown if the property set stream is larger than it claims to be.
git-svn-id: https://svn.apache.org/repos/asf/jakarta/poi/trunk@550021 13f79535-47bb-0310-9956-ffa450edef68
2007-06-23 07:44:47 +00:00
Henri Yandell
b8f7a14477 Applying the copy2license.pl script (with tiny modification to allow for more whitespace than it expects in the POI header) to all files. ant jar succeeds, and the svn diff has been verified by eye. Still more files to do, this is the first pass.
git-svn-id: https://svn.apache.org/repos/asf/jakarta/poi/trunk@489730 13f79535-47bb-0310-9956-ffa450edef68
2006-12-22 19:18:16 +00:00
Rainer Klute
73a9af683f * Writing support added to the SummaryInformation and DocumentSummaryInformation classes. These classes now have methods for setting and removing properties. Coherent extensions are:
** Documentation section about writing standard properties added to the HPSF HOW-TO.
** Example application added showing how to modify the document summary information.
** Testcases added for testing modifying summary information and document summary information.
** PropertySetFactory extended to create SummaryInformation and DocumentSummaryInformation instances.

* Added MutablePropertySet.write(DirectoryEntry, String) to ease writing a property set to a POI filesystem document.

* Improved codepage handling.

* Bug fixed: Integral values were read and written as unsigned instead of signed.

* Reworked the mapping between variant types and Java types: Variant.VT_I4 is mapped to Integer now and Variant.VT_I8 to Long. This might cause incompatibilities if you are doing low-level HPSF programming. 

* Changed SectionIDMap.DOCUMENT_SUMMARY_INFORMATION_ID from a byte[] to a byte[][] in order to contain the format ID of the first and the second section. This is an incompatible change!

* Added PropertySet.getFirstSection(). This method is similar to getSingleSection() won't choke if the property set has more than one section.

* Support for low-level reading and writing of Variant.VT_I8 type properties added.

* Unnecessary casts removed.

* Poibrowser's display format changed slightly.



git-svn-id: https://svn.apache.org/repos/asf/jakarta/poi/trunk@382887 13f79535-47bb-0310-9956-ffa450edef68
2006-03-03 16:57:55 +00:00
Rainer Klute
14befc7fea Fixed a bug where the logical comparison of two sections returned false only because one of them had property 1 (codepage) and the other had not. Now two sections are equal if their property values are equal disregarding property 1.
git-svn-id: https://svn.apache.org/repos/asf/jakarta/poi/trunk@353583 13f79535-47bb-0310-9956-ffa450edef68
2004-08-15 13:43:35 +00:00
Rainer Klute
8fc4b6ba05 - Fix: HPSF now ensures that string properties are always written with the type Variant.VT_LPWSTR instead of Variant.VT_LPSTR if the codepage is 1200 (Unicode).
- Code cleanup (propertyCount in MutableSection removed).
- Codepage numbers aggregated in the new class org.apache.poi.hpsf.Constants.


git-svn-id: https://svn.apache.org/repos/asf/jakarta/poi/trunk@353561 13f79535-47bb-0310-9956-ffa450edef68
2004-06-22 16:11:39 +00:00
Glen Stampoultzis
58f1c92183 New licence changes.
git-svn-id: https://svn.apache.org/repos/asf/jakarta/poi/trunk@353545 13f79535-47bb-0310-9956-ffa450edef68
2004-04-09 13:05:39 +00:00
Rainer Klute
319c1c1fe8 HPSF: codepage support added
git-svn-id: https://svn.apache.org/repos/asf/jakarta/poi/trunk@353460 13f79535-47bb-0310-9956-ffa450edef68
2003-12-02 17:46:01 +00:00
Rainer Klute
6d1eefc2ea - Added Robert Flaherty's method getCustomProperties() (refactored)
- Got rid of the PropertySet instance variable sectionCount. Use getSectionCount() instead!
- Minor fixes


git-svn-id: https://svn.apache.org/repos/asf/jakarta/poi/trunk@353409 13f79535-47bb-0310-9956-ffa450edef68
2003-10-23 20:44:24 +00:00
Rainer Klute
bb343314a6 - Comparing sections refined: For the dictionary (property 0) only the value (Map) is relevant. The dictionary's codepage (property 1) is disregarded.
- New sample application CopyCompare. I'll turn that into a testcase later.


git-svn-id: https://svn.apache.org/repos/asf/jakarta/poi/trunk@353362 13f79535-47bb-0310-9956-ffa450edef68
2003-09-20 15:43:08 +00:00
Rainer Klute
8f08b03cf0 These changes introduce the following HPSF enhancements and fixes:
- Section dictionaries (aka custom properties) can be written now.
- Constructor MutableProperty(PropertySet) sets the class ID correctly now.
- Possible invalid section count fixed
- More testcases
- Cosmetics


git-svn-id: https://svn.apache.org/repos/asf/jakarta/poi/trunk@353360 13f79535-47bb-0310-9956-ffa450edef68
2003-09-18 18:56:35 +00:00
Rainer Klute
d99a03d6d9 - PropertySetFactory.create(InputStream) no longer throws an UnexpectedPropertySetTypeException.
- HPSFRuntimeException is thrown when the application tries to read a non-integer property with Section.getPropertyIntValue(long).
- Package description updated.
- ClassIDhashCode() implemented.


git-svn-id: https://svn.apache.org/repos/asf/jakarta/poi/trunk@353349 13f79535-47bb-0310-9956-ffa450edef68
2003-09-13 12:31:28 +00:00
Rainer Klute
1de48575d0 Writing: API enhanced, bugs fixed, performance improvements, code simplifications, two new testcases, more int to long promotions.
git-svn-id: https://svn.apache.org/repos/asf/jakarta/poi/trunk@353341 13f79535-47bb-0310-9956-ffa450edef68
2003-09-04 20:15:24 +00:00
Rainer Klute
16bacce309 Property ID handling fixed (long vs. int).
git-svn-id: https://svn.apache.org/repos/asf/jakarta/poi/trunk@353332 13f79535-47bb-0310-9956-ffa450edef68
2003-09-01 18:53:28 +00:00
Rainer Klute
468615d2d9 HPSF writing capability added.
git-svn-id: https://svn.apache.org/repos/asf/jakarta/poi/trunk@353321 13f79535-47bb-0310-9956-ffa450edef68
2003-08-30 09:13:53 +00:00
Rainer Klute
a32efda12e - Fixed a bug that occured when reading a section with properties that are not stored with ascending offsets in the property list.
- An error message is printed to standard error now when an unsupported variant type occurs. The data bytes are still available.


git-svn-id: https://svn.apache.org/repos/asf/jakarta/poi/trunk@353307 13f79535-47bb-0310-9956-ffa450edef68
2003-08-23 15:12:22 +00:00
Rainer Klute
73e9bc7c93 Writing preparations
git-svn-id: https://svn.apache.org/repos/asf/jakarta/poi/trunk@353285 13f79535-47bb-0310-9956-ffa450edef68
2003-08-03 20:16:46 +00:00
Rainer Klute
a47c0bb61d Javadoc, formatting and style improvements
git-svn-id: https://svn.apache.org/repos/asf/jakarta/poi/trunk@353280 13f79535-47bb-0310-9956-ffa450edef68
2003-08-02 19:02:28 +00:00
Rainer Klute
dbc26d7625 First preparations for HPSF writing functionality.
git-svn-id: https://svn.apache.org/repos/asf/jakarta/poi/trunk@353013 13f79535-47bb-0310-9956-ffa450edef68
2003-02-22 14:27:16 +00:00
Rainer Klute
15f8d2c185 Comment improved.
git-svn-id: https://svn.apache.org/repos/asf/jakarta/poi/trunk@352991 13f79535-47bb-0310-9956-ffa450edef68
2003-01-29 18:01:18 +00:00
Rainer Klute
cb45ae088b HPSF: Reading Unicode properties are supported now.
git-svn-id: https://svn.apache.org/repos/asf/jakarta/poi/trunk@352933 13f79535-47bb-0310-9956-ffa450edef68
2002-12-10 06:15:20 +00:00
Rainer Klute
b509a3fe4c Broken HPSF usage of POI's general little-endian classes fixed.
git-svn-id: https://svn.apache.org/repos/asf/jakarta/poi/trunk@352778 13f79535-47bb-0310-9956-ffa450edef68
2002-07-17 16:23:22 +00:00
Andrew C. Oliver
8ecb76b142 Finished my work converting HPSF to use the org.apache.poi.util.LittleEndian
implementation.  ClassID and poibrowser/PropertySetDescriptorRendeder are probably broken.  I couldn't figure out what ClassID is meaning to do someone else
who understands the code there will have to work on it.

PR:
Obtained from:
Submitted by:
Reviewed by:


git-svn-id: https://svn.apache.org/repos/asf/jakarta/poi/trunk@352639 13f79535-47bb-0310-9956-ffa450edef68
2002-05-19 18:09:26 +00:00
Andrew C. Oliver
7e07780e8a surgery
PR:
Obtained from:
Submitted by:
Reviewed by:


git-svn-id: https://svn.apache.org/repos/asf/jakarta/poi/trunk@352612 13f79535-47bb-0310-9956-ffa450edef68
2002-05-11 14:47:24 +00:00
Rainer Klute
8f6a623558 Enhancements from Drew for boolean properties. Plus doc change for DWord.
git-svn-id: https://svn.apache.org/repos/asf/jakarta/poi/trunk@352594 13f79535-47bb-0310-9956-ffa450edef68
2002-05-03 07:29:09 +00:00
Rainer Klute
e57c0ac37b Added Drew's thumbnail enhancements.
git-svn-id: https://svn.apache.org/repos/asf/jakarta/poi/trunk@352578 13f79535-47bb-0310-9956-ffa450edef68
2002-05-01 09:31:52 +00:00
Andrew C. Oliver
883552de53 applied 8632
PR:
Obtained from:
Submitted by:
Reviewed by:


git-svn-id: https://svn.apache.org/repos/asf/jakarta/poi/trunk@352567 13f79535-47bb-0310-9956-ffa450edef68
2002-04-30 03:51:03 +00:00
Mark Johnson
e2841de795 Added Rainer Klute's poibrowser utility and hpsf packages
git-svn-id: https://svn.apache.org/repos/asf/jakarta/poi/trunk@352095 13f79535-47bb-0310-9956-ffa450edef68
2002-02-14 04:00:59 +00:00