3373 Commits

Author SHA1 Message Date
Tim Allison
5976721660 64261 -- fix handling of drop down list when items are selected
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1875956 13f79535-47bb-0310-9956-ffa450edef68
2020-03-31 18:16:09 +00:00
Andreas Beeker
a850690d7c Sonar Fixes
- name clashes with constants
- missing break in switch statements

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1875863 13f79535-47bb-0310-9956-ffa450edef68
2020-03-29 22:37:23 +00:00
Andreas Beeker
3cb1a38d8e Sonar Fixes - try to fix XXE warnings
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1875860 13f79535-47bb-0310-9956-ffa450edef68
2020-03-29 14:55:31 +00:00
Andreas Beeker
c01273ad02 Sonar Fixes
- use String.replace instead of String.replaceAll for literal values
- use constants from base class

- deprecated various references to constants of org.apache.poi.ss.usermodel.FontFormatting - to be replaced by o.a.p.s.u.Font in POI 5.0.0

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1875859 13f79535-47bb-0310-9956-ffa450edef68
2020-03-29 14:39:11 +00:00
Dominik Stadler
cc1b6557ee Bug 63845: Adjust handling of formula-cells to fix regression introduced in 4.1.0
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1875837 13f79535-47bb-0310-9956-ffa450edef68
2020-03-29 08:16:17 +00:00
Dominik Stadler
e88fac30b8 Bug 61863: Update JavaDoc to describe relation to workbook-level flag
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1875804 13f79535-47bb-0310-9956-ffa450edef68
2020-03-28 09:49:24 +00:00
Andreas Beeker
7a340230fd #64241 - shade and tint calculation are based now on scRGB (opposed to HSL) colorspace
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1875522 13f79535-47bb-0310-9956-ffa450edef68
2020-03-22 18:59:43 +00:00
Andreas Beeker
d3de3636cf #64241 - XSLF - Wrong scheme colors used when rendering
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1875499 13f79535-47bb-0310-9956-ffa450edef68
2020-03-21 18:25:38 +00:00
Andreas Beeker
9de555bfd4 #64213 - Picture.resize(double scale) scales width wrong for small pictures and when dx1 is set
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1875266 13f79535-47bb-0310-9956-ffa450edef68
2020-03-16 18:46:48 +00:00
Andreas Beeker
ef90a5f2c8 Get UUID from ClassID
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1874989 13f79535-47bb-0310-9956-ffa450edef68
2020-03-08 23:20:44 +00:00
Dominik Stadler
199895bfc4 Work on bug 64038 and other bugs and add test for 62865
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1874983 13f79535-47bb-0310-9956-ffa450edef68
2020-03-08 20:17:19 +00:00
Dominik Stadler
77fbcb788d Try to use https for poi.apache.org everywhere
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1874981 13f79535-47bb-0310-9956-ffa450edef68
2020-03-08 20:17:08 +00:00
Dominik Stadler
a7d96dcb73 Bug 58896 and 52834: Cache Sheet.getMergedRegions() as it seems to sometimes be the culprit for autosize taking a very long time.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1874973 13f79535-47bb-0310-9956-ffa450edef68
2020-03-08 11:17:34 +00:00
Dominik Stadler
1e8cba79ce Bug 60282: Update JavaDoc and use a common constant for TWIPS_PER_POINT
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1874966 13f79535-47bb-0310-9956-ffa450edef68
2020-03-08 08:28:17 +00:00
Dominik Stadler
af4751b260 Update JavaDoc for logging and marshalling
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1874965 13f79535-47bb-0310-9956-ffa450edef68
2020-03-08 08:28:11 +00:00
Dominik Stadler
2776f18423 Fix incorrect handling of format which should not produce any digit for zero
Also include the internally computed format-string when the resulting format causes an exception

One other case with question marks is still not handled correctly, though

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1874950 13f79535-47bb-0310-9956-ffa450edef68
2020-03-07 15:33:53 +00:00
Andreas Beeker
3691704678 Sonar fixes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1874530 13f79535-47bb-0310-9956-ffa450edef68
2020-02-25 21:27:07 +00:00
Axel Howind
fd4410d50b replace some calls to Collection methods with shorter/more effective versions
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1874263 13f79535-47bb-0310-9956-ffa450edef68
2020-02-20 16:27:19 +00:00
Axel Howind
842e71a3d7 use indexOf(char) instead of indexOf(String) where possible; replace one more StringBuffer with StringBuilder - bug 63805
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1874262 13f79535-47bb-0310-9956-ffa450edef68
2020-02-20 15:51:17 +00:00
Axel Howind
09d55c7832 Applied "clean up IntList code" patch from bug 63805
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1874257 13f79535-47bb-0310-9956-ffa450edef68
2020-02-20 15:04:57 +00:00
Andreas Beeker
bc969fe4aa PPTX2PNG - fix SVG gradients
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1874150 13f79535-47bb-0310-9956-ffa450edef68
2020-02-17 22:29:29 +00:00
Tim Allison
636cc83665 Bug 64130 -- handle empty worksheet names in OldSheetRecord more robustly.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1873863 13f79535-47bb-0310-9956-ffa450edef68
2020-02-10 17:38:29 +00:00
Andreas Beeker
8803989321 Use indexed palette for duo tone pattern
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1873516 13f79535-47bb-0310-9956-ffa450edef68
2020-02-03 00:25:52 +00:00
Andreas Beeker
4a2273c370 XSLF Performance - don't initialize the JAXBContext every time
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1873499 13f79535-47bb-0310-9956-ffa450edef68
2020-02-02 11:15:56 +00:00
Andreas Beeker
5acb7d6c47 TextLayout.getAdvance() for " " returns 0 in some cases / JDKs, which caused an div by 0 -> Infinity problem
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1873494 13f79535-47bb-0310-9956-ffa450edef68
2020-02-02 06:04:14 +00:00
Dominik Stadler
d3767e1de7 Improve some assertions and error messages for exceptions seen in the regression tests
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1873385 13f79535-47bb-0310-9956-ffa450edef68
2020-01-30 21:09:17 +00:00
Dominik Stadler
366c80c480 Handle empty files correctly when looking for FileMagic to avoid NegativeArraySizeException
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1873232 13f79535-47bb-0310-9956-ffa450edef68
2020-01-27 22:54:15 +00:00
Andreas Beeker
8202a34d69 #64036 - Replace reflection calls in factories for Java 9+ - Escher factories
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1873187 13f79535-47bb-0310-9956-ffa450edef68
2020-01-26 19:50:40 +00:00
Andreas Beeker
0fb322bb92 #64088 - SlideShow rendering fixes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1872984 13f79535-47bb-0310-9956-ffa450edef68
2020-01-19 20:44:36 +00:00
PJ Fanning
b211a1362c use a few more lambdas
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1872644 13f79535-47bb-0310-9956-ffa450edef68
2020-01-12 11:04:21 +00:00
PJ Fanning
2797d07486 try to fix some jdk 14 build issues due to java.lang.Record causing existing POI Record classes to be ambiguous
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1872610 13f79535-47bb-0310-9956-ffa450edef68
2020-01-10 23:13:20 +00:00
PJ Fanning
9e7b0e899e reformat code
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1872568 13f79535-47bb-0310-9956-ffa450edef68
2020-01-09 21:24:31 +00:00
PJ Fanning
b594ec2947 [bug-63998] Support commas, exclamation marks correctly in AreaReference. Thanks to hzwhuang
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1872567 13f79535-47bb-0310-9956-ffa450edef68
2020-01-09 21:19:34 +00:00
Andreas Beeker
d1a714f5f1 findbugs fixes and refactor some ClassIDs
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1872473 13f79535-47bb-0310-9956-ffa450edef68
2020-01-07 22:46:29 +00:00
Tim Allison
e875bd8143 BUG 64015 -- swap out java.util.BitSet for zaxxer's SparseBitSet
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1872445 13f79535-47bb-0310-9956-ffa450edef68
2020-01-07 15:45:07 +00:00
Andreas Beeker
d66af200eb Sonar fixes - Tests should include assertions
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1872302 13f79535-47bb-0310-9956-ffa450edef68
2020-01-03 23:30:36 +00:00
PJ Fanning
5ec079072a [bug-64044] setCellValue(LocalDate) does not support nulls properly
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1872246 13f79535-47bb-0310-9956-ffa450edef68
2020-01-02 14:58:30 +00:00
Andreas Beeker
adb8424bc1 Fix Visio compression
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1872223 13f79535-47bb-0310-9956-ffa450edef68
2020-01-01 22:44:42 +00:00
Dominik Stadler
9f35db4f51 Bug 63940: Avoid endless loop/out of memory on string-replace with empty search string
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1872145 13f79535-47bb-0310-9956-ffa450edef68
2019-12-31 16:52:55 +00:00
Dominik Stadler
821e164041 Bug 63700: Make D* functions work with numeric result column
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1872136 13f79535-47bb-0310-9956-ffa450edef68
2019-12-31 10:41:43 +00:00
Dominik Stadler
3cc54a8dff Bug 63960: Write pre-evaluated string-values in formula cells with the correct type
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1872130 13f79535-47bb-0310-9956-ffa450edef68
2019-12-31 06:34:51 +00:00
Dominik Stadler
bc0dcdf369 Fix bug 63984: AND / OR should treat missing parameters as FALSE
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1872125 13f79535-47bb-0310-9956-ffa450edef68
2019-12-30 19:57:11 +00:00
Andreas Beeker
a0770034fc #64036 - remove reflective calls in Workbook- and SlideShowFactory
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1872066 13f79535-47bb-0310-9956-ffa450edef68
2019-12-28 22:39:26 +00:00
Andreas Beeker
c66575c1e7 Migrate all junit tests to Junit 4
get rid of references to junit.framework
don't throw AssertionFailedErrors, but use Assert.fail instead
add try-with-resources where it was missing

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1872041 13f79535-47bb-0310-9956-ffa450edef68
2019-12-27 23:00:13 +00:00
Andreas Beeker
7493473a8e Replace internal GUID class with ClassID
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1871944 13f79535-47bb-0310-9956-ffa450edef68
2019-12-24 19:48:22 +00:00
Andreas Beeker
66471836f5 Replace custom hashCode code with Objects.hash() / Arrays.deepHashCode()
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1871913 13f79535-47bb-0310-9956-ffa450edef68
2019-12-23 00:15:55 +00:00
Andreas Beeker
ba6152503e #64004 - Replace clone() with copy constructor - mainly HSSF classes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1871911 13f79535-47bb-0310-9956-ffa450edef68
2019-12-22 21:44:45 +00:00
Dominik Stadler
5e394a5e10 Let IntelliJ simplify some assertions
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1871591 13f79535-47bb-0310-9956-ffa450edef68
2019-12-15 14:53:46 +00:00
Dominik Stadler
1a5cec89d8 Replace manual close with try-with-resources
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1871590 13f79535-47bb-0310-9956-ffa450edef68
2019-12-15 14:53:11 +00:00
Dominik Stadler
2748844549 Bug 63749; Make getLastRowNum() and getFirstRow() return -1 instead of 0 on empty Sheets
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1871589 13f79535-47bb-0310-9956-ffa450edef68
2019-12-15 14:52:45 +00:00