39 Commits

Author SHA1 Message Date
Andreas Beeker
0783cdeb1f Remove references to DatatypeConverter
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1868953 13f79535-47bb-0310-9956-ffa450edef68
2019-10-25 20:00:52 +00:00
PJ Fanning
ecc4485e27 add stax entries to forbidden apis due to android issues
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1843009 13f79535-47bb-0310-9956-ffa450edef68
2018-10-06 09:38:58 +00:00
Andreas Beeker
555923c40b #62564 - replace Thread.currentThread().getContextClassLoader() with getClass().getClassLoader()
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1836590 13f79535-47bb-0310-9956-ffa450edef68
2018-07-24 22:57:18 +00:00
Andreas Beeker
f94245e9d8 #59893 - Forbid calls to InputStream.available
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1830400 13f79535-47bb-0310-9956-ffa450edef68
2018-04-27 21:38:19 +00:00
PJ Fanning
acc7b356ee add forbidden api checks for non-Locale toLowerCase and toUpperCase
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1815994 13f79535-47bb-0310-9956-ffa450edef68
2017-11-21 22:10:48 +00:00
PJ Fanning
936f29af69 add forbidden api checks for non-Locale toLowerCase and toUpperCase
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1815989 13f79535-47bb-0310-9956-ffa450edef68
2017-11-21 21:33:51 +00:00
Javen O'Neal
a4bc870e46 eventually we want to forbid StringBuffer usage
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1813875 13f79535-47bb-0310-9956-ffa450edef68
2017-10-31 11:10:08 +00:00
Javen O'Neal
a66725fa94 github-79: add String.toString() to forbidden API's
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812239 13f79535-47bb-0310-9956-ffa450edef68
2017-10-16 01:34:13 +00:00
Dominik Stadler
1b171e8642 Fix some findbugs-issues and apply some code-cleanup and apply some smaller pull requests.
This closes #74, This closes #75, This closes #76

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812097 13f79535-47bb-0310-9956-ffa450edef68
2017-10-13 09:40:22 +00:00
Dominik Stadler
9dfbbdb480 Fix some compilation warnings
Update Javadoc
Reformat code somewhat
Supress IntelliJ warnings in findbugs-filters.xml

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1776645 13f79535-47bb-0310-9956-ffa450edef68
2016-12-30 22:11:48 +00:00
Javen O'Neal
80e3a64280 bug 59781: ignore duplicate HSSF PaneInformation, which now shadows the Common SS version. The HSSF version has been deprecated and will be deleted after 2 releases
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751081 13f79535-47bb-0310-9956-ffa450edef68
2016-07-02 16:29:05 +00:00
Javen O'Neal
f31c1d72fc findbugs: fix SF_SWITCH_FALLTHROUGH warnings
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748088 13f79535-47bb-0310-9956-ffa450edef68
2016-06-13 06:12:35 +00:00
Javen O'Neal
2df9f76acf findbugs: fix URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD and UUF_UNUSED_FIELD warnings
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748086 13f79535-47bb-0310-9956-ffa450edef68
2016-06-13 05:34:02 +00:00
Javen O'Neal
288b0b46b9 findbugs: fix URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD warnings
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748085 13f79535-47bb-0310-9956-ffa450edef68
2016-06-13 05:06:47 +00:00
Javen O'Neal
a9c0342b1d findbugs: fix URF_UNREAD_FIELD warnings
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748084 13f79535-47bb-0310-9956-ffa450edef68
2016-06-13 04:42:59 +00:00
Javen O'Neal
8b8b75f547 consolidate findbugs filters using Or logic
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748081 13f79535-47bb-0310-9956-ffa450edef68
2016-06-13 04:09:41 +00:00
Javen O'Neal
b597097568 fix findbugs issues
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748080 13f79535-47bb-0310-9956-ffa450edef68
2016-06-13 03:48:30 +00:00
Andreas Beeker
0f89809206 ignore invalid performance issues - e.g. see #57840
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747947 13f79535-47bb-0310-9956-ffa450edef68
2016-06-12 01:18:12 +00:00
Javen O'Neal
d568d8b73c +props svn:eol-style native
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747846 13f79535-47bb-0310-9956-ffa450edef68
2016-06-11 04:27:21 +00:00
Dominik Stadler
79dafee3f3 Upgrade to FindBugs 3.0.1 and add some findbugs-excludes
Update to forbiddenapi-checker 2.1, use the newly provided rule-sets and remove things that were applied upstream 


git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1745366 13f79535-47bb-0310-9956-ffa450edef68
2016-05-24 14:17:52 +00:00
Dominik Stadler
6d92ee86ff Findbugs fixes
OldExcelExtractor could leak file handles in case of exceptions
Free file handles in POIFSDump, add unit-test for POIFSDump
Add a Findbugs exclude and adjust findbugs-ant slightly

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734689 13f79535-47bb-0310-9956-ffa450edef68
2016-03-12 11:37:12 +00:00
Andreas Beeker
0582072856 add other printStackTrace methods to forbidden-apis-check
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1723960 13f79535-47bb-0310-9956-ffa450edef68
2016-01-10 19:52:16 +00:00
Andreas Beeker
b15b18bae7 replace Throwable.printStackTrace() with POILogger calls - Todo: other printStrackTrace(...) calls
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1723899 13f79535-47bb-0310-9956-ffa450edef68
2016-01-10 02:20:35 +00:00
Andreas Beeker
b184105835 fix forbidden apis issues
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1719778 13f79535-47bb-0310-9956-ffa450edef68
2015-12-13 09:51:22 +00:00
Dominik Stadler
582ad34811 Add some additional rules for the forbidden-apis-check borrowed from Elasticsearch, also add a separate signature file with more rules for the 'prod' code and fix two newly found issues
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717689 13f79535-47bb-0310-9956-ffa450edef68
2015-12-02 21:47:52 +00:00
Andreas Beeker
b9c792dad0 close resources
fix a few eclipse warnings

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717077 13f79535-47bb-0310-9956-ffa450edef68
2015-11-29 15:26:53 +00:00
Uwe Schindler
01f4f63401 Fix remaining security manager problems. Forbiddenapis now passes.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1713915 13f79535-47bb-0310-9956-ffa450edef68
2015-11-11 19:11:35 +00:00
Dominik Stadler
7fb84618f6 Tried to add excelant to forbidden-apis-check, but failed due to issue #82 in forbidden-api-checks tool. List more pathes that we still not include. Add description to custom forbidden-api-checks and add commented out checks for reflectoin as discussed in bug 58597
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1713218 13f79535-47bb-0310-9956-ffa450edef68
2015-11-08 10:01:48 +00:00
Andreas Beeker
3be69f87f7 fixes sonar/findbugs issues
add Date.toString() to forbidden-apis and fix occurrences

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1712181 13f79535-47bb-0310-9956-ffa450edef68
2015-11-02 23:46:57 +00:00
Dustin Spicuzza
8a41cf7c40 Import poi-visio codebase
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1709354 13f79535-47bb-0310-9956-ffa450edef68
2015-10-19 05:52:35 +00:00
Andreas Beeker
a3d2eb57ff Bug 58326 - Forbidden APIs patches - first set of changes for locale and timezone settings
also includes fixes for
- name shadowing 
- unused deprecated method "getClipRect" in classes extending Graphics2d
- HexDump - replaced intermediate String.format calls with custom padding
- convert testcases to junit4
- closing resources

also tested with an arbitary timezone (PST) and locale (ru)

supresses forbidden apis check for
- LocaleUtil (the only place where Locale.getDefault() and TimeZone.getDefault() should be called)
- Classes using FontMetrics - without the actual text it's difficult to return something sane

Some usage of UTC and Locale.ROOT might be still wrong, e.g. in MapiMessage we don't access the
extended mapi properties, which might contain the timezone

DataFormatter has now a Observable property which need to be observed when custom formats are used
and the Locale changes

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1701688 13f79535-47bb-0310-9956-ffa450edef68
2015-09-07 20:19:50 +00:00
Andreas Beeker
bc5912e74d FindBugs fix
- fixed "Equals method should not assume anything about the type of its argument"
- see http://findbugs.sourceforge.net/bugDescriptions.html#BC_EQUALS_METHOD_SHOULD_WORK_FOR_ALL_OBJECTS

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1568861 13f79535-47bb-0310-9956-ffa450edef68
2014-02-16 23:36:32 +00:00
Andreas Beeker
334aaad728 FindBugs fix
- fixed "Field isn't final but should be"
- see http://findbugs.sourceforge.net/bugDescriptions.html#MS_SHOULD_BE_FINAL


git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1568145 13f79535-47bb-0310-9956-ffa450edef68
2014-02-13 23:34:11 +00:00
Andreas Beeker
ad8ded4b1d disable not applicable findbugs check
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1567815 13f79535-47bb-0310-9956-ffa450edef68
2014-02-13 00:07:36 +00:00
Mark Thomas
7abd94ba5c Add standard licence header for src/resources directory
git-svn-id: https://svn.apache.org/repos/asf/jakarta/poi/trunk@496531 13f79535-47bb-0310-9956-ffa450edef68
2007-01-15 22:55:27 +00:00
Avik Sengupta
f1f28aec02 update jindent file
git-svn-id: https://svn.apache.org/repos/asf/jakarta/poi/trunk@491759 13f79535-47bb-0310-9956-ffa450edef68
2007-01-02 08:21:56 +00:00
Nicola Ken Barozzi
48a94a3d0f Removed runtime dependency from commons logging.
Now the PoiLogFactory will try to create a logger using the System property
named "org.apache.poi.util.POILogger".

If it fails, the NullLogger is used.
There is also a basic SystemOutLogger and the former CommonsLogger.

Haven't checked the code that much, but it compiles and POI works.


git-svn-id: https://svn.apache.org/repos/asf/jakarta/poi/trunk@352672 13f79535-47bb-0310-9956-ffa450edef68
2002-06-11 21:07:58 +00:00
Nicola Ken Barozzi
6d39630e86 To make thing easier for users, I've changed now the default properties of log4j to output to null even when jog4j is present.
To override, one can use commoms logging env variables or simply replace src/java/log4j.properties with the one in src/resources/devtools, that works as usual for developers.


git-svn-id: https://svn.apache.org/repos/asf/jakarta/poi/trunk@352244 13f79535-47bb-0310-9956-ffa450edef68
2002-03-18 09:23:22 +00:00
Nicola Ken Barozzi
a612b0a28f Make POI use commons.logging, make log4j optional and clean structure to comply with, and use, Krysalis Centipede 2.0.1.
git-svn-id: https://svn.apache.org/repos/asf/jakarta/poi/trunk@352212 13f79535-47bb-0310-9956-ffa450edef68
2002-03-14 11:05:10 +00:00