233 Commits

Author SHA1 Message Date
Dominik Stadler
3116668737 Remove identical overriding method 2025-11-16 22:34:18 +01:00
Dominik Stadler
59e595b844 Remove some of the deprecated methods with @Removal("6.0.0")
We announced their removal for 6.0.0, so
we can remove them now as we plan a 6.0.0 release
next.

Some were not yet removed as they have still internal
usage or seem to need more work to finally remove.
2025-11-16 22:34:18 +01:00
Dominik Stadler
c6a621edc6 Remove deprecated methods with @Removal("5...")
We announced their removal already for 5.0.0 or 5.3.0, so
we can safely remove them now as we plan a 6.0.0 release
next.

Cell.setCellType() needs a closer look later as
it is not a simple deletion of code.
2025-11-16 22:34:18 +01:00
Dominik Stadler
cd22293975 Newer Mockito prevents using code from org.mockito.internal.matchers
At least locally tests fail now for me, so let's get rid of using
internal code here.
2025-11-16 14:18:06 +01:00
Dominik Stadler
d486e50822 Use OpenRewrite to update code to make use of Java 11 2025-11-16 14:18:06 +01:00
Dominik Stadler
207d67c12b Prevent a NullPointerException
The regression-corpus contains some documents which trigger this,
but succeed with the added null-check
2025-11-03 07:26:03 +01:00
PJ Fanning
559485a0fe throw OfficeXmlFileException if hwpf reads an ooxml file 2025-09-05 11:04:29 +01:00
PJ Fanning
2fbfe2ea7e Create TestHSLFParser.java 2025-09-05 10:45:07 +01:00
PJ Fanning
9f9ff14e56 add test 2025-08-28 13:00:54 +01:00
PJ Fanning
061d6a3d0f more parsers 2025-08-20 18:34:48 +01:00
PJ Fanning
a6f65db642 remove import
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1926415 13f79535-47bb-0310-9956-ffa450edef68
2025-06-14 14:15:47 +00:00
PJ Fanning
c01228c331 [bug-69697] HSLF getPictureData can return null for some pictures
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1926414 13f79535-47bb-0310-9956-ffa450edef68
2025-06-14 14:14:15 +00:00
PJ Fanning
378a0bed06 [bug-69669] refactor
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1925874 13f79535-47bb-0310-9956-ffa450edef68
2025-05-27 20:15:50 +00:00
PJ Fanning
16b53a8bc7 [bug-69669] try to share some code between the old code that I brought back and the newer code that caused the problems
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1925872 13f79535-47bb-0310-9956-ffa450edef68
2025-05-27 18:48:31 +00:00
PJ Fanning
d189f69333 remove temp test
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1925871 13f79535-47bb-0310-9956-ffa450edef68
2025-05-27 18:03:51 +00:00
PJ Fanning
35a6ae72be [bug-69669] revert some changes in HSLF placeholder creation due to issue with addTitle
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1925870 13f79535-47bb-0310-9956-ffa450edef68
2025-05-27 18:02:22 +00:00
PJ Fanning
67b0dc3966 try to avoid recreating HSLFShapePlaceholderDetails
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1925869 13f79535-47bb-0310-9956-ffa450edef68
2025-05-27 17:34:05 +00:00
PJ Fanning
c1dc0c6130 te
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1925864 13f79535-47bb-0310-9956-ffa450edef68
2025-05-27 11:56:43 +00:00
PJ Fanning
f298390ec3 code refactor
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1925649 13f79535-47bb-0310-9956-ffa450edef68
2025-05-17 16:46:23 +00:00
PJ Fanning
e867e371be typos (an)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1925440 13f79535-47bb-0310-9956-ffa450edef68
2025-05-06 20:12:35 +00:00
PJ Fanning
82aac8561f module-info (commons-collections)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1925237 13f79535-47bb-0310-9956-ffa450edef68
2025-04-23 19:22:55 +00:00
Dominik Stadler
0036655df4 ForbiddenApis: Adjust for deprecations in JDK 21+
Fix failures reported when raising the language level to 23
new URL() is deprecated
new Locale() is deprecated
still allow ThreadDeath and Thread.getId() for now to keep support for JDK 8

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1925199 13f79535-47bb-0310-9956-ffa450edef68
2025-04-21 12:07:21 +00:00
PJ Fanning
b3d0fe52d3 [bug-69628] more changes to getMax methods
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1924994 13f79535-47bb-0310-9956-ffa450edef68
2025-04-10 13:58:44 +00:00
PJ Fanning
7babbd11a6 reformat
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1924323 13f79535-47bb-0310-9956-ffa450edef68
2025-03-11 23:47:19 +00:00
PJ Fanning
af040998f4 fix spelling of separate
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1924321 13f79535-47bb-0310-9956-ffa450edef68
2025-03-11 23:44:59 +00:00
Dominik Stadler
80fd35198d Bug 66425: Avoid exceptions found via poi-fuzz
Prevent too deep nesting by throwing an exception
instead of just not parsing more nesting-levels as
this still caused OOMs.

Allow to adjust the limit via static setter as elsewhere
to give users a chance to parse very complicated files
if really necessary.

https://issues.oss-fuzz.com/issues/42528505

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1923277 13f79535-47bb-0310-9956-ffa450edef68
2025-01-20 18:40:32 +00:00
Dominik Stadler
86c0db4be1 Bug 58805: Adjust reproducer test-case some more
Do not write a local temp-file
It seems even parsing the resulting document fails

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1923063 13f79535-47bb-0310-9956-ffa450edef68
2025-01-11 10:09:01 +00:00
Dominik Stadler
6befe2ad52 Bug 66425: Avoid exceptions found via poi-fuzz
Prevent a NullPointerException

Fixes https://issues.oss-fuzz.com/issues/42537720

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1923061 13f79535-47bb-0310-9956-ffa450edef68
2025-01-11 09:24:20 +00:00
Dominik Stadler
534d24dc74 Add test for bug 58805
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1923055 13f79535-47bb-0310-9956-ffa450edef68
2025-01-11 09:23:50 +00:00
Dominik Stadler
ae9355dcf4 Bug 57603: Apply suggested patch
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1923052 13f79535-47bb-0310-9956-ffa450edef68
2025-01-11 09:23:35 +00:00
Dominik Stadler
c1f52674fd Bug 69315: HSMF: At least continue processing properties after multivalued properties
Currently processing stops at multivalued properties.

This at least continues processing, so other properties are processed properly.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1923051 13f79535-47bb-0310-9956-ffa450edef68
2025-01-11 09:23:29 +00:00
Dominik Stadler
1d5497f2c3 Adjust format for DE on JDK 23+ some more
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1922680 13f79535-47bb-0310-9956-ffa450edef68
2024-12-25 08:13:18 +00:00
Dominik Stadler
d7ca791ace Apply some spelling fixes from GitHub PR #480
Some suggested changes are too invasive so we
can only pick some changes semi-automatically

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1922678 13f79535-47bb-0310-9956-ffa450edef68
2024-12-25 08:13:10 +00:00
Dominik Stadler
b92a912e7d Adjust some more for JDK 23/24
There are more date-formats which need to be
defined manually for the German locale now
to work without the COMPAT locale provider
in JDK 23+

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1922518 13f79535-47bb-0310-9956-ffa450edef68
2024-12-15 15:24:09 +00:00
Dominik Stadler
be83ccf2ef Adjust for removed locale provider in JDK 23 and newer
JDK 23 removes the COMPAT/JRE locale provider
which causes some changes to string formatting

Default German data format changed and thus we
need to introduce a custom format.

Also the US format uses some non-breaking spaces now
which we need to handle properly in tests.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1922506 13f79535-47bb-0310-9956-ffa450edef68
2024-12-15 11:40:02 +00:00
PJ Fanning
924d8e7894 PoiLogManager
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1922055 13f79535-47bb-0310-9956-ffa450edef68
2024-11-24 19:48:55 +00:00
Dominik Stadler
c1f018f79c Apply some IDE suggestions, JavaDoc and GitHub PR
Update assertion-message
Adjust JavaDoc
Add tests
Reformat class DirectoryNode, adjust/move some comments

Closes #730

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1921980 13f79535-47bb-0310-9956-ffa450edef68
2024-11-20 20:29:38 +00:00
PJ Fanning
e132050d2e add since tags
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1921801 13f79535-47bb-0310-9956-ffa450edef68
2024-11-06 20:56:45 +00:00
Tim Allison
157512d437 [bug-69434] -- add more properties to AttachmentChunks
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1921800 13f79535-47bb-0310-9956-ffa450edef68
2024-11-06 20:45:12 +00:00
PJ Fanning
9185ec02c5 immutable maps
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1921575 13f79535-47bb-0310-9956-ffa450edef68
2024-10-26 16:34:40 +00:00
PJ Fanning
822974aadc make static maps final
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1921340 13f79535-47bb-0310-9956-ffa450edef68
2024-10-15 16:33:15 +00:00
Dominik Stadler
0dea4a301c Bug 66425: Avoid exceptions found via poi-fuzz
Processing formats uses regular expressions. Very complex formats
can recurse very deeply and thus can cause StackOVerflows depending
on the used stack-size.

In order to handle this a bit more gracefully, we now catch this
and report a better exception with details about the parsed 
format and potential mitigation.

Fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=66137

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1919342 13f79535-47bb-0310-9956-ffa450edef68
2024-07-18 07:09:32 +00:00
Dominik Stadler
09fbfd5be4 Bug 66425: Avoid exceptions found via poi-fuzz
Avoid a possible OutOfMemoryException with many child-records

This avoids having too many children in EscherRecords, the limit of
100_000 is arbitrarily chosen and can be adjusted if needed  

Fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=62924 and maybe others

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1919272 13f79535-47bb-0310-9956-ffa450edef68
2024-07-16 05:26:42 +00:00
Dominik Stadler
2582e5e0c1 Bug 66425: Avoid exceptions found via poi-fuzz
Avoid a possible StackOverflowException

This adds support of counting of the "nesting level" into the base 
EscherRecord and thus makes this existing limitation much more effective
as it kicks in for more types of nested records. 

Fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=66374

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1919256 13f79535-47bb-0310-9956-ffa450edef68
2024-07-15 13:02:43 +00:00
Dominik Stadler
719e7154a1 Optimize generating numbers for bullets in Word
Using char[] instead of String improves performance of this
operation considerably, especially in JDK 11+ where StringBuilder
was switched to work on bytes instead of chars.

This is likely only relevant for very large documents, it was visible
in a synthetic test-file from fuzzing.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1919239 13f79535-47bb-0310-9956-ffa450edef68
2024-07-15 05:41:14 +00:00
Dominik Stadler
a971751238 Reformat and add more tests
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1919238 13f79535-47bb-0310-9956-ffa450edef68
2024-07-15 05:41:10 +00:00
Dominik Stadler
e2044c958b Bug 66425: Avoid exceptions found via poi-fuzz
Prevent too much memory usage

Fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=67413

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1919237 13f79535-47bb-0310-9956-ffa450edef68
2024-07-15 05:41:04 +00:00
PJ Fanning
7e86ff1bb0 use standard ASF header
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1918804 13f79535-47bb-0310-9956-ffa450edef68
2024-07-01 23:06:36 +00:00
PJ Fanning
f56eea8e45 BoundedInputStream deprecation warnings
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1918175 13f79535-47bb-0310-9956-ffa450edef68
2024-06-05 16:31:36 +00:00
Dominik Stadler
3f243f65ab Change one exception to warning-log to avoid regressions in mass-tests
This avoids "breaking" a few documents which could be opened before.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1918118 13f79535-47bb-0310-9956-ffa450edef68
2024-06-02 11:31:31 +00:00