2668 Commits

Author SHA1 Message Date
Javen O'Neal
b72e9510e5 bug 59791: improve Cell.CELL_TYPE_* backwards compatibility
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1757235 13f79535-47bb-0310-9956-ffa450edef68
2016-08-22 17:57:45 +00:00
Nick Burch
5b4f46e180 Whitespace, javadocs and @Overrides for the Logger classes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1755192 13f79535-47bb-0310-9956-ffa450edef68
2016-08-04 14:23:54 +00:00
Nick Burch
a57e5b7b93 Switch XSSF onto BaseFormulaEvaluator, reducing code duplication and fixing XSSFFormulaEvaluator.evaluateAll() to mirror HSSF and use any setup referenced workbooks (stackoverflow #38706562)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1755079 13f79535-47bb-0310-9956-ffa450edef68
2016-08-03 11:53:43 +00:00
Nick Burch
8578dfe70a Refactor out some of the common FormulaEvaluator logic from HSSF to a base class (XSSF coming shortly)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1755070 13f79535-47bb-0310-9956-ffa450edef68
2016-08-03 11:42:04 +00:00
Nick Burch
b61ed84a8f Whitespace / indents
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1755068 13f79535-47bb-0310-9956-ffa450edef68
2016-08-03 11:15:13 +00:00
Nick Burch
07dc4cecc4 Whitespace / indents
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1755066 13f79535-47bb-0310-9956-ffa450edef68
2016-08-03 11:12:50 +00:00
Javen O'Neal
5b5d4c6777 whitespace
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1754782 13f79535-47bb-0310-9956-ffa450edef68
2016-08-01 17:36:06 +00:00
David North
22623b78bc Fix zero-padding and handling of empty passwords (meaning protection on, but no password to remove it) for XSSF workbook protection.
https://bz.apache.org/bugzilla/show_bug.cgi?id=59920

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1754744 13f79535-47bb-0310-9956-ffa450edef68
2016-08-01 12:51:24 +00:00
Javen O'Neal
ff55ea0bd1 javadoc fix: incorrect deprecated replacement
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1754702 13f79535-47bb-0310-9956-ffa450edef68
2016-08-01 05:32:41 +00:00
Mark Murphy
c1d12f4dc0 revert changes made in r1754691
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1754700 13f79535-47bb-0310-9956-ffa450edef68
2016-08-01 04:21:14 +00:00
Mark Murphy
7e9ba83c24 correction to junit bugs in r1754691
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1754698 13f79535-47bb-0310-9956-ffa450edef68
2016-08-01 02:53:55 +00:00
Nick Burch
378dbebea8 Javadoc fixes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1754694 13f79535-47bb-0310-9956-ffa450edef68
2016-08-01 00:17:33 +00:00
Mark Murphy
5ec21e741d Add new class Cell Style Template and supporting enum for drawing borders
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1754691 13f79535-47bb-0310-9956-ffa450edef68
2016-07-31 23:59:02 +00:00
Dominik Stadler
1f15f25cb8 Bug 59736: Incorrect evaluation of SUBTOTAL with composite interval
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1754674 13f79535-47bb-0310-9956-ffa450edef68
2016-07-31 17:19:27 +00:00
David North
aa17ae0b1e Introduce name-based methods for access to named ranges in a workbook, and deprecate the old index-based methods.
Re-organise internally to use a map so that lookup is O(1) rather than O(n ranges).

Add a dependency on commons collections 4, also ASL licensed so no problem.

https://bz.apache.org/bugzilla/show_bug.cgi?id=59734

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1754521 13f79535-47bb-0310-9956-ffa450edef68
2016-07-29 13:24:00 +00:00
Dominik Stadler
8a506399cd Bug 59634: Clarify and refine JavaDoc of various close() methods to consistently state that close() invalidates the object
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753912 13f79535-47bb-0310-9956-ffa450edef68
2016-07-24 11:38:50 +00:00
Nick Burch
6d59eef6e4 Provide a createOrUpdateDocument method at the POIFS level, and use to simplify writing code #57919
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753739 13f79535-47bb-0310-9956-ffa450edef68
2016-07-21 23:09:07 +00:00
Nick Burch
48f255f37e Javadoc updates
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753659 13f79535-47bb-0310-9956-ffa450edef68
2016-07-21 10:27:27 +00:00
Nick Burch
b25e988d94 If doing an in-place write, update the properties too
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753623 13f79535-47bb-0310-9956-ffa450edef68
2016-07-20 23:31:57 +00:00
Nick Burch
2d44399e0b #57919 HPSF writing better error handling, and start prep for HSLF more write methods
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753621 13f79535-47bb-0310-9956-ffa450edef68
2016-07-20 23:09:33 +00:00
Nick Burch
efb790ef95 #57919 Add in-place and new-File write methods to POIDocument
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753619 13f79535-47bb-0310-9956-ffa450edef68
2016-07-20 22:35:51 +00:00
Nick Burch
fcee96add1 Prepare for pushing write() and write(File) to POIDocument
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753595 13f79535-47bb-0310-9956-ffa450edef68
2016-07-20 18:41:27 +00:00
Nick Burch
fcf3162b54 Sync the file-based "past-the-end" exception to match the stream one, so that extending works, then tests for HSSF writing to a new empty POIFS file #57919
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753489 13f79535-47bb-0310-9956-ffa450edef68
2016-07-20 12:01:36 +00:00
Nick Burch
551ca753ca Start on unit testing for HSSFWorkbook.write(File), bug in POIFS to fix first
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753487 13f79535-47bb-0310-9956-ffa450edef68
2016-07-20 11:14:05 +00:00
Nick Burch
40591cf09a #57919 Start on support for writing to a new File (faster than OutputStream)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753486 13f79535-47bb-0310-9956-ffa450edef68
2016-07-20 11:07:29 +00:00
Javen O'Neal
035b4c4a0a bug 59881: fix D* functions for blank cells in headers in database; patch from Patrick Zimmermann
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753346 13f79535-47bb-0310-9956-ffa450edef68
2016-07-19 08:02:41 +00:00
Javen O'Neal
3873d84f46 bug 59881: fix spelling; patch from Patrick Zimmermann
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753298 13f79535-47bb-0310-9956-ffa450edef68
2016-07-18 18:25:28 +00:00
Dominik Stadler
b43fbeffe6 52122: Excel does not handle conditional formatting based on formula correctly unless recalculation is forced
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753199 13f79535-47bb-0310-9956-ffa450edef68
2016-07-18 10:32:55 +00:00
Dominik Stadler
b8523ef596 Some warnings/improvements suggested by IntelliJ
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753188 13f79535-47bb-0310-9956-ffa450edef68
2016-07-18 09:34:59 +00:00
Dominik Stadler
33d5189ff9 59106: WorkdayFunction does not read the area with holidays correctly to calculate work days
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753125 13f79535-47bb-0310-9956-ffa450edef68
2016-07-17 21:18:27 +00:00
Dominik Stadler
736962f26a Fix one more place where stream were left open when an exception is thrown
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753123 13f79535-47bb-0310-9956-ffa450edef68
2016-07-17 21:18:12 +00:00
Dominik Stadler
8924e1260b Fix some IntelliJ and Findbugs warnings: StringBuilder, foreach, append(), ...
test-updates

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753122 13f79535-47bb-0310-9956-ffa450edef68
2016-07-17 21:18:07 +00:00
Javen O'Neal
7d7b67fef6 only calculate getTextHeight if it will be used
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753115 13f79535-47bb-0310-9956-ffa450edef68
2016-07-17 20:33:32 +00:00
Javen O'Neal
d2053bb4f2 reduce statement complexity in drawContent, also has fewer FLOPS
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753114 13f79535-47bb-0310-9956-ffa450edef68
2016-07-17 20:29:34 +00:00
Javen O'Neal
c965f02c60 if ever combined, VerticalAlignment and HorizontalAlignment would likely end up at org.apache.poi.common.usermodel
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753113 13f79535-47bb-0310-9956-ffa450edef68
2016-07-17 20:27:57 +00:00
Javen O'Neal
bf53115645 bug 57919: add performance note to javadocs about using BufferedOutputStreams on Document.write(OutputStream) if underlying resource is high latency
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753112 13f79535-47bb-0310-9956-ffa450edef68
2016-07-17 20:25:37 +00:00
Nick Burch
9376bdf27f #57919 Provide an initial in-place write method for HSSFWorkbook
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753103 13f79535-47bb-0310-9956-ffa450edef68
2016-07-17 19:02:58 +00:00
Javen O'Neal
6e7bba8cac bug 58190: push down XMLSlideShow tests to BaseTestSlideShow, add coverage for HSLFSlideShow
add tests for SlideShow.findPicture and SlideShow.addPicture

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753073 13f79535-47bb-0310-9956-ffa450edef68
2016-07-17 13:25:02 +00:00
Javen O'Neal
5d0b2fa59f bug 59873: add @Internal and @Deprecated decorators to HyperlinkType enum
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753062 13f79535-47bb-0310-9956-ffa450edef68
2016-07-17 11:56:13 +00:00
Javen O'Neal
09681e86ab HexDump.writeHex is similar to Long#toHexString. Consider consolidating.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753050 13f79535-47bb-0310-9956-ffa450edef68
2016-07-17 10:22:43 +00:00
Javen O'Neal
a0ba3f5924 bug 59873: javadoc fix
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753043 13f79535-47bb-0310-9956-ffa450edef68
2016-07-17 09:48:36 +00:00
Javen O'Neal
ed944416da bug 59783: replace deprecated Hyperlink.LINK_* and Hyperlink.getType usage
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753040 13f79535-47bb-0310-9956-ffa450edef68
2016-07-17 09:32:29 +00:00
Dominik Stadler
3805d00888 Bug 59665: Using HSSFWorkbook#setSheetOrder to move sheets to the end corrupts bspos value in WorkbookRecordList
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753038 13f79535-47bb-0310-9956-ffa450edef68
2016-07-17 09:27:07 +00:00
Javen O'Neal
9816a7ccd8 bug 59873: replace Hyperlink.LINK_* int constants with HyperlinkType enum
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753035 13f79535-47bb-0310-9956-ffa450edef68
2016-07-17 09:20:21 +00:00
Javen O'Neal
202dfbf92e make private maps final
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753018 13f79535-47bb-0310-9956-ffa450edef68
2016-07-17 07:29:40 +00:00
Javen O'Neal
0de74b143e add @Override annotations to CreationHelper classes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753017 13f79535-47bb-0310-9956-ffa450edef68
2016-07-17 07:14:49 +00:00
Javen O'Neal
55bc4619d5 bug 59872: add @since annotation to Sheet#getHyperlink(CellAddress)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753015 13f79535-47bb-0310-9956-ffa450edef68
2016-07-17 05:47:03 +00:00
Javen O'Neal
dcf43f75bd bug 59872: add Sheet.getHyperlink(CellAddress)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753009 13f79535-47bb-0310-9956-ffa450edef68
2016-07-17 04:41:20 +00:00
Dominik Stadler
2348794109 Apply patch to fix bug 59740: Sheet.shiftRows incorrectly shifts merged region on exists merged region
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752997 13f79535-47bb-0310-9956-ffa450edef68
2016-07-16 20:52:39 +00:00
Javen O'Neal
f7fa4f4384 replace for-loop over index with for-each loop
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752788 13f79535-47bb-0310-9956-ffa450edef68
2016-07-15 07:41:26 +00:00