85 Commits

Author SHA1 Message Date
PJ Fanning
bd1d31e410 avoid string concats
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1884573 13f79535-47bb-0310-9956-ffa450edef68
2020-12-17 21:42:19 +00:00
PJ Fanning
a42127e15b remove more deprecated code
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1884259 13f79535-47bb-0310-9956-ffa450edef68
2020-12-09 16:59:51 +00:00
Andreas Beeker
a73348fe8b Update library versions
Replace deprecated junit @Rules with assertThrows
Adapt to XMLSec refactoring in version 2.2.0

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1880965 13f79535-47bb-0310-9956-ffa450edef68
2020-08-18 13:50:31 +00:00
Andreas Beeker
a4c370f913 sonar fixes - use assert in junit tests
use try-with-resources
remove obsolete and renamed OPOIFS references
add logic to unit tests which just opened a file, by rewriting it and some formula evaluation logic

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1872397 13f79535-47bb-0310-9956-ffa450edef68
2020-01-06 21:48:00 +00:00
Andreas Beeker
8a9af96f95 remove obsolete JDK6 workarounds
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1866863 13f79535-47bb-0310-9956-ffa450edef68
2019-09-12 20:05:24 +00:00
Dominik Stadler
cd52566c98 Bug 63073: Adjust returned index of merged regions and verify all calls in tests
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1858021 13f79535-47bb-0310-9956-ffa450edef68
2019-04-23 20:27:39 +00:00
Vladislav Galas
a8a0cb56f7 purged usages of Cell.setCellType (left only in tests, where conversions are tested)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1852247 13f79535-47bb-0310-9956-ffa450edef68
2019-01-26 19:41:36 +00:00
Vladislav Galas
39d963aa33 made call Cell.setCellType(CellType.FORMULA) illegall. Deprecated Cell.setCellType(). Purged all redundant calls from project.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1852246 13f79535-47bb-0310-9956-ffa450edef68
2019-01-26 19:41:25 +00:00
Dominik Stadler
db14c353fc Fix some Findbugs and IDE issues, refactor some duplicated code,
improve some exception texts, add comment for missing Ptg for SxName

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1851210 13f79535-47bb-0310-9956-ffa450edef68
2019-01-13 17:14:24 +00:00
Dominik Stadler
2b8200f7d7 Bug 61532: Fix setting values/types during formula evaluation for SXSSF
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849880 13f79535-47bb-0310-9956-ffa450edef68
2018-12-28 19:53:03 +00:00
PJ Fanning
05b0de574c [bug-62018] use ints to index fonts
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1824826 13f79535-47bb-0310-9956-ffa450edef68
2018-02-20 00:25:43 +00:00
Dominik Stadler
2dc64ebbcc adjust tests, javadoc, ...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1811865 13f79535-47bb-0310-9956-ffa450edef68
2017-10-11 18:31:34 +00:00
Dominik Stadler
bd5a1fb7a6 Adjust some unit-tests, use try-with-resource, enable test which works now, ...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1809739 13f79535-47bb-0310-9956-ffa450edef68
2017-09-26 12:40:38 +00:00
Tim Allison
9efbfd9d7d 60805 (partial) -- remove/suppress println in tests
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808903 13f79535-47bb-0310-9956-ffa450edef68
2017-09-19 15:52:21 +00:00
PJ Fanning
6382370552 update getCellType to return CellType enum instead of int
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808718 13f79535-47bb-0310-9956-ffa450edef68
2017-09-18 13:58:55 +00:00
PJ Fanning
bc0c0b19d2 update getCellType to return CellType enum instead of int
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808700 13f79535-47bb-0310-9956-ffa450edef68
2017-09-18 13:26:16 +00:00
Dominik Stadler
0cfa1ede4c Remove unnecessary type arguments (Java 8)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808516 13f79535-47bb-0310-9956-ffa450edef68
2017-09-16 08:27:23 +00:00
PJ Fanning
95d9bec68b Remove more deprecated code (especially from Spreadsheet Cell classes)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1800375 13f79535-47bb-0310-9956-ffa450edef68
2017-06-30 11:48:23 +00:00
Andreas Beeker
3cf6c40004 fix eclipse warnings - close resources / type generics
cleanup sources - add parenthesis to statements

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1778955 13f79535-47bb-0310-9956-ffa450edef68
2017-01-15 23:08:47 +00:00
Dominik Stadler
f8040a4c41 Fix newly introduced Sonar issues and allow text to be null
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1771563 13f79535-47bb-0310-9956-ffa450edef68
2016-11-27 11:06:57 +00:00
Dominik Stadler
3bda549d79 Bug 60370: Encode some special characters when setting title/text for validation text-boxes, for now all characters below 32, more can be added if necessary.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1771396 13f79535-47bb-0310-9956-ffa450edef68
2016-11-25 22:07:59 +00:00
Dominik Stadler
909467c2a6 Bug 59200: Check for actual Excel limits on data validation title/text
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1771254 13f79535-47bb-0310-9956-ffa450edef68
2016-11-25 08:55:52 +00:00
Javen O'Neal
efac70434a reenable unit test for bug 58648 that passes now
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1765548 13f79535-47bb-0310-9956-ffa450edef68
2016-10-19 08:03:57 +00:00
Javen O'Neal
af4678d45e bug 60197: Workbook#setSheetOrder should update named range sheet indices
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1763939 13f79535-47bb-0310-9956-ffa450edef68
2016-10-09 03:02:13 +00:00
Dominik Stadler
e6a2d46800 Compiler/IDE warnings, unnecessary keywords,
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1761675 13f79535-47bb-0310-9956-ffa450edef68
2016-09-21 05:45:57 +00:00
Javen O'Neal
5d97d4c0e2 change CellValue#getCellType() to return an int instead of an enum for backwards compatibility (source and binary) with POI 3.14. This reverts the behavior introduced in POI 3.15 beta 3 in r1751237.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760607 13f79535-47bb-0310-9956-ffa450edef68
2016-09-13 23:24:56 +00:00
Dominik Stadler
07b249db81 Bug 55384: Handle setting pre-evaluation string correctly in SXSSF as well
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1754328 13f79535-47bb-0310-9956-ffa450edef68
2016-07-27 18:15:54 +00:00
Javen O'Neal
04be2bb235 bug 59791: FormulaEvaluator#evaluateFormulaCell(Cell) should return an integer for backwards compatibility
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751261 13f79535-47bb-0310-9956-ffa450edef68
2016-07-04 12:21:42 +00:00
Javen O'Neal
5582593ad1 bug 59791: getCellType and getCachedFormulaResultType should return an integer for backwards compatibility
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751256 13f79535-47bb-0310-9956-ffa450edef68
2016-07-04 11:54:20 +00:00
Javen O'Neal
fb8c79d96c bug 59791: convert Cell Type to an enum
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751237 13f79535-47bb-0310-9956-ffa450edef68
2016-07-04 09:45:46 +00:00
Javen O'Neal
11bea18184 bug 59781: promote to Common SS: move PaneInformation from o.a.p.hssf.util to o.a.p.ss.util
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751044 13f79535-47bb-0310-9956-ffa450edef68
2016-07-02 09:00:13 +00:00
Javen O'Neal
8b0d1f7321 bug 57929: add disabled unit test, adapted from nova
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749270 13f79535-47bb-0310-9956-ffa450edef68
2016-06-20 07:15:09 +00:00
Javen O'Neal
cf08abe4ed fix spelling error
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747659 13f79535-47bb-0310-9956-ffa450edef68
2016-06-10 07:45:31 +00:00
Dominik Stadler
bb7c632559 Fix some Sonar issues and some IntelliJ warnings
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1746627 13f79535-47bb-0310-9956-ffa450edef68
2016-06-02 20:14:28 +00:00
Dominik Stadler
bde09054f0 Try to reproduce bug 57798 but it seems to be fixed in the meantime
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1746624 13f79535-47bb-0310-9956-ffa450edef68
2016-06-02 20:09:35 +00:00
Javen O'Neal
260c6ed57f add disabled unit test for bug 59393 from stone
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1742868 13f79535-47bb-0310-9956-ffa450edef68
2016-05-09 03:49:16 +00:00
Javen O'Neal
266daec8a4 bug 58896: write autoSizeColumn timing to POILogger instead of standard output
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1739584 13f79535-47bb-0310-9956-ffa450edef68
2016-04-17 11:36:50 +00:00
Dominik Stadler
a90762bdc5 Fix some cases where POI itself or the tests leaked file-handles
Also fix some IntelliJ warnings

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734690 13f79535-47bb-0310-9956-ffa450edef68
2016-03-12 11:37:22 +00:00
Javen O'Neal
36ae29751d bug 58896: comment out time-dependent test
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1731101 13f79535-47bb-0310-9956-ffa450edef68
2016-02-18 17:53:13 +00:00
Javen O'Neal
865bf1d24f move trackColumnsForAutoSizingIfSXSSF into ITestDataProvider, replace ITestDataProvider.trackColumnsForAutosizing(Sheet, int...) with ITestDataProvider.trackAllColumnsForAutosizing(Sheet) to avoid cluttering unit tests with specific columns that will be autosized
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1730999 13f79535-47bb-0310-9956-ffa450edef68
2016-02-18 04:05:45 +00:00
Javen O'Neal
2ffd1d9dd5 bug 58896: add unit test to time Sheet.autoSizeColumn
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1730997 13f79535-47bb-0310-9956-ffa450edef68
2016-02-18 03:33:25 +00:00
Dominik Stadler
8cbb571d9c Add test which verifies that bug 52684 is not a problem (any more)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1730948 13f79535-47bb-0310-9956-ffa450edef68
2016-02-17 21:35:22 +00:00
Nick Burch
6f46cd95be Fix #57034 on SXSSF, and add a common unit test to show it was already fixed on the others + is now fixed for SXSSF
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1729849 13f79535-47bb-0310-9956-ffa450edef68
2016-02-11 15:13:40 +00:00
Javen O'Neal
e29279896e patch from Stefan Thurnherr: bug 57450: autosize columns in SXSSF using rows that have been flushed to disk
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1717146 13f79535-47bb-0310-9956-ffa450edef68
2015-11-30 00:22:50 +00:00
Javen O'Neal
109e8b4fb3 javadocs
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1716811 13f79535-47bb-0310-9956-ffa450edef68
2015-11-27 09:45:53 +00:00
Javen O'Neal
04a9af4527 add failing unit test for bug 58648
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1716338 13f79535-47bb-0310-9956-ffa450edef68
2015-11-25 09:19:03 +00:00
Javen O'Neal
3febf6600a fix for bug 51622: autosize columns with leading whitespace
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1712477 13f79535-47bb-0310-9956-ffa450edef68
2015-11-04 06:39:57 +00:00
Javen O'Neal
a586e413fb bug 58576: rename canComputeColumnWidht to canComputeColumnWidth
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1712219 13f79535-47bb-0310-9956-ffa450edef68
2015-11-03 07:23:09 +00:00
Javen O'Neal
ba765160c4 fix typos
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1712213 13f79535-47bb-0310-9956-ffa450edef68
2015-11-03 06:03:52 +00:00
Javen O'Neal
6456105e37 bug 58443: prevent corrupted workbooks by checking for overlapping merged regions before adding a merged region to a sheet; fix unit tests that produced corrupt workbooks; remove deprecated HSSFSheet#addMergedRegion(Region)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711586 13f79535-47bb-0310-9956-ffa450edef68
2015-10-31 10:22:19 +00:00