Javen O'Neal
bfa21bc5fa
bug 59729: update CellRangeUtil
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749243 13f79535-47bb-0310-9956-ffa450edef68
2016-06-20 00:55:51 +00:00
Javen O'Neal
a1156bc7ba
whitespace (tabs to spaces)
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749241 13f79535-47bb-0310-9956-ffa450edef68
2016-06-20 00:28:19 +00:00
Javen O'Neal
7e7b5b09c2
mv o.a.p.hssf.record.cf.CellRangeUtil o.a.p.ss.util.CellRangeUtil
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749240 13f79535-47bb-0310-9956-ffa450edef68
2016-06-20 00:25:29 +00:00
Javen O'Neal
8ee07a27f5
bug 56454: add CellRangeAddress#containsRow and containsColumn
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749239 13f79535-47bb-0310-9956-ffa450edef68
2016-06-20 00:16:41 +00:00
Andreas Beeker
5be01c04f4
findbugs fixes
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749238 13f79535-47bb-0310-9956-ffa450edef68
2016-06-20 00:08:11 +00:00
Javen O'Neal
c3c26ffdf3
bug 56958: replace java.awt.Rectangle#intersects with native implementation to determine if CellRangeAddresses intersect; patch from Yaniv Kunda
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749226 13f79535-47bb-0310-9956-ffa450edef68
2016-06-19 23:02:43 +00:00
Andreas Beeker
550ccec962
Regression fixes
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749224 13f79535-47bb-0310-9956-ffa450edef68
2016-06-19 22:43:24 +00:00
Javen O'Neal
93ed98da08
bug 56958: slightly improve performance when checking array formulas
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749219 13f79535-47bb-0310-9956-ffa450edef68
2016-06-19 22:24:17 +00:00
Nick Burch
78c9a8e2c2
#59724 Take advantage of all POIDocument classes being Closeable to tidy the OLE2 text extractor closing
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749214 13f79535-47bb-0310-9956-ffa450edef68
2016-06-19 22:13:41 +00:00
Nick Burch
fb80ba4949
#59724 Provide Closeable on all OLE2-based POIDocument types
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749213 13f79535-47bb-0310-9956-ffa450edef68
2016-06-19 22:12:55 +00:00
Javen O'Neal
a15ca7acfc
bug 56958: patch from Yaniv Kunda: check that cells containing array formulas do not belong to a merged region
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749210 13f79535-47bb-0310-9956-ffa450edef68
2016-06-19 22:00:44 +00:00
Javen O'Neal
9a769fcb0b
bug 59645: add Page Setup Print row and column headings support for Common SS
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749191 13f79535-47bb-0310-9956-ffa450edef68
2016-06-19 18:20:23 +00:00
Javen O'Neal
41517168f9
update javadoc for clarification about non-literal lists
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749133 13f79535-47bb-0310-9956-ffa450edef68
2016-06-19 06:23:57 +00:00
Andreas Beeker
23baf09e91
findbugs fixes - ME_MUTABLE_ENUM_FIELD
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1749116 13f79535-47bb-0310-9956-ffa450edef68
2016-06-19 01:06:55 +00:00
Javen O'Neal
752eda425d
add unit test for HSSFWorkbook.getSelectedTabs
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748899 13f79535-47bb-0310-9956-ffa450edef68
2016-06-18 02:37:24 +00:00
Javen O'Neal
f982913bb1
bug 59718: deprecate get/setBoldweight. Use get/setBold
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748898 13f79535-47bb-0310-9956-ffa450edef68
2016-06-18 01:21:08 +00:00
Javen O'Neal
172ac0be60
bug 59170: Removed deprecated methods in POIFS, SS, HSSF, and XSSF
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748897 13f79535-47bb-0310-9956-ffa450edef68
2016-06-18 01:06:53 +00:00
Javen O'Neal
a662902974
FunctionEval is a utility class. It should not have a public default constructor
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748830 13f79535-47bb-0310-9956-ffa450edef68
2016-06-17 10:47:13 +00:00
Javen O'Neal
3984215fbd
bug 59279: add Comment.equals and hashCode methods
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748814 13f79535-47bb-0310-9956-ffa450edef68
2016-06-17 08:56:10 +00:00
Javen O'Neal
c4d5eb82b8
move loop invariant outside of loop
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748809 13f79535-47bb-0310-9956-ffa450edef68
2016-06-17 07:59:01 +00:00
Javen O'Neal
e9e07e4d2c
bug 59170: add version when deprecated
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748793 13f79535-47bb-0310-9956-ffa450edef68
2016-06-17 02:35:44 +00:00
Javen O'Neal
211b50b2e1
bug 59170: deprecate o.a.p.hssf.model.PictureShape
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748792 13f79535-47bb-0310-9956-ffa450edef68
2016-06-17 02:31:27 +00:00
Javen O'Neal
0d929dbc09
bug 55385: deprecate Font.getBoldweight and Font.setBoldweight
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748658 13f79535-47bb-0310-9956-ffa450edef68
2016-06-16 06:51:53 +00:00
Javen O'Neal
367a78a40b
fix javadocs @link error for removed o.a.p.hssf.util.CellRangeAddress
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748496 13f79535-47bb-0310-9956-ffa450edef68
2016-06-15 04:32:17 +00:00
Javen O'Neal
bc583de03b
bug 59170: remove deprecated methods
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748483 13f79535-47bb-0310-9956-ffa450edef68
2016-06-15 03:26:58 +00:00
Javen O'Neal
4bebb8f816
bug 59170: remove deprecated methods in o.a.p.hpsf.wellknown.SectionIDMap
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748481 13f79535-47bb-0310-9956-ffa450edef68
2016-06-15 02:48:23 +00:00
Javen O'Neal
39a4223b2c
bug 59170: remove deprecated hpsf.Constants class
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748480 13f79535-47bb-0310-9956-ffa450edef68
2016-06-15 02:47:04 +00:00
Javen O'Neal
10b0e8a3d8
remove RegionUtil reference
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748473 13f79535-47bb-0310-9956-ffa450edef68
2016-06-14 21:57:38 +00:00
Andreas Beeker
77a9e8d4b0
javadoc fixes (jdk8)
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748328 13f79535-47bb-0310-9956-ffa450edef68
2016-06-13 23:08:13 +00:00
Andreas Beeker
821f94a3dc
reverted changes of r1747942 and deprecated instead
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748313 13f79535-47bb-0310-9956-ffa450edef68
2016-06-13 21:18:50 +00:00
Javen O'Neal
632a02c423
back out changes for bug 58787: will replae BorderPropertyTemplate with a more general CellStyleTemplate in the future
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748293 13f79535-47bb-0310-9956-ffa450edef68
2016-06-13 18:12:29 +00:00
Javen O'Neal
b53be78aed
Sonar: 'static modifier out of order with the JLS suggestions.remove No need to check for null before an instanceof; the instanceof keyword returns false when given a null argument.
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748175 13f79535-47bb-0310-9956-ffa450edef68
2016-06-13 10:55:49 +00:00
Javen O'Neal
e29bf52845
add HSSFCell.setCachedErrorResult(FormulaError)
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748174 13f79535-47bb-0310-9956-ffa450edef68
2016-06-13 10:53:03 +00:00
Javen O'Neal
1f913e2a20
type check error code when setting cell error value on HSSFCell
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748172 13f79535-47bb-0310-9956-ffa450edef68
2016-06-13 10:29:38 +00:00
Javen O'Neal
c5117bccda
add periods for complete sentences
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748166 13f79535-47bb-0310-9956-ffa450edef68
2016-06-13 09:51:01 +00:00
Nick Burch
9352d5dc1f
Javadoc fixes
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748158 13f79535-47bb-0310-9956-ffa450edef68
2016-06-13 09:39:36 +00:00
Nick Burch
58a977f884
Javadoc fixes - @see and @link can't be combined together, at least not in Java 6
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748157 13f79535-47bb-0310-9956-ffa450edef68
2016-06-13 09:38:12 +00:00
Javen O'Neal
b37f023157
improve unit test coverage on CellReference.
...
Add note that _sheetName can be null or empty string, depending on the entry-point.
Throw an exception when parsing a string if sheet name is not quoted and contains a space.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748144 13f79535-47bb-0310-9956-ffa450edef68
2016-06-13 08:58:55 +00:00
Javen O'Neal
2662ad6c88
fix accidental infinite recursion
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748143 13f79535-47bb-0310-9956-ffa450edef68
2016-06-13 08:55:41 +00:00
Javen O'Neal
2d133bd37e
bug 58787: add an advertisement to BorderPropertyTemplate.
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748110 13f79535-47bb-0310-9956-ffa450edef68
2016-06-13 07:44:29 +00:00
Javen O'Neal
74b8c88ed2
bug 58787 follow-on: update javadocs; remove unused Workbook parameter from set(Top|Bottom|Left|Right)Border and BorderColor methods
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748107 13f79535-47bb-0310-9956-ffa450edef68
2016-06-13 07:40:20 +00:00
Javen O'Neal
899430d944
whitespace (tabs to spaces)
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748105 13f79535-47bb-0310-9956-ffa450edef68
2016-06-13 07:27:18 +00:00
Javen O'Neal
442c7c7209
findbugs URF_UNREAD_FIELD: note that unread fields were commented out in r1748084 due to a Findbugs warnings (so the disabled code is less likely to be deleted in the future
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748098 13f79535-47bb-0310-9956-ffa450edef68
2016-06-13 07:02:33 +00:00
Javen O'Neal
abb3591635
findbugs: fix SF_SWITCH_NO_DEFAULT warnings
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748090 13f79535-47bb-0310-9956-ffa450edef68
2016-06-13 06:38:53 +00:00
Javen O'Neal
f31c1d72fc
findbugs: fix SF_SWITCH_FALLTHROUGH warnings
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748088 13f79535-47bb-0310-9956-ffa450edef68
2016-06-13 06:12:35 +00:00
Javen O'Neal
a9c0342b1d
findbugs: fix URF_UNREAD_FIELD warnings
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748084 13f79535-47bb-0310-9956-ffa450edef68
2016-06-13 04:42:59 +00:00
Javen O'Neal
b597097568
fix findbugs issues
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748080 13f79535-47bb-0310-9956-ffa450edef68
2016-06-13 03:48:30 +00:00
Javen O'Neal
0fae3bcb08
bug 58787: reintegrate changes from ss_border_property_template branch at r1748074. The BorderPropertyTemplate allows changes to border formatting to be staged in a template and applied to a sheet at a later time. This reduces the number of intermediate styles created, reduces interactions with cell objects (CellUtil.get/setCellProperties), and makes it easier to make the same formatting changes to multiple sheets. This utility can currently apply border line style and border color. This utility also adds the ability to add a border around a cell range rather than a single cell. Contributed by Mark Murphy.
...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748075 13f79535-47bb-0310-9956-ffa450edef68
2016-06-13 01:25:50 +00:00
Javen O'Neal
286e650c2a
rename drawBorders(..., short color, ...) to drawColoredBorders to make it obvious that method changes border line style and color
...
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1748074 13f79535-47bb-0310-9956-ffa450edef68
2016-06-13 01:00:51 +00:00
Javen O'Neal
02fd3e4fd8
add copy constructor
...
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1748072 13f79535-47bb-0310-9956-ffa450edef68
2016-06-13 00:43:34 +00:00