686 Commits

Author SHA1 Message Date
Dominik Stadler
25d67aa6ec Do not fail if an empty password is provided
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1907446 13f79535-47bb-0310-9956-ffa450edef68
2023-02-05 21:11:14 +00:00
Dominik Stadler
1ca2e638ed Bug 66436: Fix invalid handling of padded encrypted bytes
The encrypted data is padded to 16 bytes, but these additional bytes
were not read from the stream

Make the reading of the additional bytes "lenient" to not introduce
breaking change if some existing functionality did produce non-aligned
data for some reason.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1907444 13f79535-47bb-0310-9956-ffa450edef68
2023-02-05 21:11:03 +00:00
PJ Fanning
43551babf1 [bug-65260] partial revert of recent changes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1907443 13f79535-47bb-0310-9956-ffa450edef68
2023-02-05 20:34:19 +00:00
PJ Fanning
040181c42f [bug-65260] catch Throwable instead of error - see https://github.com/apache/poi/pull/425
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1907308 13f79535-47bb-0310-9956-ffa450edef68
2023-02-04 15:10:32 +00:00
PJ Fanning
34f6955a28 mark some variables that are used in synchronized code as volatile
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1907114 13f79535-47bb-0310-9956-ffa450edef68
2023-01-30 14:46:43 +00:00
Dominik Stadler
6f606cabda Spotbugs: Replace \n with %n in String.format()
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1907110 13f79535-47bb-0310-9956-ffa450edef68
2023-01-30 12:19:43 +00:00
Dominik Stadler
bcd3785d7d Use an error-handler to use logging also for XML parsing errors
Otherwise this output is done to stdout/stderr which we would like to avoid.

Keep the format as one line and do not include a full exception stacktrace
to not introduce lots of exception-stacktraces for some slightly broken input files

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1907108 13f79535-47bb-0310-9956-ffa450edef68
2023-01-30 12:19:37 +00:00
Dominik Stadler
edc7f8fd6f Bug 54373: Include alpha/transparency value when creating an XSSFColor from an AWT Color object
Use the alpha-value from Color as well

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1907106 13f79535-47bb-0310-9956-ffa450edef68
2023-01-30 12:19:31 +00:00
PJ Fanning
60872927bd [bug-66433] Boolean functions should blank cells. Thanks to Patrick Böker
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1906836 13f79535-47bb-0310-9956-ffa450edef68
2023-01-20 12:03:52 +00:00
PJ Fanning
25bb01ac14 revert ant upgrade due to issues with ant-launcher-1.10.13.jar
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1906570 13f79535-47bb-0310-9956-ffa450edef68
2023-01-10 20:59:59 +00:00
PJ Fanning
786af03e67 add test case
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1906561 13f79535-47bb-0310-9956-ffa450edef68
2023-01-10 20:10:25 +00:00
PJ Fanning
16cddb4dd4 upgrade ant
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1906557 13f79535-47bb-0310-9956-ffa450edef68
2023-01-10 19:44:37 +00:00
PJ Fanning
5c964e4194 [bug-66413] try to fix HSSF code where you can set fill colors
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1906451 13f79535-47bb-0310-9956-ffa450edef68
2023-01-07 22:24:49 +00:00
PJ Fanning
968dabd462 [bug-65543] HSSF: fix issue with incomplete SSTs. Thanks to Simon Carter.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1906434 13f79535-47bb-0310-9956-ffa450edef68
2023-01-06 23:50:54 +00:00
Dominik Stadler
c8c06d1ec0 Saxon-HE is included in more place, combine these into the main gradle build
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1906427 13f79535-47bb-0310-9956-ffa450edef68
2023-01-06 19:58:45 +00:00
Dominik Stadler
4c1f59d85c Testing with saxon-HE: Avoid module-clash between xml.apis and java.xml
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1906425 13f79535-47bb-0310-9956-ffa450edef68
2023-01-06 17:41:28 +00:00
Dominik Stadler
1ff1e84e4a Avoid some NullPointerException and ClassCastExceptions found when fuzzing Apache POI
This mostly only makes thrown runtime-exceptions a bit more consistent and
improves information in exceptions.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1906360 13f79535-47bb-0310-9956-ffa450edef68
2023-01-03 19:52:03 +00:00
Dominik Stadler
5724a77cf2 Avoid some NullPointerExceptions and ClassCastExceptions found when fuzzing Apache POI
This mostly only makes thrown exceptions a bit more consistent
or may allow some broken documents to be still read.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1906322 13f79535-47bb-0310-9956-ffa450edef68
2023-01-01 15:59:32 +00:00
Dominik Stadler
83bb4b4da5 Rename method for color from "RBG" to "RGB"
It's a protected method that is not intended to be used
outside anyway.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1906276 13f79535-47bb-0310-9956-ffa450edef68
2022-12-30 08:11:38 +00:00
PJ Fanning
537dc7a933 [github-409] Textruns not honouring highlight. Thans to gffloodg. This closes #409
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1906250 13f79535-47bb-0310-9956-ffa450edef68
2022-12-28 17:56:26 +00:00
PJ Fanning
37994bf3e2 [github-409] Textruns not honouring highlight. Thans to gffloodg. This closes #409
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1906248 13f79535-47bb-0310-9956-ffa450edef68
2022-12-28 17:45:21 +00:00
PJ Fanning
1def0cba38 [bug-66397] update temp file code. Thanks to lsq27.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1906238 13f79535-47bb-0310-9956-ffa450edef68
2022-12-28 08:08:09 +00:00
PJ Fanning
78516f50dc try to get rid of cached module-info classes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1906232 13f79535-47bb-0310-9956-ffa450edef68
2022-12-27 18:45:15 +00:00
Dominik Stadler
7ba2f0fffa Bug 66401: Handle escaped single-quote in formulas properly
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1906217 13f79535-47bb-0310-9956-ffa450edef68
2022-12-26 16:15:39 +00:00
PJ Fanning
5e212e4a33 doesn't matter what jdk vendor is used to build module-info classes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1906212 13f79535-47bb-0310-9956-ffa450edef68
2022-12-26 10:05:10 +00:00
PJ Fanning
8898d2d15a try to fix build
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1906208 13f79535-47bb-0310-9956-ffa450edef68
2022-12-26 00:24:29 +00:00
PJ Fanning
edee60d87a rebuild module-info.class files even if Java8 used
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1906207 13f79535-47bb-0310-9956-ffa450edef68
2022-12-25 23:56:32 +00:00
PJ Fanning
1494812da8 try to build sboms
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1906146 13f79535-47bb-0310-9956-ffa450edef68
2022-12-21 17:52:29 +00:00
PJ Fanning
b8d4597ea4 cyclonedx per module
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1906134 13f79535-47bb-0310-9956-ffa450edef68
2022-12-21 11:23:43 +00:00
PJ Fanning
7e2f2bbbfb revert accidental change to multiply/divide
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1906013 13f79535-47bb-0310-9956-ffa450edef68
2022-12-15 12:10:02 +00:00
PJ Fanning
2a34e5a31e upgrade mockito and byte-buddy
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1906012 13f79535-47bb-0310-9956-ffa450edef68
2022-12-15 12:06:39 +00:00
PJ Fanning
693c59574c [bug-66319] do not create HSSF patriarch to find comments (only use one that pre-exists)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1905943 13f79535-47bb-0310-9956-ffa450edef68
2022-12-12 21:09:09 +00:00
PJ Fanning
1b4e8ba77b remove unnecessary short casts for getCellStyleAt
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1905938 13f79535-47bb-0310-9956-ffa450edef68
2022-12-12 18:14:49 +00:00
PJ Fanning
e9aa298e1e [github-405] more performant codepoint util code. Thanks to StanBertrand. This closes #405
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1905932 13f79535-47bb-0310-9956-ffa450edef68
2022-12-12 14:59:35 +00:00
PJ Fanning
6d0dbe6f95 [bug-66181] support VALUE function where input is a blank cell
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1905308 13f79535-47bb-0310-9956-ffa450edef68
2022-11-14 17:41:21 +00:00
Dominik Stadler
56d47448ce Adjust tests, comments, JavaDoc, IDE suggestions
Add more output for a flaky test which sometimes fails on very slow hardware

Shutdown in tests gracefully
Otherwise an NPE may "hide" a test-failure

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1905273 13f79535-47bb-0310-9956-ffa450edef68
2022-11-13 19:22:13 +00:00
PJ Fanning
46ae0a8c60 [bug-66337] do not warn about missing SummaryInformation when creating new HSSFWorkbooks. Thanks to Nicolas Herzog.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1905045 13f79535-47bb-0310-9956-ffa450edef68
2022-11-03 11:47:34 +00:00
PJ Fanning
52968d92da update javadoc
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1905029 13f79535-47bb-0310-9956-ffa450edef68
2022-11-02 19:26:57 +00:00
PJ Fanning
a806f69af1 jdk8 build issue
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1904914 13f79535-47bb-0310-9956-ffa450edef68
2022-10-29 08:52:46 +00:00
PJ Fanning
9798625cb9 jdk19 build issue
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1904908 13f79535-47bb-0310-9956-ffa450edef68
2022-10-28 23:10:54 +00:00
PJ Fanning
ba1e8de446 [bug-66312] partial fix for insertNewParagraph(XmlCursor cursor)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1904563 13f79535-47bb-0310-9956-ffa450edef68
2022-10-13 10:38:31 +00:00
PJ Fanning
2d5d60cb2d add ABS test
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1904531 13f79535-47bb-0310-9956-ffa450edef68
2022-10-11 18:11:02 +00:00
PJ Fanning
acd5d04daa [bug-66278] Bug with multiple gradient stops at the exact same location causing a rendering failure (AWT -> not enough colors in gradient). Thanks to Gareth Floodgate. This closes #385
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1904301 13f79535-47bb-0310-9956-ffa450edef68
2022-09-27 12:09:11 +00:00
PJ Fanning
06e2213ac1 lgtm issues
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1904092 13f79535-47bb-0310-9956-ffa450edef68
2022-09-15 17:31:50 +00:00
PJ Fanning
e23d96a6ad try to use IllegalStateException instead of RuntimeException
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1904066 13f79535-47bb-0310-9956-ffa450edef68
2022-09-14 09:55:02 +00:00
PJ Fanning
6e7f6dad21 try to use IllegalStateException instead of RuntimeException
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1904065 13f79535-47bb-0310-9956-ffa450edef68
2022-09-14 09:54:24 +00:00
PJ Fanning
59b16f025b try to use IllegalStateException instead of RuntimeException
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1904050 13f79535-47bb-0310-9956-ffa450edef68
2022-09-14 01:12:38 +00:00
PJ Fanning
34601b5377 some lgtm issues
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1904048 13f79535-47bb-0310-9956-ffa450edef68
2022-09-13 23:38:12 +00:00
PJ Fanning
e485bf0b65 add CellUtil test
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1903837 13f79535-47bb-0310-9956-ffa450edef68
2022-09-02 22:54:03 +00:00
PJ Fanning
ff2e90e9a5 rework CellUtil test
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1903836 13f79535-47bb-0310-9956-ffa450edef68
2022-09-02 22:40:21 +00:00