7947 Commits

Author SHA1 Message Date
PJ Fanning
cf5b72bc00 some more checks for int overflows
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1857609 13f79535-47bb-0310-9956-ffa450edef68
2019-04-15 23:10:04 +00:00
PJ Fanning
c56ebe15af use ArithmeticUtils for calculations that might overflow
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1857596 13f79535-47bb-0310-9956-ffa450edef68
2019-04-15 16:02:53 +00:00
PJ Fanning
3c7bb45e54 use ArithmeticUtils for calculations that might overflow
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1857594 13f79535-47bb-0310-9956-ffa450edef68
2019-04-15 15:45:59 +00:00
Dominik Stadler
8823c1a9ab Add missing license header
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1857483 13f79535-47bb-0310-9956-ffa450edef68
2019-04-13 17:19:05 +00:00
PJ Fanning
924b2c546b [bug-63344] add TempFilePOIFSFileSystem
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1857462 13f79535-47bb-0310-9956-ffa450edef68
2019-04-13 10:08:55 +00:00
PJ Fanning
bdc3b391fd [bug-63344] add TempFilePOIFSFileSystem
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1857461 13f79535-47bb-0310-9956-ffa450edef68
2019-04-13 10:03:02 +00:00
PJ Fanning
fb5d21b1bb adjust formatting
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1857452 13f79535-47bb-0310-9956-ffa450edef68
2019-04-13 08:08:36 +00:00
Tim Allison
cf76af521d Bug 63330 -- use skipfully instead of hoping skip() works
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1857277 13f79535-47bb-0310-9956-ffa450edef68
2019-04-10 19:11:02 +00:00
Greg Woolsey
362a99a60b Update site source for 4.1.0, prep build for 4.1.1 (via ant task)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1857217 13f79535-47bb-0310-9956-ffa450edef68
2019-04-09 15:57:25 +00:00
Andreas Beeker
3a6c933020 Remove invalid import
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1857141 13f79535-47bb-0310-9956-ffa450edef68
2019-04-08 21:09:55 +00:00
Tim Allison
a5278ccad9 bug 63327 allow retrieval of wmf data embedded in emf
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1857136 13f79535-47bb-0310-9956-ffa450edef68
2019-04-08 19:53:21 +00:00
Tim Allison
ad11a5d363 Bug 63323 -- improve handling of multibyte characters
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1857135 13f79535-47bb-0310-9956-ffa450edef68
2019-04-08 19:51:16 +00:00
Dominik Stadler
6119c0ecec Fix a flaky test, it seems if the document is not closed, the automatic
closing of file-handles interferes with subsequent tests, by closing the
document this flakiness seems to be gone.

Flakiness could be reproduced locally by continuously running test with IntelliJ
"run until failure" run-config option and after aprox. 17,000 test-executions!

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1857068 13f79535-47bb-0310-9956-ffa450edef68
2019-04-07 07:17:47 +00:00
Dominik Stadler
b88c6b12e5 Improve error message slightly and verify error when a File is passed in
as "Object"

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1857067 13f79535-47bb-0310-9956-ffa450edef68
2019-04-07 07:17:41 +00:00
Dominik Stadler
9b726e88b7 Close more file-handles in tests and convert some more tests to junit-4
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1857066 13f79535-47bb-0310-9956-ffa450edef68
2019-04-07 07:17:34 +00:00
PJ Fanning
b523186038 try to fix javadoc issues
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1856994 13f79535-47bb-0310-9956-ffa450edef68
2019-04-05 09:18:26 +00:00
Dominik Stadler
e6c3dd9350 Fix some IDE warnings and enable commented test
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1856691 13f79535-47bb-0310-9956-ffa450edef68
2019-03-31 19:29:52 +00:00
Dominik Stadler
0e69c64a62 Add some more variants of HTML with preceding newline which we see frequently
in the large regression test corpus

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1856689 13f79535-47bb-0310-9956-ffa450edef68
2019-03-31 19:29:42 +00:00
Dominik Stadler
097fd7a5e2 Close more file-handles in tests, convert junit3 tests
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1856688 13f79535-47bb-0310-9956-ffa450edef68
2019-03-31 19:29:34 +00:00
PJ Fanning
9576ab77f9 replace version number 4.0.2
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1856665 13f79535-47bb-0310-9956-ffa450edef68
2019-03-31 08:54:44 +00:00
Greg Woolsey
48ac6b4d02 fix a condition not seen until a recent expansion of the stress test. Gracefully ignore missing/invalid external sheet references in one more path (there were several already with comments like "this seems to be what Excel does in this case")
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1856655 13f79535-47bb-0310-9956-ffa450edef68
2019-03-31 03:49:16 +00:00
Greg Woolsey
389946bb31 fix unit test that I merged wrong.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1856653 13f79535-47bb-0310-9956-ffa450edef68
2019-03-31 01:12:10 +00:00
Greg Woolsey
6b76706ef7 #61700 getForceFormulaRecalculation() returns wrong value
changed to use the proper OOXML attribute instead of a hack about calculation engine version ID.  Reporter was right, the behavior was wrong in some cases, but it turns out the fix was a bit more.  See issue for details.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1856652 13f79535-47bb-0310-9956-ffa450edef68
2019-03-31 01:00:05 +00:00
PJ Fanning
b9101138bd [bug-61700] getForceFormulaRecalculation() returns wrong value. Fix thanks to Kai G
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1856650 13f79535-47bb-0310-9956-ffa450edef68
2019-03-30 23:59:19 +00:00
PJ Fanning
5d580f48e6 fix build issue
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1856649 13f79535-47bb-0310-9956-ffa450edef68
2019-03-30 21:57:50 +00:00
Greg Woolsey
67aad69757 #63292 1904 date windowing flag not used for some format cases
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1856648 13f79535-47bb-0310-9956-ffa450edef68
2019-03-30 20:13:24 +00:00
Greg Woolsey
0d22749477 #63291 CellFormat global cache isn't thread-safe
move date format synchronization down to where the problem instance is held. 

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1856647 13f79535-47bb-0310-9956-ffa450edef68
2019-03-30 19:33:02 +00:00
Greg Woolsey
30851e44a6 #63302 Formula evaluation of names with offset or row function is incorrect
thanks to John Lincoln White for the patch, including new unit tests.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1856644 13f79535-47bb-0310-9956-ffa450edef68
2019-03-30 18:14:14 +00:00
PJ Fanning
2a9390d683 [bug-63291] support concurrent date formatting with same DataFormatter
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1856449 13f79535-47bb-0310-9956-ffa450edef68
2019-03-27 23:04:40 +00:00
PJ Fanning
80dc4b34c9 add test for concurrent use of DataFormatter
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1856439 13f79535-47bb-0310-9956-ffa450edef68
2019-03-27 21:24:25 +00:00
PJ Fanning
905c53794c [github-142] issue in ExcelComparator example. Thanks to chirkovmail. This close #142
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1856053 13f79535-47bb-0310-9956-ffa450edef68
2019-03-22 13:38:05 +00:00
PJ Fanning
259d5a234f upgrade xmlsec, slf4j, batik
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1855990 13f79535-47bb-0310-9956-ffa450edef68
2019-03-21 13:43:19 +00:00
PJ Fanning
d66873a765 upgrade bouncycastle and curvesapi
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1855978 13f79535-47bb-0310-9956-ffa450edef68
2019-03-21 10:23:05 +00:00
PJ Fanning
c18b7245e9 possible npe in test
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1855969 13f79535-47bb-0310-9956-ffa450edef68
2019-03-21 09:20:00 +00:00
PJ Fanning
92232b921a remove unncessary synchronization
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1855956 13f79535-47bb-0310-9956-ffa450edef68
2019-03-20 23:41:29 +00:00
PJ Fanning
895b251367 some javadoc issues
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1855954 13f79535-47bb-0310-9956-ffa450edef68
2019-03-20 23:33:50 +00:00
PJ Fanning
cb9d33d53d use xmlbeans-3.0.3 rc version
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1855952 13f79535-47bb-0310-9956-ffa450edef68
2019-03-20 23:16:13 +00:00
Dominik Stadler
bb73949f7b Switch to parameterized test and add some more information to try to find
out why this test fails from time to time

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1855874 13f79535-47bb-0310-9956-ffa450edef68
2019-03-19 21:55:33 +00:00
Dominik Stadler
40f8d119c7 Remove more remnants of NPOIFSFileSystem, mostly in comments and variable names
This avoids confusion if people look at this code in the future without knowledge
about the historical transition from java.io to java.nio

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1855873 13f79535-47bb-0310-9956-ffa450edef68
2019-03-19 21:55:26 +00:00
PJ Fanning
f2d9c1a927 [bug-63268] fix issue where CellUtil.setFont is adding unnecessary styles
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1855806 13f79535-47bb-0310-9956-ffa450edef68
2019-03-19 05:59:00 +00:00
Greg Woolsey
edd1f4c75e pre-release maintenance:
* add my key to the KEYS file
* update year in NOTICE (first release of 2019)
* remove svn:executable flag from random test data files

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1855799 13f79535-47bb-0310-9956-ffa450edef68
2019-03-19 00:35:09 +00:00
Greg Woolsey
1dbcef88f9 Fix a unit test that changed with the implementation of another function.
Didn't fail for me because I hadn't noticed the Eclipse classpath was out of date wrt some dependency versions, and therefore my local code was not compiling properly, meaning my test run ran old code and passed this one when it should have failed.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1855792 13f79535-47bb-0310-9956-ffa450edef68
2019-03-18 22:05:34 +00:00
Greg Woolsey
82f9c29258 #60724 - Partial implementation for SUBTOTAL() 'ignore hidden rows' variations
The function still doesn't deal with auto-filtering, but it now handles variations that should skip hidden rows.

Taught the evaluation framework to know about hidden rows similar to what was already there for skipping subtotals within subtotal ranges.

Added unit test cases.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1855789 13f79535-47bb-0310-9956-ffa450edef68
2019-03-18 19:09:11 +00:00
Andreas Beeker
19005a4e63 Fix forbidden apis error
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1855672 13f79535-47bb-0310-9956-ffa450edef68
2019-03-16 20:44:12 +00:00
Andreas Beeker
aa438b6f2d Use JPG source, otherwise we have problems with Alpha conversion in OpenJDK.
https://stackoverflow.com/questions/3432388/imageio-not-able-to-write-a-jpeg-file

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1855668 13f79535-47bb-0310-9956-ffa450edef68
2019-03-16 20:13:55 +00:00
Yegor Kozlov
6ef332b48e Bug 61472: Convert date/time strings to numbers when evaluating formulas
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1855662 13f79535-47bb-0310-9956-ffa450edef68
2019-03-16 15:41:46 +00:00
Greg Woolsey
ee83ce5fcd Handle possible invalid date value (#61652)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1855627 13f79535-47bb-0310-9956-ffa450edef68
2019-03-16 06:55:16 +00:00
Greg Woolsey
8225326b56 #63264 Conditional Format rule evaluation calculates relative references incorrectly
Fixing the offset calculation and passing the top-left-most region rather than the region matching the current cell fixed these cases.  I've augmented unit tests to check for them to avoid future regressions.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1855619 13f79535-47bb-0310-9956-ffa450edef68
2019-03-16 00:27:13 +00:00
PJ Fanning
126606c838 fix some cases where iterator usage does not check hasNext
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1855480 13f79535-47bb-0310-9956-ffa450edef68
2019-03-14 04:01:10 +00:00
Dominik Stadler
7f12edf416 Fix URL for test
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1855155 13f79535-47bb-0310-9956-ffa450edef68
2019-03-10 16:13:02 +00:00