1774 Commits

Author SHA1 Message Date
Dominik Stadler
d9bf061db7 Bug 56315: Make rounding in MathX.round() behave equal to Excel, adjust/enhance some more tests in MathX
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1588538 13f79535-47bb-0310-9956-ffa450edef68
2014-04-18 18:20:15 +00:00
Nick Burch
3c3e164a50 Rather than having lots of classes all create their own XML DocumentBuilderFactory instance, push that logic to a helper which sets all the right defaults
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1587739 13f79535-47bb-0310-9956-ffa450edef68
2014-04-15 21:59:52 +00:00
Cédric Walter
b9a9ac8556 performance issue: call toString() on a String object. This is entirely redundant.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1583358 13f79535-47bb-0310-9956-ffa450edef68
2014-03-31 16:01:39 +00:00
Cédric Walter
e684262ca6 performance issue logging calls are expensive because of the objects created when assembling the log messages. Using the check() method of the logging sub-system can prevent object creation
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1583357 13f79535-47bb-0310-9956-ffa450edef68
2014-03-31 15:54:52 +00:00
Nick Burch
60801c5017 Patch from bug #56328 from David North - the maximum row number in a formula depends on HSSF vs XSSF
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1582892 13f79535-47bb-0310-9956-ffa450edef68
2014-03-28 21:54:30 +00:00
Nick Burch
f22a576ce5 Patch from Shaun Kalley from bug #56023 - On CellReference, implement hashCode, fix the equals(Object) logic, and fix inconsistent whitespace
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1575683 13f79535-47bb-0310-9956-ffa450edef68
2014-03-09 09:49:06 +00:00
Dominik Stadler
b9cd5ca769 Adjust for JDK 8 where an empty locale is added to the array returned by DateFormat.getAvailableLocales()
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1575563 13f79535-47bb-0310-9956-ffa450edef68
2014-03-08 16:46:59 +00:00
Dominik Stadler
71b2a63699 Fix Sonar issues about finalize() usage
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1575501 13f79535-47bb-0310-9956-ffa450edef68
2014-03-08 08:41:25 +00:00
Andreas Beeker
ea67d54243 Added MD4-option and some cleanups
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1574732 13f79535-47bb-0310-9956-ffa450edef68
2014-03-06 00:53:09 +00:00
Nick Burch
0c38315f31 POI is now on JDK 1.6, so remove 1.5 workaround
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1574049 13f79535-47bb-0310-9956-ffa450edef68
2014-03-04 11:57:44 +00:00
Andreas Beeker
fd8ad223a7 Bug 56076 - Add document protection with password support to XWPF
Bug 56077 - Add password hash function to HWPF

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1570750 13f79535-47bb-0310-9956-ffa450edef68
2014-02-21 23:19:57 +00:00
Andreas Beeker
bc5912e74d FindBugs fix
- fixed "Equals method should not assume anything about the type of its argument"
- see http://findbugs.sourceforge.net/bugDescriptions.html#BC_EQUALS_METHOD_SHOULD_WORK_FOR_ALL_OBJECTS

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1568861 13f79535-47bb-0310-9956-ffa450edef68
2014-02-16 23:36:32 +00:00
Nick Burch
220b263830 Patch and test from Jon Iles from bug #56138 - HPSF code page strings can be zero length
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1568813 13f79535-47bb-0310-9956-ffa450edef68
2014-02-16 19:35:55 +00:00
Andreas Beeker
019f40493b FindBugs fix
- fixed/checked various null pointer related entries
- see http://findbugs.sourceforge.net/bugDescriptions.html#NP_NULL_PARAM_DEREF
- ... NP_NULL_ON_SOME_PATH, NP_NULL_ON_SOME_PATH_EXCEPTION


git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1568789 13f79535-47bb-0310-9956-ffa450edef68
2014-02-16 16:30:24 +00:00
Dominik Stadler
a264f7c3c3 Instead of using initCause() when re-throwing exceptions, it leads to better stacktraces if a simple constructor-argument is used
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1568614 13f79535-47bb-0310-9956-ffa450edef68
2014-02-15 10:43:58 +00:00
Dominik Stadler
240579a854 Update Javadoc somewhat
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1568555 13f79535-47bb-0310-9956-ffa450edef68
2014-02-15 00:19:32 +00:00
Andreas Beeker
2e6de07eb1 FindBugs fix
- fixed "Should be a static inner class"
- see http://findbugs.sourceforge.net/bugDescriptions.html#SIC_INNER_SHOULD_BE_STATIC


git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1568178 13f79535-47bb-0310-9956-ffa450edef68
2014-02-14 01:00:45 +00:00
Andreas Beeker
334aaad728 FindBugs fix
- fixed "Field isn't final but should be"
- see http://findbugs.sourceforge.net/bugDescriptions.html#MS_SHOULD_BE_FINAL


git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1568145 13f79535-47bb-0310-9956-ffa450edef68
2014-02-13 23:34:11 +00:00
Andreas Beeker
4b9d47af5a FindBugs fix
- fixed "Class defines equals() and uses Object.hashCode()"
- see http://findbugs.sourceforge.net/bugDescriptions.html#HE_EQUALS_USE_HASHCODE
- implemented UnicodeString.ExtRst.hashCode() + junit-test

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1566427 13f79535-47bb-0310-9956-ffa450edef68
2014-02-09 21:19:20 +00:00
Nick Burch
2f635a7498 Fix whitespace
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1563660 13f79535-47bb-0310-9956-ffa450edef68
2014-02-02 16:44:30 +00:00
Nick Burch
63d4dc462f Add setIncludeHeadersFooters(boolean) to the ExcelExtractor common interface, as all implementations now have the method
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1563658 13f79535-47bb-0310-9956-ffa450edef68
2014-02-02 16:41:27 +00:00
Nick Burch
ba910a4584 Have the Excel text extractors all implement the same interface, as best as they can
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1563650 13f79535-47bb-0310-9956-ffa450edef68
2014-02-02 16:23:26 +00:00
Andreas Beeker
e484fd75d0 Bug 51891 - Fix StringIndexOutOfBoundsException : Ole10Native.<init> (parsing word file)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1563483 13f79535-47bb-0310-9956-ffa450edef68
2014-02-01 21:45:48 +00:00
Andreas Beeker
a6736fda98 jdk 5 compiler doesn't support overwrite for interfaces ...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1561406 13f79535-47bb-0310-9956-ffa450edef68
2014-01-25 21:56:08 +00:00
Nick Burch
4405461d5b Patch from Detlef Brendle from bug #55873 - Support for COUNTIFS function
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1560736 13f79535-47bb-0310-9956-ffa450edef68
2014-01-23 16:43:59 +00:00
Andreas Beeker
7084337351 Added license headers
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1559297 13f79535-47bb-0310-9956-ffa450edef68
2014-01-18 00:38:04 +00:00
Andreas Beeker
77436875d1 Bug 35897 - Password protected files
+ Junit4 modifications, needed for expected exceptions

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1557281 13f79535-47bb-0310-9956-ffa450edef68
2014-01-10 23:14:03 +00:00
Nick Burch
3a177b2706 Ensure our package html files have consistent line endings, and the right svn properties set on them
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1557156 13f79535-47bb-0310-9956-ffa450edef68
2014-01-10 15:39:39 +00:00
Dominik Stadler
ded360f287 Bug 55723: Make HSSFSheet.setAutoFilter() behave equal to XSSF, also make XSSF work when setAutoFilter is called multiple times
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1554688 13f79535-47bb-0310-9956-ffa450edef68
2014-01-01 22:15:44 +00:00
Dominik Stadler
62ec8b719b remove some unused imports and some useless TODOs, slightly more
coverage, @Overrides, more info on failing test, fix some Eclipse
warnings

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1554535 13f79535-47bb-0310-9956-ffa450edef68
2013-12-31 15:12:30 +00:00
Dominik Stadler
2c7fff15e1 Don't unnecessarily convert from ArrayList to array, use the ArrayList directly instead, this speeds up BiffViewer and related unit tests
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1554534 13f79535-47bb-0310-9956-ffa450edef68
2013-12-31 15:11:59 +00:00
Dominik Stadler
63e84bd79d Print out which actual value was out of range
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1554533 13f79535-47bb-0310-9956-ffa450edef68
2013-12-31 15:11:44 +00:00
Andreas Beeker
ece67b1a5f obsoleted by TestEscherBlipRecord and EscherMetafileBlip
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1554104 13f79535-47bb-0310-9956-ffa450edef68
2013-12-30 00:00:54 +00:00
Nick Burch
42933d40bc Fix whitespace - reformat to consistent spaces, instead of a mix of tabs and spaces
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1553625 13f79535-47bb-0310-9956-ffa450edef68
2013-12-27 04:26:18 +00:00
Dominik Stadler
b002f0497a Add some @Overrides suggested by Eclipse, generics and some warnings,
convert some tabs to spaces.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1553466 13f79535-47bb-0310-9956-ffa450edef68
2013-12-26 09:38:48 +00:00
Andreas Beeker
c0c4008124 Bug 55579 - [PATCH] Patch for add/embed OLE objects into HSLF
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1553435 13f79535-47bb-0310-9956-ffa450edef68
2013-12-26 00:46:16 +00:00
Andreas Beeker
c950d95a65 javadoc house-keeping
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1553422 13f79535-47bb-0310-9956-ffa450edef68
2013-12-25 22:18:53 +00:00
Dominik Stadler
22a0f8cf67 Fix some JavaDoc items that are reported in the build-output
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1553404 13f79535-47bb-0310-9956-ffa450edef68
2013-12-25 18:05:41 +00:00
Andreas Beeker
31458eb486 JCE policy fix
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1553342 13f79535-47bb-0310-9956-ffa450edef68
2013-12-25 01:04:29 +00:00
Andreas Beeker
5fd22dd31a Fix jdk-differences for encryption patch
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1553339 13f79535-47bb-0310-9956-ffa450edef68
2013-12-24 23:49:10 +00:00
Andreas Beeker
633084ecfd Fix jdk-differences for encryption patch
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1553338 13f79535-47bb-0310-9956-ffa450edef68
2013-12-24 23:39:09 +00:00
Andreas Beeker
bf2b13b9fa Patch for Bug/Enhancement 55818 - add encryption support
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1553336 13f79535-47bb-0310-9956-ffa450edef68
2013-12-24 23:13:21 +00:00
Yegor Kozlov
97e6fae71e patch 55731: StringBuilder logic in DataFormatter.cleanFormatForNumber
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1553248 13f79535-47bb-0310-9956-ffa450edef68
2013-12-24 06:02:27 +00:00
Yegor Kozlov
2dd8f267d0 patch 55730: Fix org.apache.poi.ss.usermodel.BuiltinFormats.java for 0x29-0x2c
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1553247 13f79535-47bb-0310-9956-ffa450edef68
2013-12-24 05:58:23 +00:00
Nick Burch
4135f84652 Fix bug #55901 - Avoid using RMI based
exception from PropertySetFactory, as it's not needed nor helpful

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1551832 13f79535-47bb-0310-9956-ffa450edef68
2013-12-18 04:08:03 +00:00
Nick Burch
a7099fe6b7 More javadocs for Cell.setCellType
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1550349 13f79535-47bb-0310-9956-ffa450edef68
2013-12-12 05:22:26 +00:00
Cédric Walter
c36b01a601 Bug 55768: added Line charts support and setting axis tick marks, title
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1544628 13f79535-47bb-0310-9956-ffa450edef68
2013-11-22 18:26:11 +00:00
Cédric Walter
4a55b25fd8 Bug 54676: added new chart axis type: Category axis
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1544612 13f79535-47bb-0310-9956-ffa450edef68
2013-11-22 17:45:00 +00:00
Nick Burch
bb7d33fe7c Patch from Andreas Beeker from bug #53475 - Switch XWPF test to JUnit 4, so that we can skip one part of the tests if the JVM doesn't support larger keys
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1544121 13f79535-47bb-0310-9956-ffa450edef68
2013-11-21 11:18:23 +00:00
Nick Burch
888f855287 Patch from Andreas Beeker from bug #53475 - further OOXML Encryption support, covering more ciphers
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1541009 13f79535-47bb-0310-9956-ffa450edef68
2013-11-12 11:37:45 +00:00