3275 Commits

Author SHA1 Message Date
Andreas Beeker
dd6d090969 fix rendering of xslf shapes with no/external blip part
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1861958 13f79535-47bb-0310-9956-ffa450edef68
2019-06-23 23:13:15 +00:00
Andreas Beeker
861988bac3 Bug 60656 - EMF image support in slideshows
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1861952 13f79535-47bb-0310-9956-ffa450edef68
2019-06-23 22:21:15 +00:00
Dominik Stadler
50874d9d0d Bug 63509: Allow to format a CellReference without sheet-name for ignoredErrors.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1861817 13f79535-47bb-0310-9956-ffa450edef68
2019-06-22 06:12:05 +00:00
PJ Fanning
25d3f3527d tidy up some int casts
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1861176 13f79535-47bb-0310-9956-ffa450edef68
2019-06-12 18:14:22 +00:00
PJ Fanning
f74a8f9abb [github-149] improve MAPIMessage.guess7BitEncoding, improve MAPIMessage.getHtmlBody. Thanks to Dominik Hölzl. This closes #149
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1860043 13f79535-47bb-0310-9956-ffa450edef68
2019-05-26 09:43:59 +00:00
PJ Fanning
3d5671ac5e remove some tab indents
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1859758 13f79535-47bb-0310-9956-ffa450edef68
2019-05-22 22:59:12 +00:00
Alain Béarez
e3df15d773 fix missing space in string literal (LGTM)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1859596 13f79535-47bb-0310-9956-ffa450edef68
2019-05-21 00:14:15 +00:00
Alain Béarez
928e6937f4 fix result of multiplication cast to wider type
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1859595 13f79535-47bb-0310-9956-ffa450edef68
2019-05-21 00:14:12 +00:00
Alain Béarez
906c52d81d fix whitespace contradicts operator precedence
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1859594 13f79535-47bb-0310-9956-ffa450edef68
2019-05-21 00:13:59 +00:00
Alain Béarez
5d376c8696 fix boxed variable is never null
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1859593 13f79535-47bb-0310-9956-ffa450edef68
2019-05-21 00:13:56 +00:00
Alain Béarez
a59ed12ecf fix potential output resource leaks (LGTM)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1859592 13f79535-47bb-0310-9956-ffa450edef68
2019-05-21 00:13:51 +00:00
Alain Béarez
8784d6d6d7 fix potential input resource leaks (LGTM)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1859591 13f79535-47bb-0310-9956-ffa450edef68
2019-05-21 00:13:47 +00:00
Dominik Stadler
b2130769b6 FileMagic now has patterns with up to 12 bytes (JPG)
Avoid exception if a very short file is encountered
Add more tests

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1859564 13f79535-47bb-0310-9956-ffa450edef68
2019-05-20 14:42:31 +00:00
Dominik Stadler
f4a3d3bb89 Refine JavaDoc of WorkbookFactory slightly
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1859368 13f79535-47bb-0310-9956-ffa450edef68
2019-05-16 11:40:38 +00:00
Tim Allison
b3da2d5e8a Bug 63431 -- unbug ChunkedCipherInputStream's read()
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1859251 13f79535-47bb-0310-9956-ffa450edef68
2019-05-15 00:56:15 +00:00
Andreas Beeker
049baa86d7 #59004 - HSLF rendering - adjust values for presetShapeDefinition differs in HSLF/XSLF
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1859102 13f79535-47bb-0310-9956-ffa450edef68
2019-05-10 20:55:24 +00:00
Andreas Beeker
ea0e01acc1 Bug 60656 - EMF image support in slideshows
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1858625 13f79535-47bb-0310-9956-ffa450edef68
2019-05-04 23:01:53 +00:00
Dominik Stadler
bd8fab1196 Close more file-handles in tests
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1858024 13f79535-47bb-0310-9956-ffa450edef68
2019-04-23 20:28:21 +00:00
PJ Fanning
cf5b72bc00 some more checks for int overflows
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1857609 13f79535-47bb-0310-9956-ffa450edef68
2019-04-15 23:10:04 +00:00
PJ Fanning
c56ebe15af use ArithmeticUtils for calculations that might overflow
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1857596 13f79535-47bb-0310-9956-ffa450edef68
2019-04-15 16:02:53 +00:00
PJ Fanning
3c7bb45e54 use ArithmeticUtils for calculations that might overflow
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1857594 13f79535-47bb-0310-9956-ffa450edef68
2019-04-15 15:45:59 +00:00
Dominik Stadler
8823c1a9ab Add missing license header
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1857483 13f79535-47bb-0310-9956-ffa450edef68
2019-04-13 17:19:05 +00:00
PJ Fanning
924b2c546b [bug-63344] add TempFilePOIFSFileSystem
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1857462 13f79535-47bb-0310-9956-ffa450edef68
2019-04-13 10:08:55 +00:00
PJ Fanning
bdc3b391fd [bug-63344] add TempFilePOIFSFileSystem
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1857461 13f79535-47bb-0310-9956-ffa450edef68
2019-04-13 10:03:02 +00:00
PJ Fanning
fb5d21b1bb adjust formatting
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1857452 13f79535-47bb-0310-9956-ffa450edef68
2019-04-13 08:08:36 +00:00
Tim Allison
cf76af521d Bug 63330 -- use skipfully instead of hoping skip() works
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1857277 13f79535-47bb-0310-9956-ffa450edef68
2019-04-10 19:11:02 +00:00
Dominik Stadler
b88c6b12e5 Improve error message slightly and verify error when a File is passed in
as "Object"

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1857067 13f79535-47bb-0310-9956-ffa450edef68
2019-04-07 07:17:41 +00:00
Dominik Stadler
0e69c64a62 Add some more variants of HTML with preceding newline which we see frequently
in the large regression test corpus

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1856689 13f79535-47bb-0310-9956-ffa450edef68
2019-03-31 19:29:42 +00:00
Dominik Stadler
097fd7a5e2 Close more file-handles in tests, convert junit3 tests
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1856688 13f79535-47bb-0310-9956-ffa450edef68
2019-03-31 19:29:34 +00:00
PJ Fanning
9576ab77f9 replace version number 4.0.2
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1856665 13f79535-47bb-0310-9956-ffa450edef68
2019-03-31 08:54:44 +00:00
Greg Woolsey
48ac6b4d02 fix a condition not seen until a recent expansion of the stress test. Gracefully ignore missing/invalid external sheet references in one more path (there were several already with comments like "this seems to be what Excel does in this case")
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1856655 13f79535-47bb-0310-9956-ffa450edef68
2019-03-31 03:49:16 +00:00
PJ Fanning
5d580f48e6 fix build issue
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1856649 13f79535-47bb-0310-9956-ffa450edef68
2019-03-30 21:57:50 +00:00
Greg Woolsey
67aad69757 #63292 1904 date windowing flag not used for some format cases
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1856648 13f79535-47bb-0310-9956-ffa450edef68
2019-03-30 20:13:24 +00:00
Greg Woolsey
0d22749477 #63291 CellFormat global cache isn't thread-safe
move date format synchronization down to where the problem instance is held. 

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1856647 13f79535-47bb-0310-9956-ffa450edef68
2019-03-30 19:33:02 +00:00
Greg Woolsey
30851e44a6 #63302 Formula evaluation of names with offset or row function is incorrect
thanks to John Lincoln White for the patch, including new unit tests.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1856644 13f79535-47bb-0310-9956-ffa450edef68
2019-03-30 18:14:14 +00:00
PJ Fanning
2a9390d683 [bug-63291] support concurrent date formatting with same DataFormatter
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1856449 13f79535-47bb-0310-9956-ffa450edef68
2019-03-27 23:04:40 +00:00
PJ Fanning
895b251367 some javadoc issues
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1855954 13f79535-47bb-0310-9956-ffa450edef68
2019-03-20 23:33:50 +00:00
Dominik Stadler
40f8d119c7 Remove more remnants of NPOIFSFileSystem, mostly in comments and variable names
This avoids confusion if people look at this code in the future without knowledge
about the historical transition from java.io to java.nio

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1855873 13f79535-47bb-0310-9956-ffa450edef68
2019-03-19 21:55:26 +00:00
PJ Fanning
f2d9c1a927 [bug-63268] fix issue where CellUtil.setFont is adding unnecessary styles
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1855806 13f79535-47bb-0310-9956-ffa450edef68
2019-03-19 05:59:00 +00:00
Greg Woolsey
82f9c29258 #60724 - Partial implementation for SUBTOTAL() 'ignore hidden rows' variations
The function still doesn't deal with auto-filtering, but it now handles variations that should skip hidden rows.

Taught the evaluation framework to know about hidden rows similar to what was already there for skipping subtotals within subtotal ranges.

Added unit test cases.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1855789 13f79535-47bb-0310-9956-ffa450edef68
2019-03-18 19:09:11 +00:00
Andreas Beeker
19005a4e63 Fix forbidden apis error
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1855672 13f79535-47bb-0310-9956-ffa450edef68
2019-03-16 20:44:12 +00:00
Yegor Kozlov
6ef332b48e Bug 61472: Convert date/time strings to numbers when evaluating formulas
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1855662 13f79535-47bb-0310-9956-ffa450edef68
2019-03-16 15:41:46 +00:00
Greg Woolsey
ee83ce5fcd Handle possible invalid date value (#61652)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1855627 13f79535-47bb-0310-9956-ffa450edef68
2019-03-16 06:55:16 +00:00
Greg Woolsey
8225326b56 #63264 Conditional Format rule evaluation calculates relative references incorrectly
Fixing the offset calculation and passing the top-left-most region rather than the region matching the current cell fixed these cases.  I've augmented unit tests to check for them to avoid future regressions.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1855619 13f79535-47bb-0310-9956-ffa450edef68
2019-03-16 00:27:13 +00:00
PJ Fanning
126606c838 fix some cases where iterator usage does not check hasNext
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1855480 13f79535-47bb-0310-9956-ffa450edef68
2019-03-14 04:01:10 +00:00
Dominik Stadler
a9b2a8b2bd Bug 63200: Avoid NullPointerException in XSLFShape.selectPaint() and check some more in integration tests
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1854639 13f79535-47bb-0310-9956-ffa450edef68
2019-03-02 12:28:19 +00:00
Dominik Stadler
53a30d796e Bug 62151: Fix warnings about illegal reflective access in Java 9+ by
using a similar approach as Apache Hadoop via a CleanerUtil class which encapsulates
the two different approaches for Java <= 8 and Java >= 9

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1854630 13f79535-47bb-0310-9956-ffa450edef68
2019-03-02 09:19:45 +00:00
Dominik Stadler
98b620889b Remove some remnants of NFileSystem
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1854191 13f79535-47bb-0310-9956-ffa450edef68
2019-02-23 07:52:06 +00:00
Dominik Stadler
8c6e95f597 Add some more testing for bug 63151: NullPointerException in HSSFOptimiser.optimiseFonts(), also execute it as part of large regression tests in the future
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1854190 13f79535-47bb-0310-9956-ffa450edef68
2019-02-23 07:51:57 +00:00
Yegor Kozlov
cafa57cbdd Bug 60980: Fix parsing formulas with intersections in functions args
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1854037 13f79535-47bb-0310-9956-ffa450edef68
2019-02-21 11:00:40 +00:00