54 Commits

Author SHA1 Message Date
PJ Fanning
bc0c0b19d2 update getCellType to return CellType enum instead of int
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808700 13f79535-47bb-0310-9956-ffa450edef68
2017-09-18 13:26:16 +00:00
Dominik Stadler
399381da8d Remove unnecessary local variables
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808518 13f79535-47bb-0310-9956-ffa450edef68
2017-09-16 08:28:38 +00:00
Dominik Stadler
0cfa1ede4c Remove unnecessary type arguments (Java 8)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808516 13f79535-47bb-0310-9956-ffa450edef68
2017-09-16 08:27:23 +00:00
Dominik Stadler
32370cfd1c Remove unnecessary initialization of members
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808510 13f79535-47bb-0310-9956-ffa450edef68
2017-09-16 08:22:59 +00:00
Nick Burch
f7356f2b19 Remove javadoc references to removed classes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808436 13f79535-47bb-0310-9956-ffa450edef68
2017-09-15 09:03:56 +00:00
PJ Fanning
deb0aca6ac remove some deprecated code slated for removal in 3.18
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808403 13f79535-47bb-0310-9956-ffa450edef68
2017-09-14 23:44:47 +00:00
PJ Fanning
52d3ea57f4 javadoc: replace invalid self enclosing elements
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1802110 13f79535-47bb-0310-9956-ffa450edef68
2017-07-17 08:24:24 +00:00
PJ Fanning
2a42bbafc6 remove more deprecated methods
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1801697 13f79535-47bb-0310-9956-ffa450edef68
2017-07-12 08:38:20 +00:00
PJ Fanning
329c87cc68 fix javadoc issue
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1800717 13f79535-47bb-0310-9956-ffa450edef68
2017-07-03 22:18:25 +00:00
PJ Fanning
26389768b9 [Bug 60422] fix data formatter issue with specific format in German locale
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1800713 13f79535-47bb-0310-9956-ffa450edef68
2017-07-03 20:56:02 +00:00
Dominik Stadler
5ca0b239bf Let IntelliJ cleanup some code-warnings across the whole code-base: unnecessary toString or semicolon
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1791720 13f79535-47bb-0310-9956-ffa450edef68
2017-04-17 20:13:52 +00:00
Javen O'Neal
7b38711979 Convert all *.java files to use native end of line character(s)
$ dos2unix `find -name *.java`
$ svn propset svn:eol-style native `find -name *.java`


git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1782114 13f79535-47bb-0310-9956-ffa450edef68
2017-02-08 07:47:30 +00:00
Andreas Beeker
2802a3c153 SonarQube fixes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1777541 13f79535-47bb-0310-9956-ffa450edef68
2017-01-06 09:05:14 +00:00
Javen O'Neal
1ff463ffb6 bug 59791: add deprecation and removal annotations
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760634 13f79535-47bb-0310-9956-ffa450edef68
2016-09-14 05:51:52 +00:00
Javen O'Neal
0dc2e3e765 bug 59804: indicate when features were @Internal-ized
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751570 13f79535-47bb-0310-9956-ffa450edef68
2016-07-05 23:22:49 +00:00
Javen O'Neal
4f92e81892 bug 59791: CellFormat#ultimateType(Cell) should return an integer for backwards compatibility (use ultimateTypeEnum for now for CellType enums); re-add SXSSFCell(SXSSFRow, int) for backwards compatibility
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751273 13f79535-47bb-0310-9956-ffa450edef68
2016-07-04 13:09:30 +00:00
Javen O'Neal
5582593ad1 bug 59791: getCellType and getCachedFormulaResultType should return an integer for backwards compatibility
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751256 13f79535-47bb-0310-9956-ffa450edef68
2016-07-04 11:54:20 +00:00
Javen O'Neal
8d31c01f40 bug 59791: replace deprecated Cell.CELL_TYPE_* usage with CellType.*
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751240 13f79535-47bb-0310-9956-ffa450edef68
2016-07-04 10:15:18 +00:00
Javen O'Neal
fb8c79d96c bug 59791: convert Cell Type to an enum
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751237 13f79535-47bb-0310-9956-ffa450edef68
2016-07-04 09:45:46 +00:00
Dominik Stadler
734cd9d484 Code cleanup via IntelliJ: Remove unnecessary semicolon
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738031 13f79535-47bb-0310-9956-ffa450edef68
2016-04-06 19:49:47 +00:00
Andreas Beeker
defe39208c sonar fix
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735507 13f79535-47bb-0310-9956-ffa450edef68
2016-03-17 21:52:53 +00:00
Andreas Beeker
fc83bdaf9e forgot another contains call ...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735349 13f79535-47bb-0310-9956-ffa450edef68
2016-03-16 23:40:00 +00:00
Andreas Beeker
ee4b65394f findbugs fix
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735348 13f79535-47bb-0310-9956-ffa450edef68
2016-03-16 23:36:17 +00:00
Andreas Beeker
6841ce8d55 First try of uncluttering CellNumberFormatter.
Make inner classes static and remove setting of private outer properties while in constructor.
Make properties final to make sure they are only set once.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735300 13f79535-47bb-0310-9956-ffa450edef68
2016-03-16 21:18:58 +00:00
Dominik Stadler
0ba83f7683 Regression in version 3.14-beta1: three or four-part formats with locale id cause exceptions when formatting instead of falling back to other formatting
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1724488 13f79535-47bb-0310-9956-ffa450edef68
2016-01-13 19:46:17 +00:00
Dominik Stadler
bd25521857 Eclipse warnings, helper unit-test, improve information provided in Exceptions, do not swallow inner stacktraces, ...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1724486 13f79535-47bb-0310-9956-ffa450edef68
2016-01-13 19:45:05 +00:00
Andreas Beeker
b15b18bae7 replace Throwable.printStackTrace() with POILogger calls - Todo: other printStrackTrace(...) calls
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1723899 13f79535-47bb-0310-9956-ffa450edef68
2016-01-10 02:20:35 +00:00
Andreas Beeker
4241f26a13 fix unnecessary cast warnings
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1715626 13f79535-47bb-0310-9956-ffa450edef68
2015-11-22 12:30:42 +00:00
Nick Burch
9a080e3666 58536 DataFormatter and CellFormat non-localised support for localised currency formats like [$£-809]
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1710484 13f79535-47bb-0310-9956-ffa450edef68
2015-10-25 21:20:44 +00:00
Nick Burch
1a96a88ef2 Mention about Locale definitions in Excel cell data format strings
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1710459 13f79535-47bb-0310-9956-ffa450edef68
2015-10-25 16:13:16 +00:00
Andreas Beeker
1a0365739f forbidden apis fixes - a few DateFormat clean ups ...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1701888 13f79535-47bb-0310-9956-ffa450edef68
2015-09-09 00:41:03 +00:00
Andreas Beeker
e84b4d041c forbidden apis fixes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1701710 13f79535-47bb-0310-9956-ffa450edef68
2015-09-07 22:34:21 +00:00
Andreas Beeker
a3d2eb57ff Bug 58326 - Forbidden APIs patches - first set of changes for locale and timezone settings
also includes fixes for
- name shadowing 
- unused deprecated method "getClipRect" in classes extending Graphics2d
- HexDump - replaced intermediate String.format calls with custom padding
- convert testcases to junit4
- closing resources

also tested with an arbitary timezone (PST) and locale (ru)

supresses forbidden apis check for
- LocaleUtil (the only place where Locale.getDefault() and TimeZone.getDefault() should be called)
- Classes using FontMetrics - without the actual text it's difficult to return something sane

Some usage of UTC and Locale.ROOT might be still wrong, e.g. in MapiMessage we don't access the
extended mapi properties, which might contain the timezone

DataFormatter has now a Observable property which need to be observed when custom formats are used
and the Locale changes

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1701688 13f79535-47bb-0310-9956-ffa450edef68
2015-09-07 20:19:50 +00:00
Nick Burch
a49d4bdd07 Fix some Forbidden APIs errors
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1700675 13f79535-47bb-0310-9956-ffa450edef68
2015-09-01 21:31:02 +00:00
Nick Burch
2f4f7983b8 Fix some Forbidden APIs errors
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1700646 13f79535-47bb-0310-9956-ffa450edef68
2015-09-01 19:16:21 +00:00
Nick Burch
1c21c4efc6 Fix some Forbidden APIs errors
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1700642 13f79535-47bb-0310-9956-ffa450edef68
2015-09-01 19:01:36 +00:00
Nick Burch
e54f105bc0 Fix some Forbidden APIs errors
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1700641 13f79535-47bb-0310-9956-ffa450edef68
2015-09-01 18:56:44 +00:00
Nick Burch
5f05589bb7 Fix a handful of forbidden apis identified problems
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1698198 13f79535-47bb-0310-9956-ffa450edef68
2015-08-27 17:21:35 +00:00
Nick Burch
e4a987e893 Patch from Javen ONeal from bug #58254 - CellFormatResult.text should check for nulls as per the javadoc
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1696638 13f79535-47bb-0310-9956-ffa450edef68
2015-08-19 18:00:31 +00:00
Nick Burch
6a786df01b Comments, imports and warnings
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1696436 13f79535-47bb-0310-9956-ffa450edef68
2015-08-18 14:59:52 +00:00
Dominik Stadler
da1738611a Add some missing close() calls and fix some generics warnings
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1637703 13f79535-47bb-0310-9956-ffa450edef68
2014-11-09 17:53:10 +00:00
Andreas Beeker
bc5912e74d FindBugs fix
- fixed "Equals method should not assume anything about the type of its argument"
- see http://findbugs.sourceforge.net/bugDescriptions.html#BC_EQUALS_METHOD_SHOULD_WORK_FOR_ALL_OBJECTS

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1568861 13f79535-47bb-0310-9956-ffa450edef68
2014-02-16 23:36:32 +00:00
Dominik Stadler
22a0f8cf67 Fix some JavaDoc items that are reported in the build-output
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1553404 13f79535-47bb-0310-9956-ffa450edef68
2013-12-25 18:05:41 +00:00
Tim Allison
0c35aa60e1 55419 and refactor SimpleFraction
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1514123 13f79535-47bb-0310-9956-ffa450edef68
2013-08-15 01:46:25 +00:00
Yegor Kozlov
00831d3c5b Bugzilla 53369 fixed TestCellFormatPart.testDateFormat failing on jdk 1.7
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1364058 13f79535-47bb-0310-9956-ffa450edef68
2012-07-21 10:08:07 +00:00
Yegor Kozlov
41ac3b51d3 Bugzilla 52708 - misc improvements in CellFormat
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1294072 13f79535-47bb-0310-9956-ffa450edef68
2012-02-27 09:26:36 +00:00
Nick Burch
f879c880d4 Add TODO for merging CellFormat and DataFormatter
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1291206 13f79535-47bb-0310-9956-ffa450edef68
2012-02-20 11:29:58 +00:00
Nick Burch
e0198826c3 Patch from Steve Vysny from bug #52438 - Update CellDateFormatter to handle times without seconds
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1229281 13f79535-47bb-0310-9956-ffa450edef68
2012-01-09 18:21:54 +00:00
Nick Burch
21ebb4606f Apply patch from bug #51476 - Correct XSSF cell formatting in HTML export
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1144331 13f79535-47bb-0310-9956-ffa450edef68
2011-07-08 14:27:21 +00:00
Nick Burch
bcf0cf3b32 Fix generics warnings
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1077923 13f79535-47bb-0310-9956-ffa450edef68
2011-03-04 12:56:25 +00:00