801 Commits

Author SHA1 Message Date
PJ Fanning
efce9ba930 add back check for if dir already exists
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1917583 13f79535-47bb-0310-9956-ffa450edef68
2024-05-08 17:24:41 +00:00
Dominik Stadler
3800aa5418 Bug 66425: Avoid exceptions found via poi-fuzz
Avoid a possible NullPointerException

Fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=67922

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1917269 13f79535-47bb-0310-9956-ffa450edef68
2024-04-22 13:32:30 +00:00
Dominik Stadler
48a69cd5df Add one more "flaky" byte when comparing two documents
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1917177 13f79535-47bb-0310-9956-ffa450edef68
2024-04-20 07:53:47 +00:00
Dominik Stadler
4a3b92b305 Comment out flaky assertion and add more information to find which file fails in CI
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1917072 13f79535-47bb-0310-9956-ffa450edef68
2024-04-17 18:50:32 +00:00
Dominik Stadler
9453fa908a Bug 66425: Avoid exceptions found via poi-fuzz
Use correct default date-format, add some tests

Fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=66381

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1917070 13f79535-47bb-0310-9956-ffa450edef68
2024-04-17 18:15:46 +00:00
PJ Fanning
c715f9ee1d [github-607] Support SVGs in XWPF. Thanks to Etienne Gautier. This closes #607
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1916582 13f79535-47bb-0310-9956-ffa450edef68
2024-03-27 13:33:57 +00:00
Dominik Stadler
f4af02bb24 Bug 68778: Verify "ignoreMissingFontSystem" for SheetUtil.getDefaultCharWidthAsFloat()
This functionality saw some regressions at times and thus
should be verified via unit-tests. 

We can simulate failures in the low-level font-system by 
mocking the FontRenderContext and triggering exceptions
from there.

This hopefully now verifies behavior of 
SheetUtil.getDefaultCharWidthAsFloat() both with 
"ignoreMissingFontSystem" enabled and disabled.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1916297 13f79535-47bb-0310-9956-ffa450edef68
2024-03-14 13:20:47 +00:00
Axel Howind
263171f80e use method reference
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1916035 13f79535-47bb-0310-9956-ffa450edef68
2024-02-28 09:35:49 +00:00
Axel Howind
6b40b7f966 use Map.computeIfAbsent()
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1916034 13f79535-47bb-0310-9956-ffa450edef68
2024-02-28 09:35:46 +00:00
PJ Fanning
2496ce5229 rework tests
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1916017 13f79535-47bb-0310-9956-ffa450edef68
2024-02-26 23:05:36 +00:00
Axel Howind
05af0e0bf3 Math.toIntExact is unnecessary because value is guaranteed to be between 0 and 15
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1915959 13f79535-47bb-0310-9956-ffa450edef68
2024-02-22 20:56:03 +00:00
Axel Howind
17c6a1ec50 replace List<Byte> with ByteArrayOutputStream to avoid boxing/unboxing and repeated copying of data
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1915958 13f79535-47bb-0310-9956-ffa450edef68
2024-02-22 20:48:04 +00:00
Axel Howind
39a1ced25e fix Logging issues:
- don't use foreign class in Logger initialization
- update log statements to use MessageFormat syntax

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1915930 13f79535-47bb-0310-9956-ffa450edef68
2024-02-21 21:28:04 +00:00
Axel Howind
cb10857970 make loggers static final
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1915929 13f79535-47bb-0310-9956-ffa450edef68
2024-02-21 21:04:58 +00:00
Axel Howind
386ddb8e6b move setting of locale for tests to top level build.gradle
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1915910 13f79535-47bb-0310-9956-ffa450edef68
2024-02-20 22:48:53 +00:00
PJ Fanning
d59d6b7d7d [github-596] Change cast logic in HSSFChart. Thanks to Ruby Hartono. This closes #596
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1915881 13f79535-47bb-0310-9956-ffa450edef68
2024-02-19 20:11:45 +00:00
PJ Fanning
23ed93817f remove unused loggers. Thanks to Ruby Hartono. This closes #594 and closes #595
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1915870 13f79535-47bb-0310-9956-ffa450edef68
2024-02-19 10:10:57 +00:00
Axel Howind
63899a8810 fix #68635: POI unit tests fail when run under non-US locale
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1915827 13f79535-47bb-0310-9956-ffa450edef68
2024-02-17 15:47:46 +00:00
PJ Fanning
c871bb7b9f remove unused loggers - thanks to Ruby Hartono. This closes #588 and closes #589
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1915819 13f79535-47bb-0310-9956-ffa450edef68
2024-02-16 15:25:24 +00:00
PJ Fanning
dc025d9365 [github-590] simplify some logging. This closes #590
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1915818 13f79535-47bb-0310-9956-ffa450edef68
2024-02-16 15:12:54 +00:00
PJ Fanning
2469b89ee6 [github-582] improve performance CodepointsUtil.iteratorFor. Thanks to Jason Mirra. This closes #582
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1915572 13f79535-47bb-0310-9956-ffa450edef68
2024-02-03 21:06:38 +00:00
PJ Fanning
e455798019 remove one use of CodepointsUtil.iteratorFor
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1915571 13f79535-47bb-0310-9956-ffa450edef68
2024-02-03 20:20:40 +00:00
Dominik Stadler
209e8fc659 Fix handling missing font libraries to again not throw on some types of exception
The previous change broke this handling by always re-throwing "Fatal" exceptions.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1915482 13f79535-47bb-0310-9956-ffa450edef68
2024-01-30 21:01:53 +00:00
Dominik Stadler
147c96da67 Bug 66425: Avoid exceptions found via poi-fuzz
Prevent a few NullPointerException

Fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=65450 and
https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=63907 and
https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=63727

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1915480 13f79535-47bb-0310-9956-ffa450edef68
2024-01-30 21:01:46 +00:00
PJ Fanning
274a7e24f3 [github-578] allow any non-fatal exception when setting up fonts to indicate that the fonts are probably not installed. This closes #578
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1915397 13f79535-47bb-0310-9956-ffa450edef68
2024-01-25 10:03:29 +00:00
Dominik Stadler
a27029d1af Bug 66425: Avoid exceptions found via poi-fuzz
Prevent NullPointerException

Fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=64212

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1915006 13f79535-47bb-0310-9956-ffa450edef68
2023-12-30 19:39:42 +00:00
Dominik Stadler
4d175324f2 Bug 66425: Avoid exceptions found via poi-fuzz
Prevent ClassCastException

Fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=63736

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1915003 13f79535-47bb-0310-9956-ffa450edef68
2023-12-30 19:39:24 +00:00
Dominik Stadler
8507fdf371 Bug 66425: Avoid exceptions found via poi-fuzz
Prevent ClassCastException

Fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=63504

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1914991 13f79535-47bb-0310-9956-ffa450edef68
2023-12-30 11:11:42 +00:00
Dominik Stadler
28811d26df Bug 66425: Avoid exceptions found via poi-fuzz
Prevent ClassCastException

Fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=63375

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1914990 13f79535-47bb-0310-9956-ffa450edef68
2023-12-30 11:11:36 +00:00
Dominik Stadler
8e3b60f63d Bug 66425: Avoid exceptions found via poi-fuzz
Prevent StackOverflow via endless nesting

Fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=65303

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1914989 13f79535-47bb-0310-9956-ffa450edef68
2023-12-30 11:11:32 +00:00
PJ Fanning
7e5e9fcc62 try to javadoc more unsupported methods
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1914791 13f79535-47bb-0310-9956-ffa450edef68
2023-12-20 08:14:13 +00:00
Dominik Stadler
c8c8130ae3 Make sure OLE2ScratchpadExtractorFacory is sorted first
Otherwise order of found extractors would depend on jar-loading order
and thus might have unexpected side-effects and missing features in
text-extraction.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1914407 13f79535-47bb-0310-9956-ffa450edef68
2023-12-06 19:50:02 +00:00
Dominik Stadler
15dd62d659 Bug 66425: Avoid exceptions found via poi-fuzz
Avoid a ClassCastException and trigger some more
code in integration-testing.

Fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=63358

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1914404 13f79535-47bb-0310-9956-ffa450edef68
2023-12-06 19:49:52 +00:00
PJ Fanning
8819952b2f [bug-68094] try to improve cell width derivation by not rounding
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1913676 13f79535-47bb-0310-9956-ffa450edef68
2023-11-08 13:41:53 +00:00
PJ Fanning
e83987b35d [github-545] Make exported sheet names compatible with Excel. Thanks to Aleksandrs Jansons. This closes #545
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1913660 13f79535-47bb-0310-9956-ffa450edef68
2023-11-07 21:50:12 +00:00
PJ Fanning
76b1a6fee4 try to fix broken sxssf tests
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1913651 13f79535-47bb-0310-9956-ffa450edef68
2023-11-07 12:23:53 +00:00
PJ Fanning
c9506f0f39 fix broken HSSFWorkbook test
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1913648 13f79535-47bb-0310-9956-ffa450edef68
2023-11-07 12:00:57 +00:00
Dominik Stadler
56eb1ccff6 Bug 66425: Avoid exceptions found via poi-fuzz
Fix one expected exception-text which is different
on newer Java versions

Fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=63143

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1913384 13f79535-47bb-0310-9956-ffa450edef68
2023-10-27 10:08:04 +00:00
PJ Fanning
bcfd81f489 [bug-67579] test that we close input stream
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1913352 13f79535-47bb-0310-9956-ffa450edef68
2023-10-26 15:19:42 +00:00
PJ Fanning
d4373c2d09 try to close streams in HSSF tests
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1913351 13f79535-47bb-0310-9956-ffa450edef68
2023-10-26 15:02:52 +00:00
PJ Fanning
5035a531c5 [bug-67784] add test for divide error
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1913065 13f79535-47bb-0310-9956-ffa450edef68
2023-10-17 14:39:54 +00:00
PJ Fanning
08aa6d1730 [bug-67784] add test for divide error
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1913064 13f79535-47bb-0310-9956-ffa450edef68
2023-10-17 14:27:25 +00:00
PJ Fanning
dbddc32c1b [bug-67475] better support for edge cases in TEXT function. Thanks to Jakub Vojtisek
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1912973 13f79535-47bb-0310-9956-ffa450edef68
2023-10-14 22:34:58 +00:00
PJ Fanning
fccf4a97fb add back leading len into slideshow DrawTextFragment height
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1912967 13f79535-47bb-0310-9956-ffa450edef68
2023-10-14 14:47:34 +00:00
Dominik Stadler
e43c1bc911 Bug 66425: Avoid Exceptions found via oss-fuzz
We try to avoid throwing ConcurrentModificationException,
but it was possible to trigger one here with a specially
crafted input-file

Should fix https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=62861

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1912797 13f79535-47bb-0310-9956-ffa450edef68
2023-10-07 22:12:50 +00:00
Dominik Stadler
5cd4fa5488 Bug 66425: Avoid Exceptions found via oss-fuzz
We try to avoid throwing ClassCastExceptions,
but it was possible to trigger one here with a specially
crafted input-file

Should fix https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=62795

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1912796 13f79535-47bb-0310-9956-ffa450edef68
2023-10-07 22:12:43 +00:00
Dominik Stadler
6fae5bbc18 Bug 66425: Avoid Exceptions found via oss-fuzz
We try to avoid throwing NullPointerExceptions or endless allocations,
but it was possible to trigger one here with a specially
crafted input-file

Should fix https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=62697

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1912793 13f79535-47bb-0310-9956-ffa450edef68
2023-10-07 22:12:25 +00:00
Dominik Stadler
c331c5d26a Bug 66425: Avoid a NullPointerException found via oss-fuzz
We try to avoid throwing NullPointerException, but it was possible
to trigger one here with a specially crafted input-file

Should fix https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=62626

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1912792 13f79535-47bb-0310-9956-ffa450edef68
2023-10-07 22:12:18 +00:00
Dominik Stadler
e8e6f671ef Assert that deleting test-files and entries works in tests
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1912709 13f79535-47bb-0310-9956-ffa450edef68
2023-10-03 06:17:01 +00:00
Dominik Stadler
360c05d9e3 Bug 66425: Avoid exceptions found via poi-fuzz
We try to avoid throwing NullPointerException, ClassCastExceptions 
and StackOverflowException, but it was possible to trigger them

Also improve some exception messages

Fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=62698
https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=62606
https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=62685

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1912707 13f79535-47bb-0310-9956-ffa450edef68
2023-10-03 06:05:30 +00:00