8567 Commits

Author SHA1 Message Date
Dominik Stadler
f34b731e3a Allow JUnit 5 access to the parmaeters also on newer JDKs
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1885070 13f79535-47bb-0310-9956-ffa450edef68
2021-01-03 17:02:21 +00:00
Dominik Stadler
83383cd0b7 Ignore Font-issue with JDK 8 on Windows in another test
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1885069 13f79535-47bb-0310-9956-ffa450edef68
2021-01-03 17:02:18 +00:00
Dominik Stadler
fcf123fc5b Apply some IDE suggestions
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1885068 13f79535-47bb-0310-9956-ffa450edef68
2021-01-03 17:02:14 +00:00
Dominik Stadler
218354f5b9 Bug 64494: Ensure "applyAlignment" in cell-styles is enabled when necessary
Also check it when fetching currently defined cell-alignment

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1885059 13f79535-47bb-0310-9956-ffa450edef68
2021-01-03 12:01:08 +00:00
Dominik Stadler
e59e84a213 Avoid test failing on Windows with JDK 8 because of an ArrayIndexOutOfBoundsException when handling fonts
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1885058 13f79535-47bb-0310-9956-ffa450edef68
2021-01-03 11:50:04 +00:00
Dominik Stadler
e08a1785c3 ooxml-schema: trigger loading stress-documents as part of the normal unit-tests
The integration-tests are not executed for determining the parts of the schema
to include in the "lite" package and so we need to have a normal unit-test as well.
Add more documents which drag in some more parts from the ooxml-schema

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1885057 13f79535-47bb-0310-9956-ffa450edef68
2021-01-03 11:49:59 +00:00
Dominik Stadler
622574f5f4 Bug 64450: Allow to parse a file where the relationship-id is an empty string
Also improve exception reporting by including more information and not
"hiding" the actual exception-cause in a log-statement.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1885056 13f79535-47bb-0310-9956-ffa450edef68
2021-01-03 11:49:51 +00:00
Andreas Beeker
620b8d2c5c Sonar fixes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1885035 13f79535-47bb-0310-9956-ffa450edef68
2021-01-02 21:00:18 +00:00
Andreas Beeker
6658a0b664 forbidden-apis-fix
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1885022 13f79535-47bb-0310-9956-ffa450edef68
2021-01-01 23:26:25 +00:00
Andreas Beeker
dc72c1a009 fix year agnostic date/test values
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1885021 13f79535-47bb-0310-9956-ffa450edef68
2021-01-01 23:20:02 +00:00
Dominik Stadler
8347bb64ac Apply some IDE suggestions and fix some JavaDoc
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1885012 13f79535-47bb-0310-9956-ffa450edef68
2021-01-01 15:51:30 +00:00
Dominik Stadler
685af351d1 Bug 64750: Do not use CTDataValidations.getCount(), instead only rely on getDataValidationArray
Field "count" seems to be optional according
to the schema, so by using only the array
Apache POI can read data validations from
workbooks that do not populate the
"count" field properly.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1885011 13f79535-47bb-0310-9956-ffa450edef68
2021-01-01 15:51:19 +00:00
Andreas Beeker
e4b70720be workaround NullPointerException when font family (of bullets) can't be determined
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1884974 13f79535-47bb-0310-9956-ffa450edef68
2020-12-30 23:33:05 +00:00
Andreas Beeker
91eb4861b7 workaround "Width (0) and height (0) cannot be <= 0" error while rendering text with textures
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1884966 13f79535-47bb-0310-9956-ffa450edef68
2020-12-30 23:13:23 +00:00
Andreas Beeker
f7c50cfbe3 add failing regression test files
fix ooxml-lite packaging
fix PP97 dual storage file handling in extractor

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1884962 13f79535-47bb-0310-9956-ffa450edef68
2020-12-30 22:56:36 +00:00
Dominik Stadler
b231366fb6 Bug 64986: Support missing or blank match_type for function Match
Excel and LibreOffice use the default value in this case

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1884959 13f79535-47bb-0310-9956-ffa450edef68
2020-12-30 21:40:12 +00:00
Dominik Stadler
99dc9ea7f3 Bug 64838: Do not populate cells with a paragraph when loading an existing document
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1884958 13f79535-47bb-0310-9956-ffa450edef68
2020-12-30 21:40:06 +00:00
Dominik Stadler
42c4e7d89a Add unfixed test for bug 64759 and make the ones fail which depend on manual opening of files in Microsoft Excel for verification
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1884957 13f79535-47bb-0310-9956-ffa450edef68
2020-12-30 21:40:01 +00:00
Dominik Stadler
6a7003ff4f Also replace for JUnit 5 in comments
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1884956 13f79535-47bb-0310-9956-ffa450edef68
2020-12-30 21:39:56 +00:00
Dominik Stadler
0172ec3d50 Adjust error-message on old files and simplify code slightly
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1884950 13f79535-47bb-0310-9956-ffa450edef68
2020-12-30 17:03:30 +00:00
Dominik Stadler
d406b402dc Slightly re-arrange code to only perform computations if we do not exit the loop anyway
Also simplify code somewhat

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1884949 13f79535-47bb-0310-9956-ffa450edef68
2020-12-30 17:03:27 +00:00
Dominik Stadler
ac2e1d761e Bug 65009: Fix incorrect index for 1-based pictures
Adjusted somewhat from Github PR #211

Closes #211

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1884948 13f79535-47bb-0310-9956-ffa450edef68
2020-12-30 17:03:23 +00:00
Dominik Stadler
de1ad1c44c Adjust some JavaDoc
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1884918 13f79535-47bb-0310-9956-ffa450edef68
2020-12-29 19:29:27 +00:00
Dominik Stadler
a7c1d84c5d Improve the speed of the styles-optimiser when there are many styles in a Workbook
Profiling showed that the call to isUserDefined() took most of the time,
so we now fetch this only once for each style and remember the result and
use it in the inner loop.

The attached sample-file took aprox. 1m30s on a decent machine, now it is down
to around 2s.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1884917 13f79535-47bb-0310-9956-ffa450edef68
2020-12-29 19:29:22 +00:00
Andreas Beeker
77fc30c0e0 sonar fixes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1884874 13f79535-47bb-0310-9956-ffa450edef68
2020-12-28 14:06:24 +00:00
Andreas Beeker
0ab727bbde github-207 - replace commons logging with slf4j - use jcl-over-slf4j
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1884873 13f79535-47bb-0310-9956-ffa450edef68
2020-12-28 14:03:36 +00:00
Andreas Beeker
07ba96f023 gather necessary .xsb for ooxml-lite jar via intercepting the calls to SchemaTypeSystemImpl.XsbReader
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1884850 13f79535-47bb-0310-9956-ffa450edef68
2020-12-28 00:47:23 +00:00
Andreas Beeker
b0830f9d94 Forbidden-apis fix - Graphics2D.finalize() is deprecated by Java14
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1884813 13f79535-47bb-0310-9956-ffa450edef68
2020-12-26 09:09:17 +00:00
Andreas Beeker
d121353f61 Sonar fixes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1884807 13f79535-47bb-0310-9956-ffa450edef68
2020-12-26 00:08:19 +00:00
PJ Fanning
353293f244 [bug-65023] add col bugfix. Thanks to Paula Muldoon, This closes #212
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1884794 13f79535-47bb-0310-9956-ffa450edef68
2020-12-25 09:50:50 +00:00
Andreas Beeker
6b6e96e07d try to fix distsourcebuild error
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1884785 13f79535-47bb-0310-9956-ffa450edef68
2020-12-25 01:42:10 +00:00
Andreas Beeker
a0fa9e19b1 #65026 - Migrate tests to Junit 5
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1884783 13f79535-47bb-0310-9956-ffa450edef68
2020-12-24 18:42:29 +00:00
Dominik Stadler
01dabc0d1b Fix NullPointerException in Autosize introduced via #64981
Only happened when alignment is set
Add a test reproducing the problem
Also verify auto-size on SXSSF

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1884653 13f79535-47bb-0310-9956-ffa450edef68
2020-12-20 18:47:56 +00:00
PJ Fanning
d20fa44305 [github-198] Remove jdk.charset module dependency for spreadsheets generation. Thanks to Robert Marcano. This closes #198
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1884631 13f79535-47bb-0310-9956-ffa450edef68
2020-12-19 19:45:09 +00:00
PJ Fanning
b2bfc99cdc fix log text
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1884623 13f79535-47bb-0310-9956-ffa450edef68
2020-12-19 09:47:19 +00:00
PJ Fanning
dc2fa9b635 add slf4j dependency
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1884603 13f79535-47bb-0310-9956-ffa450edef68
2020-12-18 10:04:01 +00:00
PJ Fanning
4d01d35230 add missing license
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1884584 13f79535-47bb-0310-9956-ffa450edef68
2020-12-18 00:25:46 +00:00
PJ Fanning
1e43266c7a avoid string concats
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1884581 13f79535-47bb-0310-9956-ffa450edef68
2020-12-18 00:17:50 +00:00
Andreas Beeker
bfade7c591 #64876 - Unable to convert pptx to pdf
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1884578 13f79535-47bb-0310-9956-ffa450edef68
2020-12-17 23:42:26 +00:00
PJ Fanning
fcc808d17d [github-208] Fix a few instances of incorrect NotImplemented documentation. Thanks to Marius Volkhart. This closes #208
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1884575 13f79535-47bb-0310-9956-ffa450edef68
2020-12-17 22:05:35 +00:00
PJ Fanning
2b14dc36bb avoid string concats
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1884574 13f79535-47bb-0310-9956-ffa450edef68
2020-12-17 21:54:42 +00:00
PJ Fanning
bd1d31e410 avoid string concats
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1884573 13f79535-47bb-0310-9956-ffa450edef68
2020-12-17 21:42:19 +00:00
PJ Fanning
0e0d1d56da avoid string concats
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1884572 13f79535-47bb-0310-9956-ffa450edef68
2020-12-17 21:03:27 +00:00
PJ Fanning
e1b0bc6e1d [github-207] add SLF4JLogger
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1884568 13f79535-47bb-0310-9956-ffa450edef68
2020-12-17 19:59:01 +00:00
Dominik Stadler
71d6bf0306 Do not wrap RuntimeException so we still can handle them directly
This broke the CI when the "JCE Unlimited Strength Jurisdiction Policy files"
are missing, e.g. on some Windows Jenkins nodes.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1884529 13f79535-47bb-0310-9956-ffa450edef68
2020-12-16 20:55:14 +00:00
PJ Fanning
9c1eb6b18e use less contentious language in code comments
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1884473 13f79535-47bb-0310-9956-ffa450edef68
2020-12-15 23:04:14 +00:00
Andreas Beeker
9fdda0ed2c #64981 - Upgrade OOXML schema to 5th edition (transitional)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1884386 13f79535-47bb-0310-9956-ffa450edef68
2020-12-13 17:48:31 +00:00
Andreas Beeker
c8940e7d1e #64979 - Change artifact names of poi-/ooxml-schemas
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1884381 13f79535-47bb-0310-9956-ffa450edef68
2020-12-13 15:32:43 +00:00
Andreas Beeker
83c6910dbd mute talkative tests, which spam to StdOut/StdErr
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1884379 13f79535-47bb-0310-9956-ffa450edef68
2020-12-13 13:10:53 +00:00
Andreas Beeker
c5f6dfa68e Bug 56205 - Upgrade OOXML schema to 3rd edition (transitional)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1884368 13f79535-47bb-0310-9956-ffa450edef68
2020-12-12 23:15:20 +00:00