pashko/apache-poi
1
0
Fork 0
mirror of https://github.com/apache/poi.git synced 2026-02-27 20:40:08 +08:00
Code Issues Packages Projects Releases Wiki Activity

[bug-69646] add tests

Browse Source 
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1924986 13f79535-47bb-0310-9956-ffa450edef68
This commit is contained in:
PJ Fanning 2025-04-10 08:08:22 +00:00
parent 6cbc6694ab
commit 8bf71069cd
2 changed files with 16 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
poi-ooxml/src/main/java/org/apache/poi/xssf/streaming/SheetDataWriter.java
View File

@ -460,7 +460,7 @@ public class SheetDataWriter implements Closeable {
try {
_out.close();
} finally {
ret = _fd != null && _fd.delete();
ret = _fd == null || _fd.delete();
}
return ret;
}

15
poi-ooxml/src/test/java/org/apache/poi/xssf/streaming/TestSheetDataWriter.java
View File

@ -26,6 +26,7 @@ import static org.junit.jupiter.api.Assertions.assertTrue;
import java.io.File;
import java.io.FileInputStream;
import java.io.IOException;
import java.io.StringWriter;
import java.nio.charset.StandardCharsets;
import org.apache.poi.util.IOUtils;
@ -69,6 +70,7 @@ public final class TestSheetDataWriter {
IOUtils.closeQuietly(writer);
}
}
@Test
void testWriteNewLines() throws IOException {
SheetDataWriter writer = new SheetDataWriter();
@ -84,4 +86,17 @@ public final class TestSheetDataWriter {
IOUtils.closeQuietly(writer);
}
}
@Test
void testDispose() throws IOException {
SheetDataWriter writer = new SheetDataWriter();
assertTrue(writer.dispose());
}
@Test
void testWriterDispose() throws IOException {
StringWriter sw = new StringWriter();
SheetDataWriter writer = new SheetDataWriter(sw);
assertTrue(writer.dispose());
}
}